[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 7/7] xen/arm: introduce new xen,enhanced property value
- To: Julien Grall <julien@xxxxxxx>
- From: Rahul Singh <Rahul.Singh@xxxxxxx>
- Date: Wed, 24 Aug 2022 14:42:07 +0000
- Accept-language: en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UYzLOy85i8ksr3gQDKRbA4+ll4/deoogWansLh9DBs8=; b=hG/EpiCuQ/6BpvV+q2tVB+cYHkoN9ggSvM36AJUIdlD36DmjQUmsCIdb40g4Z+xKbQP0A3wwE6He4eWz2XFUY8kyxXOUk4GX7jNIwlR4+Wvy1r/R2XLBn7UVzcD77eM4MGGNRL2oksCUiiHCK00favpTvgz7wkWPvsWkGoI7buDxyKpP28gz6NgbjfM7D2E7RWTntlF/sz6Oh7kQ5wC3lsoClKJsmsuwSiZmqQvv+WMPwpRX37V2MTNb4zY0dzouHxfHnKy+sSlUwfFmvxueToOin8Zg6Ndmt3EgnbHYlRn0RE9oBJrW0SkaFvIvSfqen9vUTQYIKcgf4ocvdEGNDg==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UYzLOy85i8ksr3gQDKRbA4+ll4/deoogWansLh9DBs8=; b=IIgqD9fT476/rVG0+0b5GwtzKZJg14rmlbrOBC/13zyPpd/yCPv+3dbZtKpXCEEQm8wu6fEbso+YuV1U8KmJHv+IZFUMrRYjf734nyBlsG10895HvCM58IZhbAnBDleZrd43yIVz3FIo4DK5iEGtpc/u7VhjQHozDcMLGCnIkiGElaKc9y+jyNHion0Li/JrejgPNsgsxZG070p00rkkpiBiH56s/Nc/VmNpWUotMLsPYl2oMOOAEzEvyGzKlQ6IRVUOwgYj4g6jDvZ4cVAYyU92bnoVPZdYgF3NAeMbjp2dwpAMqTd63BT16lrK6ZS27n4icp1trexaShKx40w90Q==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=AE0+CoKLyl04h3hplP/Nx516XiS2/DTy2GrG8JYMVtqjflGOkgJid6IXiQxi5fclBVzKseCuKOLcP3AdIgqk0h6ci79RWrpLN8IweMq5/QSR7WErD6yjwU1fDp5PmL4iuK0pml1QsHYjqKufBZPmQHXnPCaaYBmm2v5CShxyTN2NmchTpgyVIVVugtSqStH8NqMRyBZyFIc014Pb2VZ7/TluZQ+U22k7VpPdtLb4aKefYcj2mjovpo+vCOPPAzbYzNhlA83I1bHROAL4ayp62APbr77y4oHsOJ/13HGLPhU8xJtLoHf6C1PA+aY3kFA22Wxrl3OJ8ZMoEjRH7CHChw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hNUmm52Xg/4Fs/W0bhChQ659+bUYvn+sg+8kkZ/96OcRLJWvyHgUP/2HdkFZHru+kRy3ghGPcDzk1vIzYpoeCYhIJP98AEE/6G7lOAQOxH+4cL7h7AZTiGukZFFnhWw91itN/U9X70U+M19R3j8Bktvj5ZStcjmxNMlBGB1DT/EZ0JIIpWGS2i2GodrQgh1JbjETLCltgXiRVxQtBQUIDaC0ek7NCbSoUcfR5//syRyQs4e9DlgdrZKOktVEDr3GWAa8TKMAuyD9dnE1sNkH14FTbzDR55gthzjBdaZ16HAYHuEog8MaZG7OXw8sT+VTPAcvnFmd4W+evVcG+P0HRg==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Wed, 24 Aug 2022 14:42:32 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYs7NVSZ6RtK1DJkmDvOUuzqeVhq28SEyAgAG2wACAAAxAgIAAHKoA
- Thread-topic: [PATCH v2 7/7] xen/arm: introduce new xen,enhanced property value
Hi Julien,
> On 24 Aug 2022, at 1:59 pm, Julien Grall <julien@xxxxxxx> wrote:
>
>
>
> On 24/08/2022 13:15, Rahul Singh wrote:
>> Hi Julien,
>
> Hi Rahul,
>
>> Please let me know your view on this.
>> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
>> index bfe7bc6b36..a1e23eee59 100644
>> --- a/xen/arch/arm/domain_build.c
>> +++ b/xen/arch/arm/domain_build.c
>> @@ -3562,12 +3562,7 @@ static int __init construct_domU(struct domain *d,
>> if ( rc == -EILSEQ ||
>> rc == -ENODATA ||
>> (rc == 0 && !strcmp(dom0less_enhanced, “enabled”)) )
>> - {
>> - if ( hardware_domain )
>> kinfo.dom0less_enhanced = true;
>> - else
>> - panic(“Tried to use xen,enhanced without dom0\n”);
>> - }
>
> You can't use "xen,enhanced" without dom0. In fact, you will end up to
> dereference NULL in alloc_xenstore_evtchn(). That's because "xen,enhanced"
> means the domain will be able to use Xenstored.
>
> Now if you want to support your feature without a dom0. Then I think we want
> to introduce an option which would be the same as "xen,enhanced" but doesn't
> expose Xenstored.
If we modify the patch as below we can use the "xen,enhanced" for domUs without
dom0.
I tested the patch and its works fine. Do you see any issue with this approach?
diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
index cffd508af2..870846b742 100644
--- a/xen/arch/arm/domain_build.c
+++ b/xen/arch/arm/domain_build.c
@@ -3568,12 +3568,7 @@ static int __init construct_domU(struct domain *d,
if ( rc == -EILSEQ ||
rc == -ENODATA ||
(rc == 0 && !strcmp(dom0less_enhanced, "enabled")) )
- {
- if ( hardware_domain )
kinfo.dom0less_enhanced = true;
- else
- panic("Tried to use xen,enhanced without dom0\n");
- }
if ( vcpu_create(d, 0) == NULL )
return -ENOMEM;
@@ -3613,9 +3608,8 @@ static int __init construct_domU(struct domain *d,
if ( rc < 0 )
return rc;
- if ( kinfo.dom0less_enhanced )
+ if ( kinfo.dom0less_enhanced && hardware_domain )
{
- ASSERT(hardware_domain);
rc = alloc_xenstore_evtchn(d);
if ( rc < 0 )
return rc;
Regards,
Rahul
|
