[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] Config.mk: correct PIE-related option(s) in EMBEDDED_EXTRA_CFLAGS


  • To: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Thu, 25 Aug 2022 09:17:17 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jKQFD5eJeOjQplpILH0QuBIfBksxrwb519Rg1xYssig=; b=M721cdQPPI7Jn2kMUd3FL5UVJ5hvwb5ypowhFpdjGS5CtAEveuaYIxwooZ2MISBg4EHGekJR8cmav4ZIConufFtb/s+eMTdz0cEbwj//dgOF0WTddGtMg6BBL1bXikEgYuOc3jbimU2Ll+oOwicDixmAZvY9kHGUAzl46PQjnfK389mkgpdbgJtLV6+q5smYQ1XIxpdPNrRQ11AooVu3YYWe+gFUbqo25silvbPQCucETPldC6pm5CEszP7WZ1dK9H4/TNlW8/jwuxsSqa866J7JyGKtHFXZ/uR5UL483bFhj7e2J/4SGbyqKTrgmv4gdd+TYtuz74ai6Rwe6OpfQg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YF2uT2UreNVnEoznTOiUgr3rESFlcsOCJczzORX3Hz2hv/nF45UAnumLQlTqly0gxUTYAPrOUYZ8+hZodRJ/DEsBFmG3E/58HMLCG5PNExleSK8JUd14E9m8AeTOyE30nH4o+QVEHFIX4hrFIos5KE7FsqoeD/FLTug/ALo/M/eDnUWKqQ9r28ajCScS25bOqM/FjWzWpDW0ox1KtQrjOJk87FylxLJ89dzE/oDgURii/39x6UycRSzx/zRgvtLwXl1iZtqMwm9yuVI//XuYd9c7ynO6WN0vd/+zVNWvtZRq4w7RpI40Hiduuezld9Kc8gvOwtr20DUlT704talv5A==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>
  • Delivery-date: Thu, 25 Aug 2022 07:17:40 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

I haven't been able to find evidence of "-nopie" ever having been a
supported compiler option. The correct spelling is "-no-pie".
Furthermore like "-pie" this is an option which is solely passed to the
linker. The compiler only recognizes "-fpie" / "-fPIE" / "-fno-pie", and
it doesn't infer these options from "-pie" / "-no-pie".

Add the compiler recognized form, but for the possible case of the
variable also being used somewhere for linking keep the linker option as
well (with corrected spelling).

Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

--- unstable.orig/Config.mk     2022-04-07 12:23:27.000000000 +0200
+++ unstable/Config.mk  2022-08-25 08:58:00.044287451 +0200
@@ -188,7 +188,7 @@ endif
 APPEND_LDFLAGS += $(foreach i, $(APPEND_LIB), -L$(i))
 APPEND_CFLAGS += $(foreach i, $(APPEND_INCLUDES), -I$(i))
 
-EMBEDDED_EXTRA_CFLAGS := -nopie -fno-stack-protector -fno-stack-protector-all
+EMBEDDED_EXTRA_CFLAGS := -fno-pie -no-pie -fno-stack-protector 
-fno-stack-protector-all
 EMBEDDED_EXTRA_CFLAGS += -fno-exceptions -fno-asynchronous-unwind-tables
 
 XEN_EXTFILES_URL ?= http://xenbits.xen.org/xen-extfiles



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.