Re: [PATCH v2 02/10] x86/mtrr: remove unused cyrix_set_all() function

[Juergen Gross <jgross@xxxxxxxx>]

On 25.08.22 13:42, Borislav Petkov wrote:
> On Thu, Aug 25, 2022 at 12:41:05PM +0200, Juergen Gross wrote:
> > Maybe the alternative reasoning is much faster to understand: if the
> > Cyrix set_all() could be called, the AMD and Centaur ones would be callable,
> > too.
> Right.
>
> > Those being called would result in a NULL deref, so why should we keep
> > the Cyrix one?
> I know you're eager to remove dead code - I'd love that too. But before
> we do that, we need to find out whether some Cyrix hw out there would
> not need this.
Back to reasoning #1. Only the use_intel() case calls the code in question
with reg == ~0. And use_intel() is clearly not Cyrix.


Juergen

Attachment: OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature
Description: OpenPGP digital signature