[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Make XEN_FW_EFI_MEM_INFO easier to use


  • To: Demi Marie Obenour <demi@xxxxxxxxxxxxxxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Fri, 26 Aug 2022 09:18:50 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fERJhCbW7Qhz8g7gxHu9+eACuNs4lGe0G2DrDRCF94c=; b=bvzQE0veLxgWzs/lN9WpnczQKAEzWzC+HRjxBVGES5fKY6PWayUtPE7cJESmwN/tRsdFwotIR1ssZzn1XI2pZmbYSFVDK6+XS8a9d6IRSmmblzqalpau6XY3pl/UDwdM+Ibcxa0itseBFyzVwLuf696JH6fYVnAo3jSiOMQxzdktI8e7i4+deP/ND2PFpKV/BoUYMnkbW6d7uVCWFw34KYlHJNlyfpLrVHDXXZtVidBqibndpxbkp96FSxMW4ITW44ORfApbPdvg6IMvYUW1evzcklqEVu+9C14SgZ07PiHDzl2a7BrUtkRXSdx2oKAQdoa1B6ec2h0Pd4MWEJklAw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Y6R2EsmKOB6pWg9ht8BhV8C8nZR26S65VVvlZZeJnd23lmv2rBKajkDaRXESd8QL9lyZfWp0osgYfcpZSCRTcRB59HB1z8i7PgX0nLxMJBddyhh5j3XBnLa5GA6mMUL11eq/jG5QUOuemGutb7X4IBMQDqSvZpcwD+oxF16AirkAkdMMcpVA1vaWDU8zzse+Jt9KNaPtYk8+4NEG3MjnHhMSfduqJI4agWfizqendB0TBeUqZPhPFbu6bE45UMnSCxRjhIzoCk3fSKUdLTIJiWomtxXZiRooOzx7PLAbXw/jN+rlCtSB5UWZhgrG7eOgvyzUBrjklb4HrQsoUmEX4w==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>, Xen developer discussion <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Fri, 26 Aug 2022 07:18:57 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 25.08.2022 22:36, Demi Marie Obenour wrote:
> On Thu, Aug 25, 2022 at 09:59:56AM +0200, Jan Beulich wrote:
>> On 24.08.2022 23:04, Demi Marie Obenour wrote:
>>> Fix both of these problems by unconditionally setting the memory region
>>> size
>>
>> If you were to report a larger ending address, why would you not also
>> report a smaller starting address?
>>
>> But before you go that route - I don't think we can change the API
>> now that it has been in use this way for many years. If a "give me
>> the full enclosing range" variant is wanted, it will need to be
>> fully separate.
> 
> Does anyone use this API?

The XenoLinux forward port of ours did, and upstream Linux still wrongly
doesn't. The two functions efi_mem_type() and efi_mem_attributes() still
wrongly fail there when running on Xen.

But how does this matter? Even if we were unaware of any users of the API,
we can't know there are none.

As an aside: Something's odd with your reply. When I opened the window to
write this reply, Marek and the list were put into To: (instead of Cc:)
and you were dropped altogether. I can only guess that this is what
Thunderbird made of the Mail-Followup-To: tag which your mail has.

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.