[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 9/9] drivers/char: fix handling cable re-plug in XHCI console driver
- To: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Fri, 26 Aug 2022 16:50:32 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9y+9qvpLZ+uq+TokBkXXxZhPz9jvRbgrRkHbxowYDoY=; b=b0tF4BUMl6dofdn1H/F5zbNHBxTs0A415+CCmVhx1vsG3KMl1V/n8+JJeyy2PFy9PSEjPL2SRkMqIKJCrhH6TDx0xvYMH4aNbJ04KmBbV7vh/24k1HQcMzVU6ycHjCxXIQeeNcrJh5rJl8kgLba/TnzoWciHU94hksmyHRuctrQPVqTVnEgVk1cNU2SpEIV2PRg0PDjQFC7s+r0G0nPK2SmfCRUut3bk4pKoQlM2Wu+8vCM7P2+L6RyIJi8I7firo7QbpNoo59W1Q1AqqYn8iXaOcOaphTonD/eJ2oVmFQxY+WzV2Ht7osiz2w2RsVv69JBpTpywD14N0K/qxWXwlA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BNBtdj5ZHWXSf0sepLm1glhkGjgrnxgTFsS5pmi5qwB28jQvBh3wDcK6buhdXx1L3z0vvBam+hLywvU6e4nuTfKWSzv75N8mhSpIeqkLCYdkM5d9bo9I+qpNYuPtA7bUuSeCcxU/5L5boquRg/LWCc+U6uZuTAMqp+Qh6wafreO4XH/VhSRv3RD3DFMRvCCCRo65apiBxjNfxP2pRAq8OERj27rvNMAKdTTNBIxOGRiRAEZyanfdJpbqFfuI2mtc/Kn+WOLr3lbsRyvlbsk12jX036hJ5NgF4K+nqrWjdzOPx2ySNplMWiYW/qil9bcv/1WLTh4415J3h+QhHi+B9w==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Fri, 26 Aug 2022 14:50:39 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 22.08.2022 17:27, Marek Marczykowski-Górecki wrote:
> @@ -1023,6 +1032,8 @@ static bool dbc_ensure_running(struct dbc *dbc)
> writel(ctrl | (1U << DBC_CTRL_DRC), ®->ctrl);
> writel(readl(®->portsc) | (1U << DBC_PSC_PED), ®->portsc);
> wmb();
> + dbc_ring_doorbell(dbc, dbc->dbc_iring.db);
> + dbc_ring_doorbell(dbc, dbc->dbc_oring.db);
> }
You retain the wmb() here, but ...
> @@ -1066,8 +1073,7 @@ static void dbc_flush(struct dbc *dbc, struct
> xhci_trb_ring *trb,
> }
> }
>
> - wmb();
> - writel(db, ®->db);
> + dbc_ring_doorbell(dbc, trb->db);
> }
... you drop it here. Why the difference?
Jan
|
