[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v3 6/6] xen: introduce a Kconfig option to configure NUMA nodes number
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Wei Chen <Wei.Chen@xxxxxxx>
- Date: Mon, 29 Aug 2022 11:00:49 +0000
- Accept-language: en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6UwQi4O/S8DZ6YGLHN3qRr1q7Iij+fZKO3tGV2Y8x6g=; b=h+2RkjdfjfiTzQzlUxgbnSmbGAIoTXmvrv5sAETgl8MLOEqbNAFKcSb7jNNt9Ls8mdcKp2BUV4nUYELhRYyuemjg4QhtPxuenaazyMfldCtJDMR9IqtX6k5pgddgI3BfYY/2Zm8QLQau+5zUCbGAWx+UTLAM/EpCVkkZ0I+jL4xA2e08ymU0V++/i1aLH/sk2EpysEiLrVYU+d9IFKW3rymt+APDqT/IR/Hn9aO2ZcKeXMAz/AweLRHOIoukKW65ZhZdn4ReMdlbJILOHeR72qgh8/Zhy9P5cgRVXeEMVlhcfpr+49IXxggNg8jOgEb4JVUr6iyaQ2s3Bx9JzRndzw==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6UwQi4O/S8DZ6YGLHN3qRr1q7Iij+fZKO3tGV2Y8x6g=; b=DFQPbV1X/7TuaXq9eg39q6jOqbv/ynVE3Z5WYfbpiJ6fSDRlFnwfYO16M0W2s7GQJY8DfpsMzhlGZonQlQPMzDI9MbXYrNOisNma3pKv2/JGStOvkveNNI62vdldn5a1YrurPYYMgZe6mW7trxDucUR++fOruE8quVlUv49acYQ3MEJge/dMuy5Io0atooT2487j7r8x/LX8P88PNYbn6dxlfxmQXGaCgW3c8qW8kh0E3IhaqPMehAv1jqXT9BzOSsbNgMIU8stqm9SgvZ6pjjbb/OL86AQ9PHQnbjxvPcuVShLma2oMbLl7V1FydyeTMNfmD7qqp70Y/NHL1XFV/w==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=SlxCmYUJdj3McKug0Ty1C8cXL/t6Lf5TkwAFyy3PgV94fqPmmI81bX3JUERkVlmQzPBQ977YrK9s76LdTx/oLthyO2Cj5CbHcOZRgLN15HwdCsjvaM200FQqYk1MFVQjv1u9ul6a8BaR0Ub4owmby6Z88V7CKiBPNs5gS5miT6azUEq+tgVnKJiX45zW+pV5+rcJPVVqafbFrwlzJbR1ePMGl1zhS/oM2kdLakfQW6qjLqhHXc2GEA04jVm0UV97VeQbJP0Yxq6kN7FQn4UxAAOI7JBZP6Ua/xH9gu92WdCyD3KUSYJKExSIRC7+Oobq0oAMyIAY2D2hJmvVtBx40Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RUiF5RRKdJIJm/uidyNr/+597hiG7qrMhwjVQ1Xnag5AAH6g8dJXVT380wO+poFk6e2vt/hcGHvq9u8bC29Zck/RNS3JARi7ljl285pKtkUN/kjv2b3slvloZguHnku4uJpAsXtfd3Z8J9M63C14zb2Px9pcZvXMFDM9KlkZBPgwNH86GhUytXcsgNxNhAc5XVT1R2tAARAF3VsokY0sxpGo4hF8wJHBnEZ3OKTJJe6IkHE8vGB8BJsxkZlnIRTQYDJ0w/db1V514fG4qj4gBxrolUv2X0pRrtCrLUvQF1dkzlaopvHz9+gD6IMCuqRME5rRPDZsI9UgkDyvFr8hpQ==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: nd <nd@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Mon, 29 Aug 2022 11:01:22 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYtdM4QhyibxNRjEO8vG7DwdZxva2/myoAgAYjkjA=
- Thread-topic: [PATCH v3 6/6] xen: introduce a Kconfig option to configure NUMA nodes number
Hi Jan,
> -----Original Message-----
> From: Jan Beulich <jbeulich@xxxxxxxx>
> Sent: 2022年8月25日 21:06
> To: Wei Chen <Wei.Chen@xxxxxxx>
> Cc: nd <nd@xxxxxxx>; Andrew Cooper <andrew.cooper3@xxxxxxxxxx>; George
> Dunlap <george.dunlap@xxxxxxxxxx>; Julien Grall <julien@xxxxxxx>; Stefano
> Stabellini <sstabellini@xxxxxxxxxx>; Wei Liu <wl@xxxxxxx>; Roger Pau Monné
> <roger.pau@xxxxxxxxxx>; xen-devel@xxxxxxxxxxxxxxxxxxxx
> Subject: Re: [PATCH v3 6/6] xen: introduce a Kconfig option to configure
> NUMA nodes number
>
> On 22.08.2022 04:58, Wei Chen wrote:
> > Current NUMA nodes number is a hardcode configuration. This
> > configuration is difficult for an administrator to change
> > unless changing the code.
> >
> > So in this patch, we introduce this new Kconfig option for
> > administrators to change NUMA nodes number conveniently.
> > Also considering that not all architectures support NUMA,
> > this Kconfig option only can be visible on NUMA enabled
> > architectures. Non-NUMA supported architectures can still
> > use 1 as MAX_NUMNODES.
>
> Especially the uses of "NUMA nodes number" make this read somewhat
> odd. If I was to re-write all of this, it would become something
> like:
>
> Currently the maximum number of NUMA nodes is a hardcoded value.
> This provides little flexibility unless changing the code.
>
> Introduce a new Kconfig option to change the maximum number of
> NUMA nodes conveniently. Also considering that not all
> architectures support NUMA, this Kconfig option is only visible
> on NUMA enabled architectures. Architectures not supporting NUMA
> still use 1 for MAX_NUMNODES.
>
Thanks, I will update the commit log.
> > As NODES_SHIFT is currently unused, we're taking this
> > opportunity to remove it.
> >
> > Signed-off-by: Wei Chen <wei.chen@xxxxxxx>
>
> Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
>
Thanks!
> Note that there's an alternative with less #ifdef-ary:
>
> config NR_NUMA_NODES
> int "Maximum number of NUMA nodes supported" if NUMA
> range 2 64 if NUMA
> default "1" if !NUMA
> default "64"
>
> But I can see reasons why one might deem it better for there to
> not be any CONFIG_NR_NUMA_NODES in the resulting .config when
> !NUMA.
>
Is it because there are many places where alternative patches need to
be added for #ifndef CONFIG_NR_NUMA_NODES?
Cheers,
Wei Chen
> Jan
|
