[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 2/7] xen/evtchn: Add an helper to reserve/allocate a port



Hi Rahul,

On 01/09/2022 10:13, Rahul Singh wrote:
In a follow-up patch we will want to either reserve or allocate a port
for various event channel helpers.

A new wrapper is introduced to either reserve a given port or allocate
a fresh one if zero.

Take the opportunity to replace the open-coded version in
evtchn_bind_virq().

Signed-off-by: Stanislav Kinsburskii <staskins@xxxxxxxxxx>

Usually, the "From:" match the first signed-off-by. This is not the case here. Can you clarify whether you effectively rewrite the patch or simply took it?

If the former, then I would suggest to write: "Based on ..."
If the latter, then please update the "From:".

Cheers,

--
Julien Grall



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.