[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 01/10] xen/arm: smmuv3: Fix l1 stream table size in the error message


  • To: Julien Grall <julien@xxxxxxx>
  • From: Rahul Singh <Rahul.Singh@xxxxxxx>
  • Date: Thu, 1 Sep 2022 10:27:06 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
  • Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xpEOhq++szxWDXF4xQFsnoWVpbjQf7cyXJKT9fgBhVQ=; b=IxabaAGecWxmbzwsfdzVmVwWqFuqqle1zDZQ9XcF80V6r+hhpHsLY4XcevX0XGnwxQjwacVs9UsFb/elvzdzYry6odaBeqKaMSsBvd/FqmMVQ9p9tgIAu26zE+Yj3d0Oc+4J/nQO2PK8WRjJm1Z0iNGjP4PxreF+4QomX/vUXzWe+ZvFI3/D7Jn4Yal/91Q2Z5L0DSPJW7UNxwu3nGaLU5OG1nBsXYEWaEyC9vcnJFldgcR10bjLxnuEU6JkRdbzZM+382HiA4NQ9KIJwJE1C1oJ/81jzWwmDpVEHFTZRnK2Df5Fs1sp4FXf18T0y3JFE6nrmiH4o7pqjSCpt1Lfpg==
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xpEOhq++szxWDXF4xQFsnoWVpbjQf7cyXJKT9fgBhVQ=; b=fvNqEjtsG+BP2dpOiOH2IECRVqukjThcqo6KeowRL21TAcrgm0CbgqXeRRux5R7ZZ53FX2E1hhaNtY7ZmgbGNNNgYXvQvvZ8fH2y7tUGhlGIwJPyMyQX2YjFpT+Ldk+gL+SmAfpdcq0pBw+W98UaFucVON8e9VAO9fBSpB1SBJkXREDy5GGMVXK8F/cVUTt0+ibw1MmTFydzQEen8fMp3KW+JHf+VXzy38Y6r9rdorASGT+rSFzLFOKSIBMBZl2DCBkdYdN88zrHZHHmWn4z9sqSIYE1kH3ez4mz7f8PQyyjMcYc4457GCoG1ASEVhzGsvn74gQ+KhecsgxvCJqWlA==
  • Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=Wl5MqOKiWJ7n9Dd+hM4q36FGvJYeG8xEQJNcXIgCbB7Ez+wf51wuYb99njd51C/YMBrJTYD0rors8BIg+Am3uWoBois9RxjqhwgOozKPpxxPW78bU4V2th0qWMl9F8VfArVwpJID+D9osc3ga0/Bjp4gJtB5id57jqk3Q28yslO/HDfc0mXqhCgaBUtOiYD9ix02lC2kSwM2WE2JUjPD4g2RcH7teFnyldGMcd65ELeqNAbjY1ShrWJULiAxFyUleEq/LQPOJKFi6cEmTLyh4r476wZMLYG40v+9wln8TbSl77A3Z/CjBPhoPQ5w9qSewBxvC6PnjNUZzpYD1VuJbw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FANSJOYz9M0HixpINi+kgFR+xtYep1m70mnhdtUgDCSRRGKFYYN6fKb/T0jlfnX2M5Thz5q2bHLNK/+rO+SJN8VI6E/MWeeHYaTyWYqgAtI1PDs8z7n4vYEYF+VbzJAT2Pyn/o2sybyvriqGzOe/ujHF9uLe/aJK1dTaqUsS3fqeH0TjL+lGyifsBn9jAIgvjX+xIlJIV9Em/Wgq00Ly//8Zrj3PQUxVREfKSR64Pb2ptcxXrrC/xorcAbkLJFbEhX1iQ+2iTklfOq1hAUbdNYDP9HoF2AP119iE1ZlJHN1H2OckPkx2jgde49jGKi1UH/LNVZyixHIAZxh5Z7v3zw==
  • Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
  • Delivery-date: Thu, 01 Sep 2022 10:27:31 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true
  • Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Thread-index: AQHYt8DukfAZB3LGK0y8Qp1jO3Tea62+JIcAgAxGuwA=
  • Thread-topic: [PATCH 01/10] xen/arm: smmuv3: Fix l1 stream table size in the error message

Hi Julien,

> On 24 Aug 2022, at 3:58 pm, Julien Grall <julien@xxxxxxx> wrote:
> 
> Hi Rahul,
> 
> On 24/08/2022 14:53, Rahul Singh wrote:
>> Backport Linux commit dc898eb84b25c39ea46f28c48a169bdbd0e2c7e0
>> iommu/arm-smmu-v3: Fix l1 stream table size in the error message
> 
> We have a tag for this (see Origin). If you use it, then…
Ok.
> 
>> Original commit message:
> 
> You don't need to add "original commit message" here and the content is 
> exactly the same.
Ok.
> 
>>     iommu/arm-smmu-v3: Fix l1 stream table size in the error message
>>     The actual size of level-1 stream table is l1size. This looks like
>>     an oversight on commit d2e88e7c081ef ("iommu/arm-smmu: Fix LOG2SIZE
>>     setting for 2-level stream tables") which forgot to update the @size
>>     in error message as well.
>>     As memory allocation failure is already bad enough, nothing worse
>>     would happen. But let's be careful.
>>     Signed-off-by: Zenghui Yu <yuzenghui@xxxxxxxxxx>
> 
> AFAICT, you didn't make any change to this patch. So the "From:" should still 
> be from Zenghui Yu. For an example how to do backport, see
> 9c432b876bf518866d431bda73f2be1250f688eb "x86/mwait-idle: add SPR support".

Ok.
> 
> Also, it would be good to clarify whether they are clean backport and 
> required some changes (other than context changes). I assume they are clean 
> backports?
Yes all patches are clean back port.
 
Here is the commit msg please have a look once. Once you confirmed I will 
modify other patches and send it for review.

Author: Zenghui Yu <yuzenghui@xxxxxxxxxx>
Date:   Mon Aug 22 16:19:01 2022 +0100

    xen/arm: smmuv3: Fix l1 stream table size in the error message
    
    Backport Linux commit dc898eb84b25. This is the clean backport without
    any changes.
    
    The actual size of level-1 stream table is l1size. This looks like an
    oversight on commit d2e88e7c081ef ("iommu/arm-smmu: Fix LOG2SIZE setting
    for 2-level stream tables") which forgot to update the @size in error
    message as well.
    
    As memory allocation failure is already bad enough, nothing worse would
    happen. But let's be careful.
    
    Signed-off-by: Zenghui Yu <yuzenghui@xxxxxxxxxx>
    Link: https://lore.kernel.org/r/20200826141758.341-1-yuzenghui@xxxxxxxxxx
    Signed-off-by: Will Deacon <will@xxxxxxxxxx>
    Origin: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 
dc898eb84b25
    Signed-off-by: Rahul Singh <rahul.singh@xxxxxxx>

diff --git a/xen/drivers/passthrough/arm/smmu-v3.c 
b/xen/drivers/passthrough/arm/smmu-v3.c
index f2562acc38..340609264d 100644
--- a/xen/drivers/passthrough/arm/smmu-v3.c
+++ b/xen/drivers/passthrough/arm/smmu-v3.c
@@ -2348,7 +2348,7 @@ static int arm_smmu_init_strtab_2lvl(struct 
arm_smmu_device *smmu)
        if (!strtab) {
                dev_err(smmu->dev,
                        "failed to allocate l1 stream table (%u bytes)\n",
-                       size);
+                       l1size);
                return -ENOMEM;
        }
        cfg->strtab = strtab;


Regards,
Rahul


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.