[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/2] docs, xen/arm: Introduce reserved heap memory



Hi Henry,

On 02/09/2022 02:28, Henry Wang wrote:
This is technically a change in behavior for Xen (we would panic rather
than continue). I am happy with the proposal. However, this doesn't seem
to be explained in the commit message.

That said, I think this should be split in a separate patch along with
the ones below (including the prototype changes).

According to Michal's comment, I've removed the return type and function
prototype change in my local v2. So this patch itself is fine. My question now
would be, do maintainers think this change of behavior with processing the
chosen node be helpful?

Yes. I think it is saner to stop booting early rather than seen random behavior afterwards.

Do we prefer an instant panic or current behavior?

I think we should leave that up to the caller. Today, this is a panic() but we may decide differently in the future.

Cheers,

--
Julien Grall



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.