[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 3/3] xen/sched: fix cpu hotplug
- To: Juergen Gross <jgross@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- Date: Mon, 5 Sep 2022 10:36:30 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uv2wUdVfPvpiScb5nREle6bDlPbjffGNPQ4dXabpOvM=; b=l6SX0L7IckAozV+8FBIfZWP+9Uwt+o3J8W4dPxBiB8Dm3KXIO5pb3mLaWUNdqlBkxT2WmZ8I/988m5IkfYcpKCteDwo489Pq39vYQVR8LUmNy2qsdGykD/h6SEixdPBZDtih/yQGG+7nm5jf0xGYiuoHKRczGdCLA5cfFOKkqHj9uVe8XsPok3Wo4AC6MbzYag59MrWOL7Yp6xW8U7IgBnFE49+KexgabnKI3pq8Cj5dm1fifehLqxTL25YwiSZ3jPGYZxT3KPr31L9iiVkJf/zVc4VGv+9zXAaHQl9DWcvP8o+A3Az0N1tVgbXBKECldooTitN67mDAUdwtE2u9pQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nv3JyM3aOAIV21PpRFuwt+IY4qcsH/p6n+dATNwL060tVT6X2N8iV1dZPikSqPP0NAlubVrIc5i2ev/to+/jGRRAsgdkGLHVxS+jDzbOH4ri3XZu6EesZUrDf/1QWupHRfl7tuXW6sfnXCXo2A5EDby5N/N/2noGHq45SST/tkR4ge+bBvxzmceGKIog2rSyjvMEK+PYTEFKw2+ZxWqR8vF2nH9h0bKKmbVejmSpxH2NrbJ4YlXQ34TG5Bpw45aJ98+/S8Nk+QfbYCmDe3qMsLO3XrpiafmZ2GHMepUcISsNcO6HJh9fjiHbuM0u+6MUQoz/5626OvYIIpspd4WK3w==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: "Henry.Wang@xxxxxxx" <Henry.Wang@xxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxx>, Dario Faggioli <dfaggioli@xxxxxxxx>, Gao Ruifeng <ruifeng.gao@xxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>
- Delivery-date: Mon, 05 Sep 2022 10:36:46 +0000
- Ironport-data: A9a23:vv31ha144Yx2+yfa9vbD5TZwkn2cJEfYwER7XKvMYLTBsI5bp2MOz TcWWDqFaPyJM2T3LdsiOYW2/UJUsZeEytYxG1Q+pC1hF35El5HIVI+TRqvS04J+DSFhoGZPt Zh2hgzodZhsJpPkjk7xdOKn9RGQ7InQLpLkEunIJyttcgFtTSYlmHpLlvUwx4VlmrBVOSvU0 T/Ji5CZaQTNNwJcaDpOsfrS8E435ZwehRtD1rAATaET1LPhvyF94KI3fcmZM3b+S49IKe+2L 86rIGaRpz6xE78FU7tJo56jGqE4aue60Tum0xK6b5OKkBlazhHe545gXBYqheW7vB3S9zx54 I0lWZVd0m7FNIWU8AgWe0Ew/y2TocSqUVIISJSymZX78qHIT5fj6612Dl0WepEAxsRUIT5/8 vw9ECAjaSnW0opawJrjIgVtruIKCZCyeak56jRnxzyfCus6S5feRamM/cVfwDo7msFJG7DZe tYdbj1sKh/HZnWjOH9OUM54wLju2ym5KmMIwL6WjfNfD2z75Qp9yrXydvHSfcSHX559lUeEv GPWuW/+B3n2MfTAmGbYoyj814cjmwvRc7k+L6Cd3MIwhR6B6mk5AUcVeguC9KzRZkmWHog3x 1Yv0ight68p72SwU8LwGRa/pRasrhMaHtZdDeA+wAWM0bbPpRaUAHAeSTxMY8Bgs9U5LRQK2 1mTjpXWDDpgmLSPTDSW8bL8hT+8MCcaLGgGZAcfUBAIpdLkpekblA/OQNtlH+i6h9rdGDfsz jTMpy87750Rh8MW06Sw/Xjcnimh4JPOS2YICh7/W2uk6kZzYt6jbonxsFzDt68efMCeU0WLu 2UCl46G9ucSAJqRlSuLBuIQALWu4PXDOzrZ6bJyI6QcG/2W0ybLVehtDPtWfy+F7u5slefVX XLu
- Ironport-hdrordr: A9a23:2UXgzKgSk0lYXCRw86TnVnuiTXBQXiAji2hC6mlwRA09TyX5ra 2TdTogtSMc6QxhPE3I/OrrBEDuexzhHPJOj7X5Xo3SOTUO2lHYT72KhLGKq1Hd8kXFndK1vp 0QEZSWZueQMbB75/yKnTVREbwbsaW6GHbDv5ag859vJzsaFZ2J921Ce2Gm+tUdfng8OXI+fq DsgPZvln6bVlk8SN+0PXUBV/irnaywqHq3CSR2fiLO8WO1/EuV1II=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHYwPUrmwAE8kE4eUqry59vQa94Aq3QpM0A
- Thread-topic: [PATCH v4 3/3] xen/sched: fix cpu hotplug
On 05/09/2022 08:00, Juergen Gross wrote:
> @@ -3312,17 +3325,18 @@ void free_cpu_rm_data(struct cpu_rm_data *mem,
> unsigned int cpu)
> * The cpu is already marked as "free" and not valid any longer for its
> * cpupool.
> */
> -int schedule_cpu_rm(unsigned int cpu)
> +int schedule_cpu_rm(unsigned int cpu, struct cpu_rm_data *data)
> {
> struct sched_resource *sr;
> - struct cpu_rm_data *data;
> struct sched_unit *unit;
> spinlock_t *old_lock;
> unsigned long flags;
> int idx = 0;
> unsigned int cpu_iter;
> + bool freemem = !data;
v4 is much clearer to follow than v3. One final suggestion, having read
through the series again; rename this to free_data so as to relate more
closely to what it does.
I can fix on commit if you're happy.
Everything A/T-by Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
~Andrew
|
