[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 3/9] xen/arm: add a primitive FF-A mediator
- To: Jens Wiklander <jens.wiklander@xxxxxxxxxx>
- From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- Date: Tue, 6 Sep 2022 10:44:12 +0100
- Authentication-results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
- Cc: <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, <Bertrand.Marquis@xxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Tue, 06 Sep 2022 09:44:24 +0000
- Ironport-data: A9a23:zcNVl6uI5d/yLsUlTE1iRdepFufnVI1eMUV32f8akzHdYApBsoF/q tZmKTuPO/bZazb8fdtyaNu0/ENSsZSBx9JkTgI+qi8zHnlB+JbJXdiXEBz9bniYRiHhoOOLz Cm8hv3odp1coqr0/0/1WlTZhSAgk/vOHtIQMcacUghpXwhoVSw9vhxqnu89k+ZAjMOwRgiAo rsemeWGULOe82MyYzl8B56r8ks15qyj4G1A5zTSWNgQ1LPgvyhNZH4gDfnZw0vQGuF8AuO8T uDf+7C1lkuxE8AFU47Nfh7TKyXmc5aKVeS8oiM+t5uK23CukhcawKcjXMfwXG8M49m/c3Kd/ /0W3XC4YV9B0qQhA43xWTEAe811FfUuFLMqvRFTGCFcpqHLWyKE/hlgMK05Fc49wPRXHkdHz LsVJylVTzqmq9K2zr3uH4GAhux7RCXqFIYWu3UmxjDFF/c2B5vERs0m5/cBgm123JoXW6+DO YxJMlKDbzyZC/FLEl4RFJI5mvbunnTleidUgFmUubA28y7YywkZPL3FYICOJ4XSFJg9ckCw/ E3/+XTpGDomKtW62SWhrlyBoMHvpHauMG4VPOLhraM76LGJ/UQ5BQcKT1K9rb+cg1SnRtNEA 0UO/2wlqq1a3HKsSt7xThipukmutxQXW8dTO+Ai4QTLwa3Riy6GAkAUQzgHb8Yp3Oc0SiYtz UShhM7yCHpkt7j9YWKQ8PKYoC2/PQARLHQefmkUQA0d+d7hrYovyBXVQb5LEqOzlZvqGDL0y jaGoTIWg7QVhNQMkaKh8jjvgS+op5XPZh444EPQRG3NxhhieIevaois6F7axfVNNoCUSh+Gp ndspiSFxLlQV9fXznXLGbhTWuHyjxqYDNHCqR1KJYsB6BKkwjmucpkIwRtbCHdpPMlRLFcFf 3TvVRNtCI57ZSX0N/cnONPvVazG3oC7S427C6m8gs5mJ8EoKVTZpHwGiVu4hTiFraQ6rU0o1 X53m+6IBG1SN6loxSHeqww1ge5ynXBWKY8+qPnGI/WbPVm2PiT9pU8tagfmUwzAxPrsTP/p2 9heLdCW7B5UTffzZCLamaZKcw5QcSBhVM+t8ZMOHgJmHuaBMDh4Y8I9PJt7I9A190irvrygE o6Btr9wlwOk2CyvxfSiYXF/crL/NatCQYYAFXV1ZT6VN40LO9nHAFE3K8RqJtHKNYVLkZZJc hXyU5/eUqgXGmubpG51gFuUhNUKSSlHTDmmZ0KNCAXTtbY6L+AV0rcIpjfSyRQ=
- Ironport-hdrordr: A9a23:+CPVr6lXUAtNCgqPKQXSXCcNbU/pDfIs3DAbv31ZSRFFG/Fxl6 iV8sjz8SWE7Ar5OUtQ/OxoV5PsfZqxz/JICMwqTNCftWrdyQmVxeNZjbcKqgeIc0aVygce79 YCT0EXMqyXMbEQt6fHCWeDfOod/A==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Hi Jens,
On Thu, Aug 18, 2022 at 12:55:55PM +0200, Jens Wiklander wrote:
> diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c
> index eef1de093914..a985609861c7 100644
> --- a/tools/libs/light/libxl_arm.c
> +++ b/tools/libs/light/libxl_arm.c
> @@ -101,6 +101,9 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc,
> return ERROR_FAIL;
> }
>
> + config->arch.ffa_enabled =
> + libxl_defbool_val(d_config->b_info.arch_arm.ffa_enabled);
There seems to be missing a call to libxl_defbool_setdefault() before
this. This could result in an abort when creating a guest for Arm.
A call to libxl_defbool_setdefault() probably want to be done in
libxl__arch_domain_build_info_setdefault() in libxl_arm.c.
> return 0;
> }
>
> diff --git a/tools/xl/xl_parse.c b/tools/xl/xl_parse.c
> index b98c0de378b6..e0e99ed8d2b1 100644
> --- a/tools/xl/xl_parse.c
> +++ b/tools/xl/xl_parse.c
> @@ -2746,6 +2746,9 @@ skip_usbdev:
> exit(-ERROR_FAIL);
> }
> }
> + libxl_defbool_setdefault(&b_info->arch_arm.ffa_enabled, false);
This should be done in libxl (as pointed out above) instead of xl.
> + xlu_cfg_get_defbool(config, "ffa_enabled",
> + &b_info->arch_arm.ffa_enabled, 0);
>
> parse_vkb_list(config, d_config);
>
Thanks,
--
Anthony PERARD
|
