[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH V5 5/6] libxl: Allocate MMIO params for I2c device and update DT


  • To: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
  • From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
  • Date: Tue, 6 Sep 2022 17:38:13 +0100
  • Authentication-results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
  • Cc: <xen-devel@xxxxxxxxxxxxx>, Vincent Guittot <vincent.guittot@xxxxxxxxxx>, <stratos-dev@xxxxxxxxxxxxxxxxxxx>, Alex Bennée <alex.bennee@xxxxxxxxxx>, Stefano Stabellini <stefano.stabellini@xxxxxxxxxx>, Mathieu Poirier <mathieu.poirier@xxxxxxxxxx>, Mike Holmes <mike.holmes@xxxxxxxxxx>, Oleksandr Tyshchenko <olekstysh@xxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>
  • Delivery-date: Tue, 06 Sep 2022 21:37:08 +0000
  • Ironport-data: A9a23:idd06q1CaEITcVb/H/bDix16xf2zMnBdZdB3s9h9DyJ0z/FvzIkanZKB8/OS+U9bHOpMeNiCB5Vf1yJ3P5qbDhymA2h6DsXYnqGX3gqNxGmMvFsvv8UKhB9hoMGJO8APlKYaKLNxYXbSBPIf0IGhEUciULn4FBPkg/SdoH5a8pQPEdkQex/F1R4dNjdkyjJwG6/DJ996bmm8BfJWhkFnj5KGN6TZntUcoQpQpd1jqQjEwXVm3knq6KMUnKyBTwXQgb1fjga6AnBURFN+HoCGJHUkwLPSrgyfU8805RkVN5F44AItNWlnBApeSaA3wJyaswzxjz9WWSUNIO1LelCr1gDEWCZ/UEdaKFBt9jtuat5Vsho70Lcn5rQFlSQPAg6pGQ+wne2kW8H5kX2t87hb02AvEe2qgbItZzRPWNRYs+zlTZMEyVaRh/jgsvOG1CmNb79jj8AEYbBGsi7PEtkI4WrAFo1SSLU/8bPGmsa3CI9ODIt/0e16BZIkNbKFQUU1J26tszCFJsolWFKDEA35h7IbvLiLgahXPG+/Ro0pLmv/Gi/Q/yUe85e6hfKMQAu46HZzWSohxociu1V3m5CX/xLYdBuMcvo1TSqd3W4FuT1U/xPPPpOz4O+KMxTrcaEMI1IYmicpijWllnewoKlAivHqT4xd6eRRDlY7057bkvCNZQ19H+pXFhPc0fRzZzlAy3NVg+pCR8VeE1B/Evb5oYWMui3aQRzs4b/Y2qrX9Pf899Yv6Ylk4Ms9R9njmLFyM9AtgWux5MCGQyRybSECkXiivLc69T5uYyXQJn/bdG3W2ILAnhgWotnXQ9iE0gXYAagdGcedhtkzrkOPcb/Un/o1+//N/hpuw7oAKoHpLlgsPGmo0CX3J8WSyJyy/6dDSlZH8QUq0tD5ZuPzbinQh6A0ziyYJUBQ7vVg26qOP1jKhYbV+eBjSH44hOL4sOxj/W+3/u9OIIq+9ZyzqWeaa3Uws4Zg1kQ0uN0zHMmvHHLWmpap2syJNRiOWCFgciw+Q2qMwYcvUc35wrJ01OMjk7YdWqYPNolHLCoO5paJCUrW07hQizit1V1BpTvtTCtF9AT2RRsJZyhn3PTMYRCdClGGQaAg73zN1t88yiZZyPgQ4N2nk+IcjqD+DTEX2t/q6WH67B4gkTZY7NFepVx6aHyfb0qyq8NVtqm+Lco5xnkDICxD/UTtTu972BEk1hnm/FVEuT+1VgmPPrjiI43mHSbllCV8y/fqKZbVLjs2vqDi0IGQzQP58XofgsaFFyWd7JkaxgaRONd+YoDPn2pgbHN+MX8kSRolUnBYGFX7h5XNCTT6Dbxpb+hdtPAosmBXLayjUBEPE0BXcXrRUgwxjlgq0IsSYKqfjv8y07oUlwZLDxqjO7CMvYaCYi/4ZfIglIbQ2SZg322FkU1Cjs9kiR5FaOVaK0e8VyHvx6U/dpIryDftL8kKyvmnezA7FLk9bW6jBy2M0r0c5aODJQLhC7saPi2xTipxfFibAFd2ks0jyTw8f8bvD7OBv/xSuRWQ4yf6feywJ+A/GBQByZq9EeEI1h4y3DTKj1Yzs/hUfQrVdotNmvrE1aCDNfA/t7a+8NIoiKyNK5YOnaYM5gwp9bhQpxf4S4LVX16CFSu6Uvo+wFQjQMk4NHM0d648vj6CKVMlKfla+Mu7CnYZ6kpYxoh8L8q9eOWju1DN/kN1SzkbTG0xl8Ymr+K8HcDNO7nTwCpOHPJki5XKuN11NcNywz8qnaVv0PX+mVF6/NM2rQuOtnWTqE7UdOrQnsRS0lWs4T9ODhw8tGlx02qI3RuZEZcnEs3LkrMM6PeWHpnFjSZcevvFA0RaSm6HTd0JE6z+P9K0Gj3UqC/qHsevaWeqnaLsD2xPtcXMxnUff0ORmDo+IZzOXkQz4N3W5yXZdcte3qrAHVP2wjCFRxkSS8IeTVda0MkZ9oMqawD4IaWKtSG7FDp6JAZV58v1SvV8SfvquLu0pEU2naGsjLVc2rYfx6QP4/R3DgwaCX7TaRxv+1i0s8qdYb8tXWq1wbWPp/3q9MDEdU3DZeKGpgSGYu0ek1KsdiPxSXL2XXH7F/z8aSKckfJxP1PQ0PcAd2HUMvrb5Ub8CZGTyYSv5c4eeDhtoc2qyFLgWGKbh5l9YPwmqWGQw7UQjzAS+Dbnxg0V0pHp6sViu47HgvUFvTILcQ8x1f4tQ8uF90KzchEgqNUuwbw8+mm6PAC24/zkXrLjZw+rDdMivrLWsJALRHNIIv4LSw8eMEij6hwte5cmjUmXmA4BFO0gvHFZMM6yGkVW2wqWfaYwrwQ/lwmUQrmtTFNiApqr+xSfpfJ9CcQEIgD2Wy9sbuay4l8lJvFKV2V/52PtJDSl3kzMeJfeuYk4otyOR0zx++BNZvNJcjQCDzGvbcjZqsaL+R7PJz3rApCHI4Irq23bhvD7zejPVcpjw8MUICAsUSJIh+MP/vMszS8ytJZ8JnNH+5yysz06TCRi6A1nphW6SONae5LtABFZ62J3/Vk815oDKy+OmMFcNOy0df9ORW/Y3LqmezCGnCMTiYgQRy7xYLvC61z97/H6FmAB47Rqt07tkYzys4Gzir0uLqZ3wgbbo/ahe5AaPfxJFrN/Eo7DFVzRbHqR/29f1paMHsofmq6MVBMJ8HzGw7Fu5gzaX95AzXqH2XD7o0TWepWAWElD1GI3Pq0nPhHOVQ3kH2xI9Sz6R8cDyjqHxuaaVxlYhbgz+r7xUpFKZ+9yuH1NLETcuSxFU9kucD2H1+JoDCWFeYbzRGd0ajYureo3DwN7ux4z+zDmHFmSVJrUaX4fP1e5HRMrsAL5herp3CH0OlYi1klf1g62tVmkez1DSmNA0OaHE7CzMp3oYeUMzEtLsywt3+Jc82UJbP1f8BZn46kk1qvbyrwl7jdUDVHBjqfCv5Q3OYOaXLoK38axVQr2stjHUmTfnqduuGRVbmgicCDutgv1xtgTJYuEaK+9BZY6VNa0c4xfm4n0zHytUkuW/zeDAnW3xw6+xyYqynVDd3e4u1vR0YhwkKdy2l8iF3qGbMWyhyWVwR5UjYnaXnnX3A+UWU61KSyq2Lp4hSb/RAuKqBdjBJGYcIppe9y7c+q4qm0/sch1JT/EWwqg7L1y1fQWs3Zli4VYRjX6gKkYlZeKPB4vdjfqB9OrUtYWwYEkJsYS36obJ5X6u4T/XT5uPE+V4OBOaPa6mRQDhe7SX+Q+KXEApbV20Rb1dwg5AcA07mtYDSiNMdG4ppDF3Jp7yPldXPwOBDBiOuFN+4fuxAl5GIiLvOtSt8aRU/Hy7E480zkirXg=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Mon, Aug 22, 2022 at 02:45:17PM +0530, Viresh Kumar wrote:
> This also relocates the code responsible to call make_xen_iommu_node()
> towards the end of the routine, so we create the node only once.

Could you do this part in a separate patch? Then, I believe the rest of
the patch could be squashed into the patch that adds i2c support into
libxl.

Thanks,

-- 
Anthony PERARD



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.