[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH V5 4/6] libxl: arm: Split make_virtio_mmio_node()


  • To: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
  • From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
  • Date: Tue, 6 Sep 2022 17:32:28 +0100
  • Authentication-results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
  • Cc: <xen-devel@xxxxxxxxxxxxx>, Vincent Guittot <vincent.guittot@xxxxxxxxxx>, <stratos-dev@xxxxxxxxxxxxxxxxxxx>, Alex Bennée <alex.bennee@xxxxxxxxxx>, Stefano Stabellini <stefano.stabellini@xxxxxxxxxx>, Mathieu Poirier <mathieu.poirier@xxxxxxxxxx>, Mike Holmes <mike.holmes@xxxxxxxxxx>, Oleksandr Tyshchenko <olekstysh@xxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>
  • Delivery-date: Tue, 06 Sep 2022 21:37:14 +0000
  • Ironport-data: A9a23:owW9DawxTTKPT9QdOwR6t+dRwSrEfRIJ4+MujC+fZmUNrF6WrkUCz mtLC2rUa6qINGuhLYwkb4Wx90sC68LRzoJqQAdr/iAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx 59DAjUVBJlsFhcwnj/0bv676yEUOZigHtLUEPTDNj16WThqQSIgjQMLs+Mii8tjjMPR7zml4 LsemOWCfg7+s9JIGjhMsfjb+Usx5K6aVA4w5TTSW9ga5DcyqFFNZH4vDfnZB2f1RIBSAtm7S 47rpF1u1jqEl/uFIorNfofTKiXmcJaLVeS9oiM+t5yZqgpDvkQPPpMTb5LwX6v1ZwKhxLidw P0V3XC5pJxA0qfkwIzxWDEAe81y0DEvFBYq7hFTvOTKp3AqfUcAzN12AWoPHdAl3dpUAEV81 +c0GhYqZBa60rfeLLKTEoGAh+wmJcjveogepmth3XfSCvNOrZLrGvuQo4UChXFp254ITa22i 8kxMFKDaDzJZQFPPVEGToozhu6yilH0ciFCqULTrq0yi4TW5FMggOaybICFEjCMbclWnByj/ mLbxjXgCU4WK9Oc92um/X3504cjmgukAdlPRdVU7MVCn1m71mEVThoMWjOTpv20iVWiSslfA 0MR8ysq66M18SSDS9j+Ulu4p3qBswU0X9tWGvc9rgaXxcL85AKUBXMNSDJbX8A3r889RTEs1 VihksvgAHpkt7j9YXCA8raZqxuiNC5TKnUNDQcGQhEC+MLLu5wog1TESdMLOKu8kt30FCy22 zeLtikznZ0XjMgCzaL99lfC6xqyp57CQwgpoArKX3656R9RYI+jbpavr1/B4p5oPIufC1WMo nUAs8yf9/wVS4GAkmqKWuplNK+o/fueMHvfnFtmBbEl9jKk4XnleppfiBllOEpnO8ADPyT1a UXevQdQ4p57LHqubKlnJYm2DqwCxKztBZLvW/bSY9dmZpl3fRWAuiZ0aia4xHz3mVQriuQzN Imzdt7pCXcBFb8hyDuwTv0al7gxyUgDKXj7HM6hiU79iPzHOSDTGext3Eaygv4R9K6vmSWIz vFjFMqu+TdEfN/YRSPRyNtGRbwVFkTXFawauuQOKLDZelo9ST9/YxPC6eh/ItI4xsy5gs+Np yjgAREAlTITkFWdcW23hmZfhKQDtHqVhVYyJmQSMFmhwBDPiq7/vf5EJ/PbkVTKndGPLMKYr NFfIa1s+twVFlz6F801NPERVrBKehWxnh6pNCG4ejU5dJMIb1WXpIW4JlG+q3JUUXPfWS4CT 1qIj1qzfHb+b146UJa+hAyHlDtdQkTxaMotBhCVc7G/iW3n8ZRwKjyZs8Lb1/okcEybrgZ2I i7MXn/0U8GR/NJumDQI7IjYx7qU/xxWRxILTzWHvebqbkE3PAOLmOd9bQpBRhiFPEucxUloT bw9Iy3UWBHfoGt3jg==
  • Ironport-hdrordr: A9a23:akVhwqGmddJCPsP/pLqE6MeALOsnbusQ8zAXP0AYc3Jom+ij5q STdZUgpHrJYVkqNU3I9ertBEDEewK6yXcX2/hyAV7BZmnbUQKTRekIh7cKgQeQeBEWntQts5 uIGJIeNDSfNzdHsfo=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Mon, Aug 22, 2022 at 02:45:16PM +0530, Viresh Kumar wrote:
> make_virtio_mmio_node() creates the DT node for simple MMIO devices
> currently, i.e. the ones that don't require any additional properties.
> 
> In order to allow using it for other complex device types, split the
> functionality into two, one where the fdt node isn't closed and the
> other one to create a simple DT node.
> 
> Reviewed-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>
> Signed-off-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
> ---
> diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c
> index 0e3051bac5e4..4d0469f8166a 100644
> --- a/tools/libs/light/libxl_arm.c
> +++ b/tools/libs/light/libxl_arm.c
> @@ -1267,8 +1275,9 @@ static int libxl__prepare_dtb(libxl__gc *gc, 
> libxl_domain_config *d_config,
>                      iommu_created = true;
>                  }
>  
> -                FDT( make_virtio_mmio_node(gc, fdt, disk->base, disk->irq,
> -                                           disk->backend_domid) );
> +                FDT( make_virtio_mmio_node_simple(gc, fdt, disk->base,

Renaming that function to add the suffix "_simple" doesn't meaning full,
could you keep the same name?

> +                                                  disk->irq,
> +                                                  disk->backend_domid) );
>              }
>          }
>  

Thanks,

-- 
Anthony PERARD



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.