[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 01/10] drivers/char: allow using both dbgp=xhci and dbgp=ehci
- To: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 6 Sep 2022 17:54:07 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1iDBAHzV9MbG1FBjlh7WM0trQYZ4f3zj/7HPeYAcyrE=; b=ButTz2teH3HoO2PMOb8OqkqALGEpZRqnAk+LMQsk3/VDyJy4tf362tppy5AlG0hjAGnHgDivaA4Y/MEr6dxxUrR18CLJejB0pXXhGcQdw9KllFMAkqGzYcQnAfq3jAaamxI4sEwNSFIrUfLbdL11fmsX9p5owylR9OukFm3rqFskyddOCUKFHextvWx6WcOjVJG66J1zkIAb3HShgSurI5eIIu9shsXxZi89vE3UbGOfPvTNJDVwcDVLneMVWbd0nFQQKd+FRoiL65PHR/D2PTwOeEVz6mNhu0yD0YrCrD8DJEr+tXLKT0F4co8zs5i9ERbcANPQzULY5SD/KvbIIg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TIPnV44K0ew46faJv1fCjxhnZZ6LmTl6/ooqtVAx62RB6xVWZ2u3Xhewsu6XyhkGudBtA/QztbnP/B8oVviBuG9RTVlMlAVviIPnVa9k1E+B9NoGX/KvdavheivwFmNAG0cSnwJl6VWqkkbmRs8ObB2uRMMTnofcmiD+FhES0N1ijiJbrc0dPl8++zaeBmo4ff7eynFW6B94iGGXlrLLJqIFYLv+LaZaeWbuqzNfe48hqBy4pBVABvszNSb6qwn/MtY98x49AyUJhNUGxLaDBuDH/qUqWNUfZuYysxdSQg7Fjm4+tSQhorqsFs9lAwWobm6IPyt/0nl++7NDWX8ABg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 06 Sep 2022 21:39:47 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 06.09.2022 17:46, Marek Marczykowski-Górecki wrote:
> On Tue, Sep 06, 2022 at 05:07:27PM +0200, Jan Beulich wrote:
>> On 02.09.2022 15:17, Marek Marczykowski-Górecki wrote:
>>> --- a/xen/drivers/char/xhci-dbc.c
>>> +++ b/xen/drivers/char/xhci-dbc.c
>>> @@ -245,6 +245,7 @@ struct dbc {
>>> uint64_t xhc_dbc_offset;
>>> void __iomem *xhc_mmio;
>>>
>>> + bool enable; /* whether dbgp=xhci was set at all */
>>
>> In dbc_init_xhc() there's an assumption that the "sbdf" field is
>> always non-zero. Do you really need this separate flag then?
>
> Not really, sbdf == 0 means "find Nth xhci", where N=xhc_num+1 (and
> xhc_num can be zero too). See the "if" at the very top of
> dbc_init_xhc().
Oh, I see. I'm sorry for mis-reading that code.
Jan
|
