[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 0/3] xen/sched: fix cpu hotplug
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 6 Sep 2022 11:32:05 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8LuHYQ+oWu7WAhdqIncHHg95MqTmJvPsU20Mr/RymWM=; b=iFXmpzup/lo5JJ7Qz2aSMkbPP4EfTyqGtNoOxVqySPjAAFvhE6roWtDtn7LRP/yM+kWyFKFkVdspgaOBbr67mFtX2E0RZD0qZVPDA0kvMN7jph626NKoJJrBD2O8QvT5GWCOMpucPd8eZB1uC6Ch9AubL8QH4zQJVtC2ngIs26NsOPOXsS28uKw5pLpLAJcVXRlvNx84rx6dKbmoaqpYfEytD7OgKNG8bZuiM4OZPckQi1pCB4+elSNGWyT9TcbywpQFGDLZD3unaqU7q0I3QXT6Ot7ipl97F7FNRJc6TG9/Z4DRO8yUaGxyLgHVJn4jjrOIGu69vSP/Du+X+JQ6Lw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iwB539alk/EfTCCkzB6LA94ppQm+cACmKw37kuGP52T1aMnthqppJl1RBjWZcP4NaaThZw2/gCqmAHVRip4xM6DGUD2dgcro8jFf6lAoNucJ8EALOt1MScoMq0tZSKMnwZ/kotO4QVcTEpAC0c6TzdviN0/Ob3Ahi2UOOsw6pLvDd7gNqqmbBHDUQwaOcU3Ag5/+hpVWD8jcdwLOaTR/NpvSnXAyR4QSDr/59fbexPpOQogFBO7X7clbn8bi+Rr5oIYxcZaE1QKvuU4BYuPYfFMZwYWT4qrwxG3VmZc8LqHzlSzo8+GmQ42z0dD7UVPnrFpg8WuNUroYmuqXx4pMdw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Henry.Wang@xxxxxxx, George Dunlap <george.dunlap@xxxxxxxxxx>, Dario Faggioli <dfaggioli@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, Juergen Gross <jgross@xxxxxxxx>
- Delivery-date: Tue, 06 Sep 2022 21:50:40 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 05.09.2022 09:00, Juergen Gross wrote:
> A recent change in the hypervisor memory allocation framework led to
> crashes when unplugging host cpus.
>
> This was due to the (correct) assertion that allocating and freeing
> memory is allowed with enabled interrupts only. As the main cpu unplug
> operation is done in stop-machine context, this assertion triggers in
> debug builds.
>
> Correct that by pre-allocating all needed memory while interrupts are
> still on, and free memory after interrupts are enabled again.
>
> Changes in V4:
> - addressed comments
>
> Changes in V3:
> - addressed all comments
>
> Changes in V2:
> - addressed all comments
>
> Juergen Gross (3):
> xen/sched: introduce cpupool_update_node_affinity()
> xen/sched: carve out memory allocation and freeing from
> schedule_cpu_rm()
> xen/sched: fix cpu hotplug
>
> xen/common/sched/core.c | 214 ++++++++++++++++++++++++-------------
> xen/common/sched/cpupool.c | 92 +++++++++++-----
> xen/common/sched/private.h | 21 +++-
> xen/include/xen/sched.h | 9 +-
> 4 files changed, 236 insertions(+), 100 deletions(-)
I notice you've committed this series, but I wonder why you did so without a
common/sched/ maintainer's ack.
Jan
|
