[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v3 2/4] docs, xen/arm: Introduce static heap memory
- To: Julien Grall <julien@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Penny Zheng <Penny.Zheng@xxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Wed, 7 Sep 2022 11:48:44 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KaLCuvJWI858oHkTBc7AFH9+Dd07svSAu0y6/r3rWgw=; b=irnqikn/g/fld/Z1MZpqLjevWXN3J1H1uYPG1JQT/V2B6hAIwWMiRwyCaXZhvWH/hNyxOiOTiA96iZ8tXG71JZJb4x/VSSBBsWIPtaBHHY+YPMJ74V1lmhYjpZKax7KeKWG63P910q01fyOdi0SQbg4KayZgEXdxqtUlfCR5FkjM0e7J1dbykjURtgfauJ32jWdw8sZZzGD+u4A9M6ao0l6Whrj2AKbaSFPYryWzpn1cjcibGOHhUCrYRomEIBJxgQ/N8iktsxaspBTO93qYIEU1jfLoM7oZWrbSJtJwH6gIOi2QyuDYdEQQzYs+nFF4lhiSux9imYEW5kctGc4LRg==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KaLCuvJWI858oHkTBc7AFH9+Dd07svSAu0y6/r3rWgw=; b=KnwkcqEHnMzVf+eqNL7HlynCrEErSyq3BR36lAnOdILIRXKUexn8yjr2oP/Wk8X47cydyCUx3LTHbHqh0jv73jSz6YSOjhVMkWFkypEjCy4PGlCngwljaS7UjXYkMkGU9zV5IXuEdJfo7xPlICVedYH7jtrxIk822TUMdFW4NPPLgp0j9f0BlV022we3IygYar9ar2X9oGtXYgdSr5ODE4f9FqZILb5MRGjzsmrLvzvXh7pGZDKaRJH+4sL/SKvagRb++WdwsRiIyorOpg4kAwsCeUI40jORqRoyfufop1AbFKmmXE3IAXEPlJ6mBwEtWxthMdTQcEJIeYxYYZGl/w==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=fR2Rork1E8YxqWg0Wc4rSvY9day9hlOuXckavs7ONyou3rk+8P3ajG+uVjNBAvgpac25rNSpL//uW+kw9OuvKxmoJjFdaU0UGxAy3QMWENRIb66D6m2x2pi72JugY5Fqd938FA9oL0HmK07StPTeXj7dbcUSKd3zKF/V/LLXimsKax+ZyFxKEtQWhPkaFrjfMJKpAQx7UaoR0vQRiMgI7mZ2xhIYgAcZYTOrA9FT94jpbmXzJKV1xoICEjtUAxOwWhROxEoDjDTu3gU3dzoFodTBQokLmKfblzhCH+v2WHUvGkfF603VT8tasY1r+fvtGVQ7lhB5LwCFUWRPpZJYBg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=khCvLgw6rc9fL9DeLpJ5C8NxAAB+eZ9m9mz/3HYLgec/wAVROKvkQHR+oXQeyM1ANU/Aq55lxdjK/s1Vjx9hoHTH/tqEZBBLW4l5qPeHAkibY6Edu0nQV+l5GSkxHV5wgvapkfaRPlV0d9uyStRE6lQdO5Sk+czA0NgnIlqnNwD7aeEUHmb2VBqTv9gHMHr6p6OWkk43M2o/1uygMkZnHVBzEqxTra1NPis54zKP5ZgGpzJSqhaXPp049epAjwsVOLH62Oq8N1NX7DR1Gl4y8g+5UWCODKxoDEVQ1Qufl/Aum1G5L+moXNHj7F2Yg0n2ShrSrYlwylHpERyXTTJBEA==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Wei Chen <Wei.Chen@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Wed, 07 Sep 2022 11:49:10 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYwpUJ7IYztv5II0KGaSuPgw9aFq3T1xaAgAABDrA=
- Thread-topic: [PATCH v3 2/4] docs, xen/arm: Introduce static heap memory
Hi Julien,
> -----Original Message-----
> From: Julien Grall <julien@xxxxxxx>
> Subject: Re: [PATCH v3 2/4] docs, xen/arm: Introduce static heap memory
>
> Hi Henry,
>
> While reviewing the binding sent by Penny I noticed some inconsistency
> with the one you introduced. See below.
>
> On 07/09/2022 09:36, Henry Wang wrote:
> > +- xen,static-heap
> > +
> > + Property under the top-level "chosen" node. It specifies the address
> > + and size of Xen static heap memory. Note that at least a 64KB
> > + alignment is required.
> > +
> > +- #xen,static-heap-address-cells and #xen,static-heap-size-cells
> > +
> > + Specify the number of cells used for the address and size of the
> > + "xen,static-heap" property under "chosen".
> > +
> > +Below is an example on how to specify the static heap in device tree:
> > +
> > + / {
> > + chosen {
> > + #xen,static-heap-address-cells = <0x2>;
> > + #xen,static-heap-size-cells = <0x2>;
>
> Your binding, is introduce #xen,static-heap-{address, size}-cells
> whereas Penny's one is using #{address, size}-cells even if the property
> is not "reg".
>
> I would like some consistency in the way we define bindings. Looking at
> the tree, we already seem to have introduced
> #xen-static-mem-address-cells. So maybe we should follow your approach?
>
> That said, I am wondering whether we should just use one set of property
> name.
IMO now we have the pair
#xen,static-heap-{address, size}-cells and xen,static-heap for static heap.
and the pair
#xen,static-mem-{address, size}-cells and xen,static-mem for static
memory allocation for dom0less.
So at least these two are consistent.
I guess the concern you raised is related to the static shared memory for
dom0less,
...
>
> I am open to suggestion here. My only request is we are consistent (i.e.
> this doesn't depend on who wrote the bindings).
I am not sure if Penny and Stefano have some specific requirements
regarding the static shared memory usage. So I will wait for Stefano's input.
But yeah we need to keep the consistency so if we are agreed that I need to
change the binding, I will do the corresponding change.
Kind regards,
Henry
>
> Cheers,
>
> --
> Julien Grall
|
