[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 2/4] docs, xen/arm: Introduce static heap memory


  • To: Julien Grall <julien@xxxxxxx>, Henry Wang <Henry.Wang@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Michal Orzel <michal.orzel@xxxxxxx>
  • Date: Wed, 7 Sep 2022 14:41:54 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=xen.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=woKPLq+RkGsItn6F4ZxvyD92K+4Tuo/7tb3rJtxA62k=; b=UkXy847eX+bpVOSLFJATu1iwH9AjXtGNiHPrgAHX2Qw43vGAinjg7ZqmGyQV+uBBTBkPFXPADcwcfXwciNBKpFcKt93T8C5PC73aCSDy2uJMnwORGA5mq9chqMj94XzmuuzvBDp3DLvznUgv4uBmF3TXLdqvnXmbrSaquwAcCZdcBOOjoSiPVgSr1FMuVRKW8Gu+3Q8zE0yQD/yGVKp6kzc5m+S3zKGb6ZO+5bAfpL4oWHOhEL+Vli4W5MLMHBvNb6EoYawbqsV/vlrgf4g5N6Dvj7wb9su/TjmyC2GGEUgV6/qe2f4X5oy+HLvRXoZ8A/f/hgqJ2dCL5zsVttdOlQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GthO+fsbVKS51MGxY6j/Llv4yTTdXOa0P36N2JXs3uPHKDg2DJr0p9x9kzdPZQr+ZTD6hFW/gvqvw4TDx9a2Fvnt+Or9Ld21uNO1E9o+Q54V2xLSiV3qnljng99rflGf1nEgD1Mu3xFUmMiJeTnBpB1l2Q2p2OY9E466AM53LgjO3iPlBH6FHugHqLre/lwtRCMLl20Nc33kMJ8+JXVfwJ/8UYG0tFZrK987DimlTD9cAGQILez4/IBlWqq93GRcJEhPIxWwOmXWBbKsv9/J4gGvpSuxD7a+VWBnMRMJzeK2ANlAqYBH9cUAYL4p1gg6zKxxkcDKANqUZSh6Cqa21g==
  • Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Wei Chen <wei.chen@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Penny Zheng <penny.zheng@xxxxxxx>
  • Delivery-date: Wed, 07 Sep 2022 12:42:12 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>


On 07/09/2022 14:32, Julien Grall wrote:
> [CAUTION: External Email]
> 
> On 07/09/2022 13:12, Michal Orzel wrote:
>> Hi Julien,
> 
> Hi Michal,
> 
>> On 07/09/2022 13:36, Julien Grall wrote:
>>>
>>> Hi Henry,
>>>
>>> While reviewing the binding sent by Penny I noticed some inconsistency
>>> with the one you introduced. See below.
>>>
>>> On 07/09/2022 09:36, Henry Wang wrote:
>>>> +- xen,static-heap
>>>> +
>>>> +    Property under the top-level "chosen" node. It specifies the address
>>>> +    and size of Xen static heap memory. Note that at least a 64KB
>>>> +    alignment is required.
>>>> +
>>>> +- #xen,static-heap-address-cells and #xen,static-heap-size-cells
>>>> +
>>>> +    Specify the number of cells used for the address and size of the
>>>> +    "xen,static-heap" property under "chosen".
>>>> +
>>>> +Below is an example on how to specify the static heap in device tree:
>>>> +
>>>> +    / {
>>>> +        chosen {
>>>> +            #xen,static-heap-address-cells = <0x2>;
>>>> +            #xen,static-heap-size-cells = <0x2>;
>>>
>>> Your binding, is introduce #xen,static-heap-{address, size}-cells
>>> whereas Penny's one is using #{address, size}-cells even if the property
>>> is not "reg".
>>>
>>> I would like some consistency in the way we define bindings. Looking at
>>> the tree, we already seem to have introduced
>>> #xen-static-mem-address-cells. So maybe we should follow your approach?
>>>
>>> That said, I am wondering whether we should just use one set of property
>>> name.
>>>
>>> I am open to suggestion here. My only request is we are consistent (i.e.
>>> this doesn't depend on who wrote the bindings).
>>>
>> In my opinion we should follow the device tree specification which states
>> that the #address-cells and #size-cells correspond to the reg property.
> 
> Hmmm.... Looking at [1], the two properties are not exclusive to 'reg'
> Furthermore, I am not aware of any restriction for us to re-use them. Do
> you have a pointer?

As we are discussing re-usage of #address-cells and #size-cells for custom 
properties that are not "reg",
I took this info from the latest device tree specs found under 
https://www.devicetree.org/specifications/:
"The #address-cells property defines the number of <u32> cells used to encode 
the address field in a child node's reg property"
and
"The #size-cells property defines the number of <u32> cells used to encode the 
size field in a child node’s reg property"

> 
> Cheers,
> 
> [1] 
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Felinux.org%2FDevice_Tree_Mysteries%23.23xxx-cells_property_name&amp;data=05%7C01%7Cmichal.orzel%40amd.com%7C40290431f16748808b6308da90ccfc53%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637981507324472512%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=okN60ULg2Dx3cnlA5vPLMR%2F8QAKnbGmBpz7goXb5usw%3D&amp;reserved=0
> 
>>
>> ~Michal
> 
> --
> Julien Grall
> 

~Michal



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.