[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 2/2] xen/pci: replace call to is_memory_hole to pci_check_bar


  • To: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Wed, 7 Sep 2022 15:21:50 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=x9GWfyb5PK+MoEjaitp5FPPBm/23WnA+TC8H9KVOd4w=; b=j6LbXaZ113U5J3iHxa3yZJvmvixtxoheQwJSbvvl44gudhFnPXg4388kiHujpuhCWkuv3hg5XoPYXR8ruyNeDIWEwPWQx+AMU0MHEmtosBhZzWLCkHNuKwgHOLxZP6al5MEKAQecGnwEY3ojHL65KRG4d99JDwbhQusfwxDWTv/HxAXp9xqqPj9qcbsboXOWC652tBmD6INhzJhzIrNZexiBmqe4iqejIg+2RO+Rgx3hzZ0pYBGl1+A7WErik9M+s6XeaqFFnBudGs/utPHBxt6wuiVIhdiBU3C2QdZ3oa6M0Q5mFDpGTDCVfxSGSS3ZysjFph/4IZ6g0hZPivPW5Q==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AQq62dd3Gzn7rrqc8PAUkMU3oKwy+sGgJIqEGgDjgRDNE7X6WuTs46isp3jA+7T3/o3OEvFhNAmKcFfouO+VZQ4h9vflOmAvGbThdXZKokXAVdCJ96CyiHlR15br+4yWPyYjv0ScuJuixh4m8v+ShZIW0PDzQkTzVMWyH2r/M84zfgK8T0QlEg6mmw+eWEQlxMDNPp4Pv7uil4uj+4j71e+mS5h++cmu7NwL6gIUtVSYwAIEbEswcITiptd0kzWhs4QLLZhnI5PtBy1SgTPvPjOi+nyaEuAtEgEFkGHUSxAKpL3jkJbv0jNXay58lor5kZ1m8Tp1BKQOvuc0dJ0qvQ==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Rahul Singh <Rahul.Singh@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Paul Durrant <paul@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Wed, 07 Sep 2022 13:22:03 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 07.09.2022 15:13, Bertrand Marquis wrote:
> Hi Jan,
> 
>> On 7 Sep 2022, at 13:06, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>>
>> On 07.09.2022 13:09, Rahul Singh wrote:
>>> is_memory_hole was implemented for x86 and not for ARM when introduced.
>>> Replace is_memory_hole call to pci_check_bar as function should check
>>> if device BAR is in defined memory range. Also, add an implementation
>>> for ARM which is required for PCI passthrough.
>>>
>>> On x86, pci_check_bar will call is_memory_hole which will check if BAR
>>> is not overlapping with any memory region defined in the memory map.
>>>
>>> On ARM, pci_check_bar will go through the host bridge ranges and check
>>> if the BAR is in the range of defined ranges.
>>>
>>> Signed-off-by: Rahul Singh <rahul.singh@xxxxxxx>
>>> ---
>>> Changes in v4:
>>> - check "s <= e" before callback
>>> - Add TODO comment for revisiting the function pci_check_bar() when
>>>   ACPI PCI passthrough support is added.
>>> - Not Added the Jan Acked-by as patch is modified.
>>
>> Hmm, I don't see any change to the parts the ack covers (x86 and common),
>> so please re-instate. I'm not in the position to ack Arm changes; things
>> would be different for a Reviewed-by without scope restriction.
> 
> This might have been clear for you but your ack was not mentioning anything.
> As the newer version is modified anyway, we remove it.

An ack can only ever apply to changes to files the person offering the
tag is a maintainer of. Hence there's rarely a reason to scope-restrict
it. As opposed to Reviewed-by, where someone may indeed have reviewed
only part of a patch.

> But I understand from your answer that your ack is still valid for this 
> version.

That's correct.

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.