[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 1/6] xen/x86: Provide helpers for common code to access acpi_numa


  • To: Wei Chen <wei.chen@xxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Thu, 8 Sep 2022 10:22:29 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kzFCySBau2bZmE8334JJ6H6sO2BpIfwAdZZj1ByL3VM=; b=lVHxqqYwrj6la17S9gd2ccgHfBrTen05r0dq+7boGfWwBvR3sT0rTKcOD08dk+v3q2P/AZd3lL3jSv5R4OL261IgAx6itnr9idb2dcdVrTh9hr8Jrl3n9DyBAaVXzSyVSvaFgWswaLh6xAxYwCLWOpQfy1OuUp3fbxb7GGY9LnAbX/Wic38xoWrhOkdeJcyfugRhQ0Vs/RwXVLV94ivsiDm04J5BKXeeLIwDr519hQW8L4MxPda76mwvXx52xfsC4C8qEiuC0OCpw4OJR3YgFhZc6EBMYAQWKd/WTCzcja3yqqpr3Gi4uQGs1yD7FtOSdYzJDJ7zpNMZHsSjvE4Ybg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XoMVlMx2VsAlGRlxMThUroN+gjeK1wjSWv0v39I4JzzrGXqUu5bG4ChZ3gdARBpPGN09uGIPiqbc0JOCLmQI0O2R/C2fdH77xDAofpTAT+E5LOHwDJOX5ca/WBYn9KPvTJtECWPbjS0o/D9M3FhG6gSIfm07TFPMn4zrvTmRfrbhKBs9WRx9P6exX3zR0Xjbys9hctQmG7Sitq3+XMCXZrNuOzixe9qRhiALiZWPrZCI/BDqtSl6NAP9KTlyIGDhtp6OweWQNqq/FbUbMsWWo4Fm5XJeBihLbmf1WolxQ9V/Uh3w/iuaCH15Sk8MuC7nPxSrD3T/GNOkwGj8YLIpng==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: nd@xxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Thu, 08 Sep 2022 08:22:42 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 02.09.2022 05:31, Wei Chen wrote:
> acpi_numa is a specific NUMA switch for ACPI NUMA implementation.
> Other NUMA implementation may not need this switch. But this switch is
> not only used by ACPI code, it is also used directly in some general
> NUMA logic code. So far this hasn't caused any problem because Xen only
> has x86 implementing ACPI NUMA, but now Arm is implementing device tree
> based NUMA. Accesssing acpi_numa directly in some functions will be a
> block of reusing NUMA common code. It is also difficult for us to replace
> it with a new generic switch, because it is hard to prove that the new
> switch states can guarantee the original code will work correctly.
> 
> So in this patch, we provide two helpers for common code to update and
> get states of acpi_numa. And other new NUMA implementations just need
> to provide the same helpers for common code. In this case, the generic
> NUMA logic code can be reused by all NUMA implementations.
> 
> Signed-off-by: Wei Chen <wei.chen@xxxxxxx>

Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>





 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.