Re: [PATCH v2 2/3] xl/libxl: Add ability to specify SMBIOS strings

[Jason Andryuk <jandryuk@xxxxxxxxx>]

On Thu, Sep 8, 2022 at 3:51 PM Jason Andryuk <jandryuk@xxxxxxxxx> wrote:

> @@ -1783,6 +1784,57 @@ void parse_config_data(const char *config_source,
>          xlu_cfg_replace_string(config, "acpi_firmware",
>                                 &b_info->u.hvm.acpi_firmware, 0);
>
> +        switch (xlu_cfg_get_list(config, "smbios", &smbios, &num_smbios, 0))
> +        {
> +        case 0: /* Success */
> +            b_info->u.hvm.num_smbios = num_smbios;

...

> +            }
> +            break;
> +        }

Andrew pointed out this stray curly brace breaks bisection - its match
at the beginning of the 'case 0' is introduced in patch 3.  Sorry
about that.  I'm AFK, but will send out an updated patch tomorrow.

-Jason

> +        case ESRCH: /* Option not present */
> +            break;
> +        default:
> +            fprintf(stderr,"xl: Unable to parse smbios options.\n");
> +            exit(EXIT_FAILURE);
> +        }
> +
>          if (!xlu_cfg_get_string(config, "ms_vm_genid", &buf, 0)) {
>              if (!strcmp(buf, "generate")) {
>                  e = libxl_ms_vm_genid_generate(ctx, 
> &b_info->u.hvm.ms_vm_genid);
> --
> 2.37.3
>