[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v13] xsm/flask: correcting initial sid assignment on context allocation


  • To: "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Fri, 9 Sep 2022 08:09:41 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Xa/K3lhAZ+NfsogNr4mv4BnStV31r5aF7g5QOPXV0nA=; b=IhJd5hzDo8CFBXY9lI7h0cXchbMjHHiVTudYdqtwZN22jhbo4XsNXAMVyJav9lv0EwzCJjZcchmXno8qGEy8rFwxRjdpt0pGIgg/B9t5O1+4H2cvoX3pkODnczcz/KqZJ2xoLvVrPnHTkOyUoPR/6tiLIp1Spja6aJryOmfLwpP3wWaipex7SEuITKYCa6ozltExFzLFzzp65VDevAPdldf+0PRLVEuR8Dg5TV1CJeGf3OWRdSxdCDsrZz2fpXg43esdHAfBnEU9XxYU/sjNm5VmNe3LgSqBj8w8e4DhwlZoyaTcXfC6V7uWeAJ/h476XFKEo8w1/YbnsC16U8l+Qg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IYk63XjdJeDIIS0U49O5pcVWgyiWmnymXF8ARB7cYjvY0TIO+dOWmlki3nHZuXBTLtPRJPUYtoTB2QLBWjXNla3nnFAblWrlw3/aHRGu4BBs3Uklwsqebl7EiiHvJEnt+1sW8dP13YefN97Ut/pwhOPO/PyjskNOiaKB+iaX+KytpqlCf0GPe18uy+LGA+v1ZFKe8TjLuwptyqyF8IL30WNskffb1FZyLlRpKb/WlbBa1Ia43MIwRfOkjZG9/40gqE6MJ2pwjuN0fRiUOmg5kVCgts1MkmGlFDS/VJHJNeQtHgncdE0OkX5MTXsUS7dQwnEz7u8JEQpZ5uizE9J9gQ==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: jandryuk@xxxxxxxxx, Wei Liu <wl@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Fri, 09 Sep 2022 06:10:08 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 09.09.2022 03:25, Daniel P. Smith wrote:
> --- a/xen/xsm/flask/hooks.c
> +++ b/xen/xsm/flask/hooks.c
> @@ -38,6 +38,12 @@
>  #include <conditional.h>
>  #include "private.h"
>  
> +#ifdef CONFIG_X86
> +#include <asm/pv/shim.h>
> +#else
> +#define pv_shim false
> +#endif

Hmm, yet another instance of such. We have already several (and
dissimilar) instances scattered around, so I guess we really want to
centralize this (e.g. by moving things from x86'es pv/shim.h to a
non-asm header). Not something you need to do right here, but
something for 4.18.

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.