[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH V6 1/3] libxl: arm: Create alloc_virtio_mmio_params()


  • To: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
  • From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
  • Date: Fri, 9 Sep 2022 14:19:08 +0100
  • Authentication-results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
  • Cc: <xen-devel@xxxxxxxxxxxxx>, Vincent Guittot <vincent.guittot@xxxxxxxxxx>, <stratos-dev@xxxxxxxxxxxxxxxxxxx>, Alex Bennée <alex.bennee@xxxxxxxxxx>, Stefano Stabellini <stefano.stabellini@xxxxxxxxxx>, Mathieu Poirier <mathieu.poirier@xxxxxxxxxx>, Oleksandr Tyshchenko <olekstysh@xxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>
  • Delivery-date: Fri, 09 Sep 2022 13:19:31 +0000
  • Ironport-data: A9a23:3RYdV64fvPIVKkaoL/BGEQxRtHbAchMFZxGqfqrLsTDasY5as4F+v mJNUWnQP6zYMWH9L95+a9m18kpSu5LQxoNnHAplpHoyHi5G8cbLO4+Ufxz6V8+wwmwvb67FA +E2MISowBUcFyeEzvuVGuG96yM6jclkf5KkYMbcICd9WAR4fykojBNnioYRj5VhxNO0GGthg /uryyHkEALjimUc3l48sfrZ8ks+5KWq4lv0g3RlDRx1lA6G/5UqJMp3yZGZdxPQXoRSF+imc OfPpJnRErTxpkpF5nuNy94XQ2VSKlLgFVHmZkl+AsBOtiNqtC0qupvXAdJHAathZ5dlqPgqo DlFncTYpQ7EpcQgksxFO/VTO3kW0aGrZNYriJVw2CCe5xSuTpfi/xlhJHwXMZICq8hXOl9D9 M4nNzlcZUqcmtvjldpXSsE07igiBMziPYdZsXB81zDJS/0hRPgvQY2Tu4Uehm1pwJkTQ7COP KL1ahI2BPjESxRJJlcQDoN4hOqyj2PzWzZZtEiUtew85G27IAlZj+m9bICPJo3iqcN9sluZm U/fpCfFRT4FH9ee+QLG1Xyvibqa9c/8cN1LT+DpnhJwu3WMwkQDBRtQUkG0ydG+jkO9QM5OM Ew89S8nrKx0/0uuJvH4VgG4oXOZ+AYbWsBRHvcS7ACLw7DTpQ2eAwAsSTpMa8cvssMsciA7z V+Cn97vBjtHvaWcTDSW8bL8hTGvPSkYK0cSaClCShEKi/Hhr5s0lQnnVct4Hei+ididMS/xx TuHqjR4iKgSkdIMy42//FbOmTXqoYLGJiYl6wOSUm+74wdRYI++e5fu+VXdq/FaI+6xUFibs WME3cuD6ekUJZWMkiWXR6MKBr7Bz+2ZPTPVh1kpBIUo/Tmp/3+lfKhA4TV/IlcvOcEBERfgZ ELD/wlc4pleMVOubKl+eYX3DN4lpYD7Cc7sSvfPK9ZDfLB2bEqD/TpyfgiU3mbkik9qlrswU ap3au71UyxcU/4+imPrGaFNitfH2xzS20vuZJzk1UWJ8YGgaX+ndqgMYVDUcf0AufbsTBruz zpPCyeb40wBDregOXCMrdF7wUMidiZiW82vwyBDXqvae1c9Rjl8YxPE6el5E7GJiZi5gQshE puVfkZDgGTyinTcQelhQiAyMei/NXqTQJ9SAMDNAbpL8yJ5CWpXxP1DH6bbhJF+nACZ8dZ6T uMeZ+KLCelVRzLM9lw1NMej9tI8Lk3031vTYEJJhQTTmLY5H2T0FiLMJFOzpEHi8ALs3SfBn 1FQ/lyCGsdSL+iTJM3XdOiu3zuMgJTpo8orBhOgHzWmUB+zmGScA3Cu06RfzgBlAUmr+wZ2I C7NWU5E+bGU+dZvmDQL7Ijdx7qU/yJFNhIyNwHmAXyeb0E2IkLLLVd8bdu1
  • Ironport-hdrordr: A9a23:risCf673RSyXFAIp+APXwMrXdLJyesId70hD6qhwISY1TiW9rb HIoB17726RtN9/Yh0dcLy7V5VoBEmsk6KdgrNhWItKPjOW21dARbsKheCJrgEIWReOlNK1vZ 0QCpSWY+eRMbEVt6jH3DU=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Thu, Sep 08, 2022 at 02:22:59PM +0530, Viresh Kumar wrote:
> In order to prepare for adding support for more device types, create a
> separate routine to allocate base and irq for a device as the same code
> will be required for other device types too.
> 
> Also move updates to virtio_irq and virtio_enabled out of the disk
> device specific block, as they will depend on other device types too.
> 
> Suggested-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>
> Reviewed-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>
> Signed-off-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>

Reviewed-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>

Thanks,

-- 
Anthony PERARD



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.