[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [PATCH] hw/xen: set pci Atomic Ops requests for passthrough device


  • To: Paul Durrant <paul@xxxxxxx>, "qemu-devel@xxxxxxxxxx" <qemu-devel@xxxxxxxxxx>
  • From: "Ji, Ruili" <Ruili.Ji@xxxxxxx>
  • Date: Tue, 13 Sep 2022 03:02:01 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gkvIyBMgo/NmIFYsjc24BRclBG2sUpVhlh4owhI0ob8=; b=O+3f+HCPYK3imDVdGaHqBWtFzNU7hveaRnuTDNMnaU9gDmnFtIo9L/J9PaS1ct/KoFB81qpj8PFoPA3XLog/1XEISMsfoBj9oWU9lNlECSuSw3XsWjnPGIrsaST75reClSfcJWnj6mkxoKKjdIFlzVo0pgByAuB1K9qwPfwNkq2MzZig5vwUSGVoIIZdWCNqbFISJK2jsJPwOEI8ms+rI17+0fl76h5CDsZoCrDmhkanmaO9iHYBXmWP5Q43v2O0ESDnYeH5EYt9HwFZ6kg7wkXK/UkraZhZa69ANPfwJj21NjEKWZoWs6yZqsjN+kPAkYR2Tc75SUVKePYfAPKkLA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CcJpAWxHp1YcHlSBrGMyCh7IPCE7B/tZFfQky92qWTWEOU+gliSzCp0EweCEAQxFGWXSJecg3pQ5aLWxkdUjxxOhP9PRl0COyF2+Krs7LDj3x+K6+9zNyTwmWRuNiMBi/mGxya3B93FdM9jrZe7F0dpRdy/pyV1DclCVRJVig7c05xJc6tC7rRZmXO2osenq1VFrkFXC2Jz/aMNJkaU0967Ug8i75wpObcjYUBqZapuSAV5rNtPUW7Ocw2Tfpacrme6EGba2Z8Lz0ZhDuHHLGr/ao6XEE5Ir6Qk78v+zxFG1o0b+t48krFDBMp/y6ddwSgEAwha9848RA4JjgsS+AQ==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
  • Cc: "Liu, Aaron" <Aaron.Liu@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Tue, 13 Sep 2022 03:02:15 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=149f7e60-4d0f-4975-8ab3-8497009eb09c;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2022-09-06T07:36:17Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d;
  • Thread-index: AdjBw9S5XjagBB9xT0W01YXm2Fq4yQAkLQ9gATHwuGA=
  • Thread-topic: [PATCH] hw/xen: set pci Atomic Ops requests for passthrough device

[AMD Official Use Only - General]


Hi Paul,

Could you help to review this patch?

Thanks

From: Ji, Ruili
Sent: 202297 9:04
To: 'Paul Durrant' <paul@xxxxxxx>; 'qemu-devel@xxxxxxxxxx' <qemu-devel@xxxxxxxxxx>
Cc: Liu, Aaron <Aaron.Liu@xxxxxxx>; 'xen-devel@xxxxxxxxxxxxxxxxxxxx' <xen-devel@xxxxxxxxxxxxxxxxxxxx>
Subject: RE: [PATCH] hw/xen: set pci Atomic Ops requests for passthrough device

 

FYI

 

From: Ji, Ruili
Sent: 202296 15:40
To: qemu-devel@xxxxxxxxxx
Cc: Liu, Aaron <Aaron.Liu@xxxxxxx>
Subject: [PATCH] hw/xen: set pci Atomic Ops requests for passthrough device

 

From c54e0714a1e1cac7dc416bd843b9ec7162bcfc47 Mon Sep 17 00:00:00 2001

From: Ruili Ji ruili.ji@xxxxxxx

Date: Tue, 6 Sep 2022 14:09:41 +0800

Subject: [PATCH] hw/xen: set pci Atomic Ops requests for passthrough device

 

Make guest os access pci device control 2 reg for passthrough device

as struct XenPTRegInfo described in the file hw/xen/xen_pt.h.

/* reg read only field mask (ON:RO/ROS, OFF:other) */

uint32_t ro_mask;

/* reg emulate field mask (ON:emu, OFF:passthrough) */

uint32_t emu_mask;

 

Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1196

Signed-off-by: Aaron.Liu@xxxxxxx

Signed-off-by: ruili.ji@xxxxxxx

---

hw/xen/xen_pt_config_init.c | 4 ++--

1 file changed, 2 insertions(+), 2 deletions(-)

 

diff --git a/hw/xen/xen_pt_config_init.c b/hw/xen/xen_pt_config_init.c

index c5c4e943a8..adc565a00a 100644

--- a/hw/xen/xen_pt_config_init.c

+++ b/hw/xen/xen_pt_config_init.c

@@ -985,8 +985,8 @@ static XenPTRegInfo xen_pt_emu_reg_pcie[] = {

         .offset     = 0x28,

         .size       = 2,

         .init_val   = 0x0000,

-        .ro_mask    = 0xFFE0,

-        .emu_mask   = 0xFFFF,

+        .ro_mask    = 0xFFA0,

+        .emu_mask   = 0xFFBF,

         .init       = xen_pt_devctrl2_reg_init,

         .u.w.read   = xen_pt_word_reg_read,

         .u.w.write  = xen_pt_word_reg_write,

--

2.34.1

 


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.