[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] libvirt: disable Werror for non-libvirt flights
- To: Ian Jackson <ijackson@xxxxxxxxxxxxxxxxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Tue, 13 Sep 2022 15:15:02 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2wxWZwwEf++RQVQliz6rN3H76q7ry3k9nfOI8TQn3zU=; b=k2q4TuymRkHlAS3nLc3HR1jpBKrprqWGu5/dOJwzqkLzga3a8LpdZ53LIBIk37qPf0rtjHQrmbCTfB5frWJHriVDoRPX9crVdchmXKgJ5yFgSsf4KBMLYuf2Tg1TUZgCTRxM6murqBUU/ZlHkZMBc8NtFsVUsL+OtvUgzfXvhSN6Pa6k4NiF6PvZZGBVRSu0zI9srPTxEvhUyyvsZOlrptzo41xD4vPrmBsoRXL84Ftcp4U6EVzsds8VX0SBTqMBIVrn75NyOiDEeXBqO1ktWC4Unu9Nm/cjNKfK8pO/eOEK9JKReTtgjWj5kXC+DXt+eVqs0dTWz+Ozx5Kyehqt7A==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eBcKJelxpiUuP5FevrMff+ArH2fOSXRNeJYyIPidXszwNEeonKI6bGmHrIcybWrwPVUrjxOAc9goUrrPpjWwwJXuF7qiM/xKpG7xsYu1QTjZC5RyPS+KquL54q5HO/kU0TkQ5qJ4qoUCqVhA4/uUPun14Kdi1dpbiGImjPyKbJKfQX/+iFqOBs+SPe8ojeSqODDoAmWKxjoetWJqGj2Tn8I5pJCyICzUD5PMzcmJydnh0dySBHR5BPmDlG3pY7SK3LkRsuUkY3mZ6K35B+CuVKa2XuYzozQdmSGsP3p1mic7EQTew/Hahfnz+K/siwGbmbgtjDNew4gCnGi20YmB0A==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>
- Delivery-date: Tue, 13 Sep 2022 13:16:02 +0000
- Ironport-data: A9a23:EqG7yKMlE+Z8QIzvrR2KlsFynXyQoLVcMsEvi/4bfWQNrUolgmQEn zQZCG2CM6yIZGGnKopxOo6/9xsCv5fRzdBrGwto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h ynLQoCYdKjYdleF+lH3dOCJQUBUjcmgXqD7BPPPJhd/TAplTDZJoR94kqsyj5UAbeKRWmthg vuv5ZyEULOZ82QsaDhMuvvY8EoHUMna41v0gHRvPZing3eG/5UlJMp3Db28KXL+Xr5VEoaSL woU5Ojklo9x105F5uKNyt4XQGVTKlLhFVHmZk5tc7qjmnB/Shkaic7XAha+hXB/0F1ll/gpo DlEWAfZpQ0BZsUgk8xFO/VU/r0X0QSrN9YrLFDm2fF/wXEqfFPs2vFyEk06GrQG//9LCGBN0 KMSKBA0O0Xra+KemNpXS8FKr+F6dYzAG9pavXttizbEEfwhXJbPBb3Q4sNV1ysxgcYIGuvCY 80eanxkaxGojx9nYw9LTs5h2rr2wCCgLVW0q3rMzUYzy3LUwwFrlqDkLfLee8CQRNUTlUGdz o7D1zSjU0hDZIHBodaD2licguWVjC3iY6QDEYWc3dpA3VPNxHNGXXX6UnP++5FVkHWWWtBWI E8P/SwGpqgz/VaoCNbnUhC+rXiI+BkGVJxNEIUS+AyLj6bZ/QudLmwFVSJaLswrstcsQj4n3 UPPmMnmbRRtrbmURHS15rqS6zSoNkAowXQqYCYFSU4O5IDlqYRq1xbXFI88Tuiyk8H/Hiz2z 3aSti8iir4PjMkNkaKm4VTAhDHqrZ/MJuIo2jjqsquexlsRTOaYi0aAtAGzASpoRGpBcmS8g Q==
- Ironport-hdrordr: A9a23:++b7EqONIg86PsBcTyT155DYdb4zR+YMi2TDiHoddfUFSKalfp 6V98jztSWatN/eYgBEpTmlAtj5fZq8z+8N3WB1B9uftWbd2FdAQLsSjrcKhgeQYBEWldQtqZ uIEZIOb+EYZGIS5aia3OD7KadH/DDuytHUuQ609QYIcegFUdAD0+8vYTzraHGeCTM2cqYRJd 653I5qtjCgcXMYYoCSAWQEZfHKo5numIj9aRALKhY74E3W5AnYoYLSIly95FMzQjlPybAt/S zslBH43Lyqt7WexgXH32HewpxKkJ/Ky8dFBuaLls8JQw+c/DqAVcBEYfmvrTo1qOag5BIDl8 TNmQ4pO4BJ53bYbgiO0GnQ8jil9Axrx27pyFeej3emi9f+XigGB81Igp8cWgfF6mI71esMnZ 5j7ia8jd56HBnAlCPy65zjTBdxjHe5pnIkjKo6k2Ffa40Dc7VcxLZvtn+9KK1wUx4S1bpXXt WHVKrnlbdrmBKhHjvkV1BUsZCRti9ZJGbHfqAA0vbloAS+0koJjHfw//Zv70voxKhNNKWs2N 60TJiAtIs+O/P+PpgNcNspcI+QNlHnZy7qHSa7HWnHfZt3S04l7aSHqIkI2A==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Tue, Sep 13, 2022 at 01:54:12PM +0100, Ian Jackson wrote:
> Roger Pau Monne writes ("[PATCH] libvirt: disable Werror for non-libvirt
> flights"):
> > Current usage of Werror=switch-enum by default for libvirt builds out
> > of the git tree causes issues when new items are added to libxl public
> > API enums if those are used in a switch statement in libvirt code.
> > This leads to libvirt build failures for seemingly unrelated libxl
> > changes.
> >
> > In order to prevent those errors from blocking the push gate, disable
> > Werror for libvirt builds when not in a libvirt specific flight.
> >
> > The errors will be reported on the libvirt flight, and block the
> > pushes there. So the author of the changes in libxl is still expected
> > to send a fix to libvirt code. This is no ideal, but the other option
> > is to just disable Werror for all libvirt builds and let libvirt
> > developers fix the breakage when they notice it.
> ..
> > +build-i386-libvirt autogen_options
> > --disable-werror
>
> We have no way to specify -Wno-error-switch-enum specifically ?
> (I'm not sure if that would be desirable.)
Hm, maybe playing with CFLAGS, but not from the autogen/meson options
AFAIK. Using the autogen/meson flags seems cleaner and less error
prone (albeit the disabling of Werror is more wide than what we
strictly require).
> > I'm unsure whether we want o disable Werror even for libvirt flights,
> > but this seems more conservative.
>
> Probably disabling it only for Xen is right.
Thanks, let's try this first then.
Roger.
|
