[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[for-4.17 v2] xen/arm: domain_build: Always print the static shared memory region


  • To: <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Michal Orzel <michal.orzel@xxxxxxx>
  • Date: Mon, 19 Sep 2022 20:37:37 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=L6Sabc4pZq9IA1rmU3S2UQoeU2Nxuf8Lvhkj3rNxmAY=; b=YzsTrj+g5MULMHLwDduAbn2GSd4tJ6F0mkNjJcU/vDDVNH6IQNJqf5MjF+HXlRjewlyMswADv7LlBnYrpKRk8KdT42kahkHWteYxUIkvXUvZr8fwT3qwK1kCCjg095qkw7fL1yh2csKHBM5yG1/vz8sohiTzI7Z2LsGXX9RAbv3XVFjGa3EFxo1fLKpfaCJsmm1yl9+Hs60J5tGTSKVNeXslYnS8RjIxnHfJFCgg3KH+vaIzNmRWHicrG6BewEWPv561bLx7vGvtHtxgn+KLS7Mxb374oR+BvaC79ud8Ho9jNDQ81BjZTlBmD9gVhkm2Xh4o94tJOFwBZ2qdr+Z5Xg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VfS1TMHKzPnioeD0vg7FUkyic4qhUTBSJhEUeYcGCTo+FGPrqfw/AfhATNIMiSANwqkZaaujXP0HmIQ67cXtP+slfZkXf7Fitbq8ERSLfSGVL3K22DEM28RJq2kyyPkWZJeKtG7vX8NrxEKewA5EZhyQ671CusA5xKs4qYg1aF2yNX0B4uBJHTLXecC4Rr7ECfvOXh+VWAJGWgXjmWM5UGbLNzTEqsHIpextTSMy3VPT6PHUJTQ/OghW95prOm2legifjJAgsUUyX59TnF8RPOJKKVx25JZLum2jI0GHoL3ho8+nF6/KyTTuF86wTvfbcZKtFcBQ3+DRu2aw+uuaRw==
  • Cc: Michal Orzel <michal.orzel@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
  • Delivery-date: Mon, 19 Sep 2022 18:38:15 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

At the moment, the information about allocating static shared memory
region is only printed during the debug build. This information can also
be helpful for the end user (which may not be the same as the person
building the package), so switch to printk(). Also drop XENLOG_INFO to be
consistent with other printk() used to print the domain information.

Signed-off-by: Michal Orzel <michal.orzel@xxxxxxx>
---
The other motivation for this patch is to be consistent with regards
to the format of the informative logs. We do not really use dprintk with
XENLOG_INFO unconditionally as it results in printing additionally filename
and line number which may be misleading for someone reading the boot log.
Such extra information is helpful on error conditions to make the process
of debugging easier.

Rationale for taking this patch for 4.17:
Useful information printed always instead of only during the debug build.

Changes in v2:
- use different argumentation
- drop XENLOG_INFO
---
 xen/arch/arm/domain_build.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
index 01c2aaccd82d..40e3c2e1195c 100644
--- a/xen/arch/arm/domain_build.c
+++ b/xen/arch/arm/domain_build.c
@@ -844,9 +844,8 @@ static int __init assign_shared_memory(struct domain *d,
     unsigned long nr_pages, nr_borrowers, i;
     struct page_info *page;
 
-    dprintk(XENLOG_INFO,
-            "%pd: allocate static shared memory BANK 
%#"PRIpaddr"-%#"PRIpaddr".\n",
-            d, pbase, pbase + psize);
+    printk("%pd: allocate static shared memory BANK 
%#"PRIpaddr"-%#"PRIpaddr".\n",
+           d, pbase, pbase + psize);
 
     smfn = acquire_shared_memory_bank(d, pbase, psize);
     if ( mfn_eq(smfn, INVALID_MFN) )
-- 
2.25.1




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.