[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen: credit2: respect credit2_runqueue=all when arranging runqueues
- To: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 20 Sep 2022 11:06:57 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7qAbSEm/Qjj9jInCq6Is7HEVCi/CM2NsVKwGUyl4Gd4=; b=b38WTEUxrgNyz9R6pZuavjftw6plLYfVCBqyrnpCT+9ji6fdFU/8FNGrk0+w9yiwHEbEXJHL9N1LImigyctwINUs2a5uEFZQIvUVvv8I6v9LEqf1WkYhYx0/gKbwW/1qn6WXIfNI1LY3VpHDh1RG2FfKHrzJXUK+TLs11ZwcU0zG8BcGAYNEWB7TMChDaT/Mz/k44t0XBa8cFykJ61idXxgftYoJb7M7+YWUM2VipcnYmgeheaoB3nD+rS0DHzCs8kCtGxBn3FkCf3/S4pA1Qyt2ddGUckIkJu2LjmHAOoDfhCV64ByIzEQC/ekMcPf/OPP75JTJnNLXzqPXUBp/aw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SuZ74EOo7YzVFADJLFGxSVuNa/c0ft1HXBVTslWIYoC6CeAdOD8r6TTmFYRQpLamsG6GSGY+gwfbS1LzAnDKTDVBVu2QeQvCFDvyO5FJRMOtfqxLyHO20TD2kWl0rBRrXy6bKwkwQgyGQJ4+Y6WIojQzuhBpDX6zyJkbFEm320CHOMEIZvKYMDTvtE8xJGO815IQvWD4TscLAs8pbkVDfc119KB8RU7k2d8+1yPR+muPJOSEc+CpZwV2sUolD8O/bVxygnwqHrdk24Ntu0QZQiFiPEf1jdTp9XW9N1P5WBCa7dxEstlYWmImXO3fW4Uqomp+mnlc9xvw9XyOGHJ5Zw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: George Dunlap <george.dunlap@xxxxxxxxxx>, Dario Faggioli <dfaggioli@xxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 20 Sep 2022 09:07:10 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 19.09.2022 17:09, Marek Marczykowski-Górecki wrote:
> --- a/xen/common/sched/credit2.c
> +++ b/xen/common/sched/credit2.c
> @@ -996,9 +996,13 @@ cpu_add_to_runqueue(const struct scheduler *ops,
> unsigned int cpu)
> *
> * Otherwise, let's try to make sure that siblings stay in the
> * same runqueue, pretty much under any cinrcumnstances.
> + *
> + * Furthermore, try to respect credit2_runqueue=all, as long as
> + * max_cpus_runq isn't violated.
This last part is questionable, partly because the command line doc is
ambiguous as to which of the two options is intended to "win". I guess
one needs to know the original intentions to resolve this.
> */
> if ( rqd->refcnt < max_cpus_runq && (ops->cpupool->gran !=
> SCHED_GRAN_cpu ||
> - cpu_runqueue_siblings_match(rqd, cpu, max_cpus_runq)) )
> + cpu_runqueue_siblings_match(rqd, cpu, max_cpus_runq) ||
> + opt_runqueue == OPT_RUNQUEUE_ALL) )
Indentation was already broken here. As you're touching it, may I ask
that you correct that aspect?
Jan
|
