[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 4/9] automation: Add Arm containers to containerize script


  • To: Michal Orzel <michal.orzel@xxxxxxx>
  • From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
  • Date: Fri, 23 Sep 2022 14:56:31 +0100
  • Authentication-results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
  • Cc: <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Doug Goldstein <cardoe@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>
  • Delivery-date: Fri, 23 Sep 2022 13:56:56 +0000
  • Ironport-data: A9a23:8KOx7K5KiIMDKvAA3qJQgQxR2vbMJQDmSyYv29bI7kJr3hzvcnyo9D/mcekdWBpeNJDhPy5nfkyN4CH03zbIScnTgcgFr2mXjYNR34oRyMGovQ3zzpCkE4M3NKU6iubEXqXl6WyUbWMFX1baI4wvZ3+S/ub5n98x+0Lafm8/6RU6zp/A1hntKSXYcerdyAcpTd9gunxOPcF+ugIuiA/38FGriuE9dUcNnTB7FEL/0hFxmAQ+Ao4elIf39/jCkfio76MZTReCBisJZVtA9o3G60Ks1uIbSW1xAQHueHxggzOTDo+it1ljv/z49qCrKz4jEdQ6PNucDZKNMeGsbU2fRe9QvrsMzUVQY2nPriEw+hMVw20QI2jl3AD3AnX29yp8ORbedvHY3Yit/5y6c/j6HiZyOEgKMrop/hZXlxROwgKjOpGO6cfqathKwT9Vvl1Zl8sQ1ffmUqSHyaiNwFdHKCU42VaPhSiNRf+agO5Npe1RXhNzeajvDtfJ8T5nDRRNpIX8ndm5QNyzohJFNeaTJAbJFTBr5G6LCP6MAjG95H3v7YDtNVYCBtQes5y8kLx6SVzl9+1SN5QlwwZZq4m+JCUP0eyvTNZ8m1ldjDWiLfXl1gvKri3A1kg4TSS/EqrJyab2QRlDMrOpPd3/z2w7IN0nLJ2Z0rMNp+kBlFGPWnmVxQSIRP2m083DQYWIA78aIhRvdpA/wVAUrTTN6mFYsIGQH8eju8h3cmyCfJOO/chQbA2MG+cyahGkKbHzH++L+JdJ6yC0aEO0TkpyQC/63GTVHFSFkkKESRLdhg45ymorpAu8wOiYgYgHdWkWR4qe/UEAJ1gvcgGZ6FwvVSuYBMumTwcWN90IzR+ufXgVkcXbssVjADP3ihWgIeD8rziW9KTeEYNaV9jeoUWHgPAqHOSeFq9PUAmrgLEn/+0Mh4kzdna32zUCFAGHQEfig7PngTAS7+CCYDP1F5v/6tTID+/ruiKuPyTNxuMX8u7LG8UwVMl4QDyMlx0Ws2UjV2kSyHOmDj/6tjGUTSh35Lj/cyrL7Xx0++OPF0hB1Rn4mEoc9ApkfBHhdoS0x2LkFCmyzXYF/5+kdYXwHJQSC3XfAMK04B3f2tD71rMGMqtc4HYOg9jjlCbU2cz2akg7JjCuMRU3miKAzfWMmyU8p+xMPIpKvZlUHX/aYN76RRU4Um+FFkBVzTppt1rpEeIGQmQE0oMehqyNq5cmFIb01WNzg+tJ2hTGmoCnhOH4SCO3YiAFiQpxglSqEe5MImZgVXReDlxLyqfLTf9lOrxWdxNI+8nVLTJnFdufUKCv9UE04DI9B42TXLaWqG64XFKooaBuBR/XDC5jihbjsh3CLk5DyXBc5T3tedPjZLfKUxvlBhDb5lXBN+EE33NIVcTQ25MKSqjC2GObtTsxcz0oiGJui+bToWE9WDncPgzUfhMR94VyjWjSyRKAHM3SGM3rswrCC+1G99yn6RljhZJ8rvIRJNeg71faJlW5sZ1EY7Mn0YjGGh6J02VJWq6E22muydfWqpnOXK6ZutUUvoAeKClTrqzFxR6CUYEUNNXVRFNMoSSCoLMxCo7YRH4wQeo41H3DiPg/EpsSC32vof0iHI8rYXj44uyb9CLn5L79skoKGh5mOGUToNBge4228G9B5rKmgiM5XgETPNDPjriZGqtLI7AkXILBSQOzIREDNrLas6to2Pkoz+rEEntl6KszrF4F3T0bhJQdmbQNCrr6fYf4i82JfN2ozsBNU2fi9neim8S5Y2G56UjAAz2WXh9uVqJHP8xXOXWpwmuyB0iTXiHBWPM6H1s/JnB1DkKecLOr1RiDMlexIFr/N0eJUCrH4k4UDGFb2Fq0tYWnHT2VHYoeRqQGKWE4qT/0kqMEaULaKaD79mYOPqeIZNppbBcee/gXSTh7Hr/dvfuTBTDp6iodUncFnLRcRV0lCl/MtZWCjyh7PfWeba6PyzymS3Utpyf4x1lyxFL19VPPPLs8bPhsbX9ENoXgjLcHYcTyIcnf48cUYvsDZ7V4RjkMTYn2/UXYLn7bEhK9vWoZHYyEeyPGLohTc5uiAEnokoHdDO5iU6DKzOxzbBgxxTGS7hklTULhIhNKeyROhHGabMS3DPgvIIcNiPEu1sUri0EL23ZBYQ+Vzr3BT9vAPs3oVeaqherOqV5Im0JS2TYpUgZEwJekPqDa4PKZwssgabNz6muXod1qgUEqoloo6GT4xk5dMag4XkyT+DoBtp8NMqCtdsgXbwH8uQTkLTlBzG1aMCDurlqtuph7+OYi28X9UFWd1bGhNqW932ddgzJMZFlEYh7sGDoTM6AKjNj3/gE4WU9qol73quB4flNoP4nophMZsF3GRFzoANh5e9nYhloHGMyyl/CMGL0DwMPKmCNPpEus0eBPjoYMl0Z+a/aANXqbOhV4bjON6AZ5vFWkjDtoIsLcTGgBbvbYQoRX16UeH01TqKK93Tr0LEKIE81xdooKAkmvCh6HH7zaookBoOw4OMxJJHY4+cI/Sjo+OSCMJX02/g2I8fyOUaajaK3iz1gFRRoglfrhYPBwMYKHJCtcXZqgbt/XrUkVExf3AxyElmMFMe+3SR5XaLG/dtwCASfjig9HpRQOuF50twQS6UvA2sK6Pjtlk54bYkqtSOF+Gg52n/U+5b0QK0rJh2hHgFAAHSFpvKQLtapIY52WM3IIcJB0pxAPDUEngHNXxHY2fSoIcJIsTOhNk1Gw7MIBYXko5hSsJZjxvAaOW2tZGSVI6UxHhBUFJvsYTxWrUcYPhTe/jUFiZLvRVMWLu3888I+n0roRYjLrWG8bN0hA
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Thu, Sep 22, 2022 at 03:40:53PM +0200, Michal Orzel wrote:
> Script automation/scripts/containerize makes it easy to build Xen within
> predefined containers from gitlab container registry. However, it is
> currently not possible to use it with Arm containers because they are not
> listed in the script. Populate the necessary entries.

FYI, those entry are just helper/shortcut/aliases, you can use any
arbitrary container with the script, it just more annoying.

Your patch here allows to write:
    CONTAINER=unstable-arm64v8 automation/scripts/containerize
but you could write the following instead, for the same result:
    CONTAINER=registry.gitlab.com/xen-project/xen/debian:unstable-arm64v8 
automation/scripts/containerize

I wonder if the script could select the right container base on the
architecture of the host, because "alpine" and "alpine-arm64v8" will not
both work on the same machine. It might be nice to just choose "alpine"
and the script would select the x86 or arm container automagically. Just
an idea, no need to do anything about it.

(patch is fine otherwise, just the patch description is a bit
misleading)

Cheers,

-- 
Anthony PERARD



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.