[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 01/12] xen/arm: add cache coloring initialization


  • To: Wei Chen <Wei.Chen@xxxxxxx>, Carlo Nonato <carlo.nonato@xxxxxxxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Mon, 26 Sep 2022 09:42:42 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xrl+0t4HVCxfUUCLQFD4YZwU3HuGZkCOs0gxsxWPuI8=; b=EkuniNpaJaRC8VRBQQQv8fOLY2RJ2PcinLZ7+tLVaKi4LTXla7Ne3esnKWcT46SlVumUtMGrQcAuYm4v+0b4xJbpR8EOEEyTV8ScQQhOWWK1LzXl9gT+QeCj5KJs99KUq8CzbHvLVkaQNKhTITn4j1hVD+zFbdvDwouz7LIsSbUJxpPUlDCA/qyZPeX4UtDvtlGxGY0vLzDZsalQ9PJhGSYHG5GqHg5lrHLCTCrvsuSLi3KSeZNB3nd9lsyc6DFbsFk6MG3pyfILjKK53cm8wYY/4QlA/ZlBBdJa4M0MoFZ0varS9sAx6bu2P03Xh2TNDyEmjHdijNti/DvQtE/TLA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=c28lD02pMYbIKtwDFqpdYlccudgLKmaTYqMY6UDXagr5YBSL1tcHJYt89IEyLAkYtliu1J4Vuo54qHUzkZRoip7Dr8TsYBCS1SjbRexRGCBCMV9UM46OAao90S/YO/IhWuygeNS4Ec67SeD5wSw6k+MrVHOJzMxXQ0kFe/zahEhH+wJivCDdP8Isd5Gf4nw7bKcfYMXv4uCdrXho7CH8mfvp8O6/mHVnYWMJHlCwLZj466uCABbxxbFflL7+60dCzJtXzRzHD/kNR8hl8hCjebu/cbMSD9G7BVs+2Tz66VmtHrdCAZg4uDANkWJnEAijG1bLb/UlFUI7pva59uicAw==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: andrew.cooper3@xxxxxxxxxx, george.dunlap@xxxxxxxxxx, julien@xxxxxxx, stefano.stabellini@xxxxxxx, wl@xxxxxxx, marco.solieri@xxxxxxxxxx, andrea.bastoni@xxxxxxxxxxxxxxx, lucmiccio@xxxxxxxxx, Marco Solieri <marco.solieri@xxxxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Mon, 26 Sep 2022 07:42:44 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 26.09.2022 08:20, Wei Chen wrote:
> On 2022/8/26 20:51, Carlo Nonato wrote:
>> --- a/xen/arch/arm/Kconfig
>> +++ b/xen/arch/arm/Kconfig
>> @@ -131,6 +131,22 @@ config ARM64_BTI
>>        Branch Target Identification support.
>>        This feature is not supported in Xen.
>>   
>> +config CACHE_COLORING
>> +    bool "Last Level Cache (LLC) coloring" if EXPERT
>> +    default n

No need for this line, btw.

>> +    depends on ARM_64
>> +
>> +config MAX_CACHE_COLORS
>> +    int "Maximum number of cache colors"
>> +    default 128
>> +    range 0 65536
> 
> Just curious. Why select 128 as default vaule here? Is it a classic 
> implmenntation for Arm64 cache? And the same question for the upper 
> bound 65536.

Going beyond that: What is the meaning of the user picking 0 here?
And isn't 1 merely mapping to the allocator we have, i.e. the
CACHE_COLORING=n case? IOW shouldn't the lowe bound of the range
be (at least) 2?

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.