[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 01/10] automation: Use custom build jobs when extra config options are needed
- To: Michal Orzel <michal.orzel@xxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Mon, 26 Sep 2022 12:03:37 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Z353RQmBsJZvD+7Y24OQQ3dFENhjfSi0Baxvw3VHwJs=; b=C1tAalE/xTV1wtXXehLQncn/p3iUj7zuHUHjFxt0N9QsdWuP74vQO0nMXxxkB80Sc98P9myZDmW1sBY8RrVYzJKtRTj8RjryhIf2Vre2CJr33uBirUpfk9SgU5+mzh+SovmP+bFx5XF2HFUEpq7VEfUyqjEVZgZa8Ee1kM4CbxCJVaQMCPoChI4YD+nlxQhWaCG3TzaZcutXD242lBDCGZXZhaXs+mdNAIksNTN0b8cjm7NTHEIZnFauc12DZjvOzl0zSsrTerdtW5ApckHbiKCBghkwNCOpPSY+7v0RFYP2U+RmopJhImyZBKlg9+XfyVWl3NfCGKVTtiwa6WDePw==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Z353RQmBsJZvD+7Y24OQQ3dFENhjfSi0Baxvw3VHwJs=; b=hpPhbGUoEjO26EcCtMgk/7R19yqmmY4FBJBFMpdu1IoS3R0P8T5ymroyGlQAmAkJwAtRf0upsrLEW1LIos9L632K2xwxMhFZh0RbslK1EEpn0r/QKBpw2S9ETIJ6KTewxLVJ3m23Ep1RQWdYZNVtLQKaAew9PZE/q4k0XOyI9tw/x8OlsLAnG9FVEvIwk0GB/+7TvB4K7Q5q0WUN+CYXDXfPL2qemTEqIROJKRvtElNtnL16K/QFRdtFIlpRcZfsWqPavceFkvRbHDEhX8NY7eSaYT2ykYYbLRCz6DEn/XhwqkfNM8iGf+qW68T052niJ1O+WTHqEbN6q+O8YIICqQ==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=moGg1uJruGLb7ZUfQaETGJljtmskuUjfE1dYwek8xMq3wy0c9qq6YE01KhCmtv56c4NLTP25VKog+MSdEv4Vi5q/n7rKsTVHBcqlrM9xs0ci9k/oAfb2q7BXcQwvYg1rc2aYFZON22ITlryWTHVuxzZx3vv9JjZL4VLyE0GFUTesOBLX5IgzbTUz0tDMHkVvibbBTgeZ4dmSb4ye1WYgGv1bVA5fFuWtIHpHS8n1K1WiFI3fsHPtuEh8aD4ksuPRGyBDuuyzNnUifPHTur5zGGDyQ2H17ALYBzyN6Q+nIHtsX+vM1XJ1+ludXyv8iI/Pt2YCrwBr5Y+JfjywTbnSlg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bvg+3NhRFE0ym9jBO2gaRsXuOeR60Wnvp/Jhbnd3h45m2EN/T/tLrD8Koix7FFQI8MPobPDLrndmLLHZckvW7iRF12Lp+FMoWHepdJt8QD7bya83jdpThTc4FrqKQELV9DCKyMHUM6/ow86I42ENEIsBGCRzCqviR13pTV2lsGX1XAr2VYGd0t+ugwRjYlQ+FI/BMybq7QtxJHDGQxLzVyGDr2VOhJfvEHlbM5YB4lobG+EjRiNRxiRTkXXm5sMLjkBYopPJqEjZK0/7rq9Zgzlm7y4e8jdLAvaFLFaV/D2CBNGHu/+8tbQDbvQP35X4wRR4SKI9gZ3d2eyIl4Zhqw==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Xen development discussion <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Doug Goldstein <cardoe@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>
- Delivery-date: Mon, 26 Sep 2022 12:03:48 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHY0ZfkIABcS0GbDEawZdF7FSr8n63xnNMA
- Thread-topic: [PATCH v2 01/10] automation: Use custom build jobs when extra config options are needed
> On 26 Sep 2022, at 12:04, Michal Orzel <michal.orzel@xxxxxxx> wrote:
>
> Currently, all the arm64 defconfig build jobs, regardless of the
> container used, end up building Xen with the extra config options
> specified in the main build script (e.g. CONFIG_EXPERT,
> CONFIG_STATIC_MEMORY). Because these options are only needed for
> specific test jobs, the current behavior of the CI is incorrect
> as we add the extra options to all the defconfig builds. This means
> that on arm64 there is not a single job performing proper defconfig build.
>
> To fix this issue, add custom build jobs each time there is a need for
> building Xen with additional config options. Introduce EXTRA_XEN_CONFIG
> variable to be used by these jobs to store the required options. This
> variable will be then read by the main build script to modify the .config
> file. This will also help users to understand what is needed to run specific
> test.
>
> Signed-off-by: Michal Orzel <michal.orzel@xxxxxxx>
> ---
> This patch is supposed to be merged for 4.17. The release manager agreed
> on that.
>
> Changes in v2:
> - replace [ with [[ to be consistent with other ifs in build script
> ---
Hi Michal,
This looks good to me
Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>
|
