Re: [PATCH v3 07/10] x86/mtrr: simplify mtrr_bp_init()

[Borislav Petkov <bp@xxxxxxxxx>]

On Thu, Sep 08, 2022 at 10:49:11AM +0200, Juergen Gross wrote:
> diff --git a/arch/x86/kernel/cpu/mtrr/mtrr.c b/arch/x86/kernel/cpu/mtrr/mtrr.c
> index 9609a0d235f8..956838bb4481 100644
> --- a/arch/x86/kernel/cpu/mtrr/mtrr.c
> +++ b/arch/x86/kernel/cpu/mtrr/mtrr.c
> @@ -761,13 +761,10 @@ void __init mtrr_bp_init(void)
>                       mtrr_enabled = get_mtrr_state();
>  
>                       if (mtrr_enabled) {
> -                             mtrr_bp_pat_init();
>                               cache_generic |= CACHE_GENERIC_MTRR |
>                                                CACHE_GENERIC_PAT;
> -                     }
> -
> -                     if (mtrr_cleanup(phys_addr)) {
> -                             changed_by_mtrr_cleanup = 1;
> +                             changed_by_mtrr_cleanup =
> +                                     mtrr_cleanup(phys_addr);

Just let those lines stick out.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette