[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[4.17?] Re: [PATCH] x86/NUMA: correct memnode_shift calculation for single node system
- To: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Henry Wang <Henry.Wang@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 28 Sep 2022 14:19:32 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oNlty5GSGJXEwlDKKrNA66z9NHQdWfa/G8QT3SLNiZg=; b=jtv5eMi2gSqFop3/+MD0/GWLQxT98rmiG4zESBFJHimipUHGG0Z2K0PuWlAhasXCOH/68wFNhY9kQ7qNKR3tOZnkEAhrrWmfXgIIepd1B+EQnUkXLz2gexBbQEAl15uQTGgyIyxg+kG4vspMsmSUOhJcLxnOuTDL2kQaS3/DMXTEFt5xzRZq/r/Rn5ieZ9D5m4ZnqSawP6jTUuWxJ53uCDFkj55QlfmTc+L95KsYuFSAbGl+BnW4gKR0NYIqcHgXnr8MHNFZMxEVwURwGiwbev8YytPSnemUOwdsF5IbmRNC+f28xBUJ5vk2aRshxR15T3xaEcm4AhKfQVBnRAl0Yg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=asVf65sdeDK7hWo3DYozk5OWQHr4Jzs91yXzmA0uZfDLPd3v60eAZxS/ky/QWhYp1qwC1O6gsIJxjK50GzqYFgB6Jo1sY4s2ywLVNjNCSHxgFZzDLmg50moY6OFchW6tmXUtd9CRg964r8zoe7Z/gPVj3VlHIqDjbKuA/QOsIXqb52CbMHQ6pOz8el3JRQdImVrtUy6eiJnREPatpV1/92+fUIlJdoIrgbCQF95mpXrhpCLtl5hcAa9HZYGhTFtUeSQlmapZOco+oYJ0f9bHHa6PthsKv1V/UJRbdJnAKaCJDM0IkbnafZJFI+2iFL6z6mr5AxYSTcYZCjDcyrzVdA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Wed, 28 Sep 2022 12:19:44 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 27.09.2022 18:08, Jan Beulich wrote:
> On 27.09.2022 17:53, Roger Pau Monné wrote:
>> On Tue, Sep 27, 2022 at 04:15:19PM +0200, Jan Beulich wrote:
>>> @@ -127,7 +128,7 @@ static int __init extract_lsb_from_nodes
>>> if ( spdx >= epdx )
>>> continue;
>>> bitfield |= spdx;
>>> - nodes_used++;
>>> + nodes_used += i == 0 || !nodeids || nodeids[i - 1] != nodeids[i];
>>
>> I think I would also prefer the `if ( ... ) nodes_used++;` form, as
>> it's clearer.
>
> Okay, will switch then. This isn't for 4.17 anyway (I think), so
> there's no rush.
Actually I'm not so sure anymore as to 4.17 - we're in feature freeze until
the end of the week, not in code freeze. So I guess this (and the other two
related patches, provided they would get acked) ought to still be eligible.
I guess I'll give it a day for objections to surface, but otherwise commit
v2 perhaps during the afternoon tomorrow.
Jan
|
