[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

For 4.17 (was: Re: [PATCH v3 0/2] Move calls to memory_type_changed())


  • To: Jan Beulich <jbeulich@xxxxxxxx>, Henry Wang <Henry.Wang@xxxxxxx>
  • From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Date: Thu, 29 Sep 2022 12:58:24 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7psNnl26cukPzWtA35vTcODbt1tXfttRr4illCx02fQ=; b=TuYdGM2/lmhe4uzc+nrkhhQF5af0c+xI8AN4TTzl/IDM14hx/peXRwCpSZtcH0Fg91/KvFFaw4wiyi6P9FoPrcH3hUcKAs6QDIJhuFGcRolWMXMB0wjUsN0J/oLu9i4qqxDVgMbsjrKK9xyISBit0M4eSSRdI1rlGZd+81VCIWA1Q5lxH/32Kt04HGoXzQqOjDjBEHZqRHyzkW//lzyJcsKh1xV4BBIuN06l7IsyQF83IaVAnbqYvFcR7TIt+eoxzRn/CSpKRdWskn0up2BkduaTTCb/UZZW9mMCC9sY3t2/aUfMF28vtTqLfrFeeDbJxcggqnFov4IOPsMl8mnAQg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=acSnkaCl+cBAqFlhqdweU94J83H8l6KfBAAKl5lVQBXbXeq05rrKY8nYw6HshRy+mr98s/Y5p+UabtPpvrxnIj+HrfJexpLx1EjZZR4ISOhjXJYPw1Mx/1OMvMoqAOmu+vT567CkC3Hr/T1UYhFR17BBP5/a75qx97mtLpOsgT4GtMiz9ZxuDO4Xx7lCiDQ5MJdGH4/UWueX//sWNMcS0PhLf4RGi8gnPosAdRA1kCCpZzebOjxnl7T4mp2WNDnk2eqikn7L7IQV1g3KconwC5Oaq7n2kQh+QGZN5Bvs3DOUuEXn0lau9QSHzxw9BsTCW6PPLSWD37Lc1CKkXnywPw==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
  • Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Jun Nakajima <jun.nakajima@xxxxxxxxx>, Kevin Tian <kevin.tian@xxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Thu, 29 Sep 2022 10:58:41 +0000
  • Ironport-data: A9a23:OdNPZKLfdVfP3dP8FE//H55ynAfxRhNe8xJyq0mlJ83Iv2s+/A1BKwYKpYUu6wEK28F0isbSNJTe5bO4tq4DKQk6O1Tqd/fT+mdqRDR5wIJWCaTeLwqnoycapJ0iSKZVb2rAfaWu9KkeU+fDGD3tFp/TPPaVi+VhRnh4nW8rvlQqf/ZyEmblA1pKVRxjCDgGs/hbRgLEa49pPI71GfCwoWfv8HGGFCItA231CZ/l+I9KPGSX4YXfB18jaoIbcXCsIMHzKwzBuO0J+jRy8msvrqRtHgtioRJh7iPM7byBYpaJbt7bKKhvll3MhkxYicpFIoDk1kAmORwxSef1qmZ3/wR0Z0vVRawuJBxkS52AbSuuEmAC9nG1Iv1lT3vsvEG8R1SeAuqaMOHqDvfqDsB4PYXXx+YWVAjQ6eC84P0n4EBNZGELd1isuLHutjAJL7IcaL+a3BJ4nN+dv4Eqq+d9u2tk7r4yqVJn/iKaUkF1bUQH+io/7tSM5JJN0hYMMalEcSf9QjgJ0Bl2lLJz1FGhFXE5+KMZ9aNTqGhXCKPEdV+5WhuR88bCxEJwh9zYmfmnRBQPVdGkeaCf9rWwhYQ/9ZpR4sAh8XmjpdLoIkYjZ6dRV56R/hxUacWIKL4YbpZU+XJ8cGo3ocltbvyQcgcpzq+x9qyArBEqyAoO2XCbr6uM9fFmrR1woZfKRtGxHZEt+JNk1piBDQoohpYkh0nWlgFbYv/QqKk5z1prasRutI81eE6ulYNA2nH+3ImTmVujDl936dFPdjk/v50/MxokeS5zBYKzpNgRM/9nSID2VyAm/xsHEf6MGcXlvFkcwVvnZY8K/Abv9vR1JXgQyDo6wuSMxi1PJTrdJthRKDAs5BMeFgUj0m+IXS+UevZoRp8JbWlpypTO2PLPZqgSXeR6CBWEDdDQSoi2/mxejh5+evoKVFe2XDO8VVeQej/SgBhwhxxdZTSnupkMF29V2JakGbusCAIaTc4sAKl1HCbWrj/o0E8rdvCKRzQ6QrSu1+PFUUVMmrnwU3WOj6kG/BCoqqv82yx+YSUlGULyVRK+qpEsT/da1O8JEextDoCMISbIaeTKlaJwvTjQwXkyhQ/k+ldtoZ2iRohSqk1Wz3UUNEMjK5GNKGFNSvSQ/Ivb+zXYsgWarG/f8dgauD3WOqIC5ammUNU2Y2T590Rl5mdjKfARQIrs6P1OPCoEgTMaWi6ONcV73mdrE5YE0NL9SlkVl7KzuWDSO4Hf0Oa3yG1Tm0oeOQEAG9YerrdfIRlikmQUM5xxC2z8FaS1rm0c5HETVUs7ifLa/lMYa+E/uH6pWEoAT7QOpL+l4oEMaxbw5FsGX4rwoNZXmWjviNm5S+ilO3A+djAGmL9/vK8/Apy6ew7OWfeCrfalfSc58NU2ltYGsz1TcstblBFaEBqEpocIRXtYpacNTfTstR7otZSKCM7qtsXHhHj8E3gZeSQzEB/DXWKTdLJ8Jq7B5CIYAkdwUzWjMMSozQMy4JtPcPtEvPf9kHqSP+P+7YndZV9A+TizLz+3oWxge4yJYhtw9CsNG7Y7pitOFS1WICByep037QoBuv+QmlmBjBOGjmsW+6qNCbl9iIDtQgGrllsIgPpNWAGTb4x9R5rI+d+KTW1648F12auz1GG1mU+i3Ou5Vw7N/d2PG79ckN8n4x8z6UuyV8xDxm6YjyLU25t8mWtV+/SjXfHCyJIZUs8e3ywxFPm5CSIkHsnmXi5SjIX3s/xtATVBGD4qM0hNU3XoCTD2i6qJa+IKWyoQKY+z3CEvRQQII00qLpDkAtYclURwr0x4R8X9AoefiA3yvdpNrTVffeU6hUWcYU1b9gPmRe0Qjv8Xy24maUx/yaQDb2J2gh5XIlHd3P2vsSU87Q722jyEm6mDa5R9qKKvC4dD4AKEUHzXG9wDhSfpUsHYGqJNpLSzFSGnalwSfiJvjTtuaUr144dtos+g9iLIR+wjCmE9k32qXMy420LmWlm8sJUdQVa2f3jMD/DRqAjf+zIT5oQjJERz+OlvuKMiFvL/b+WU47caT70l/akS0WHQxR4UY3NBcYD+Sjwa2OVE3pN7L/HblIj0pG4oHLZmVUxv05XqwkYj8EcQJ/cYOKiG9JbxclEghGyp2ExBY44Rw2PE5JQp83Qh+A+McT4s1Y5iT6dkGXswInX/H/PJwr033RADY4uTICLidAsjZqpW2980VRkLmLuiys2D9EMZej7A3uy4orXNmjrYh/j99LIj5xYohsuyEpny15YhqvzkfjRIBZ5FrUZxrnKmhG1hQ0LXKsnV19tXg4fn0Ceds9j9b0vR7Ihjd7YbO7axF82bDfMlaMERxqNSh4/Sl539IOUys2MoT0NhvknhChno/AMu7KkfotzVMrEkuY0UyFfM7VdrmvDLLd3Zqtt/mKIEw861T8rfCEdCo+mhMvQWHVYQ1YDje1js8IAl+XL2d7BsqCi0mDQKe49QtRUrRicPwQWxEf+vU/FCDsuMF0u99oohmN1FroxfzKl9NZklcGO7ZBCJYqDyFznZs6/zgADiGWbZX6EQcn8p+QlkSACUCocYzqzw+StgCDHu1ztUEtkven88oEsoY25Adzk4+JlOTuknuv1kvjo57Mr4tLVQMTsbI53GQAFc7KBhOseg3zNMTtSMGzN6tuEdfsgftdv9471nzhxU5v1ZFrD7Zl2lbAbwQ1um4mX8V6pxerwcoQsIzcv8wQuBWOFXgu5NfV3HuO2a4cVpHK2KIITwRf3G52HDIcrAQxa5DcBVVRCc9/3orUYASTGlPvcwANWw4wxsGeSV0ABzrYpD7GOie2BIhUigueDD+nHEIA==
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Thu, Sep 29, 2022 at 12:14:10PM +0200, Jan Beulich wrote:
> On 28.09.2022 16:11, Roger Pau Monne wrote:
> > The current calls to memory_type_changed() are wider than strictly
> > necessary.  Move them inside the iocap handlers and also limit to only
> > issue them when required.
> > 
> > I would really like to get some feedback on the Arm change, since this
> > is now a prereq for the actual fix.
> > 
> > Thanks, Roger.
> > 
> > Roger Pau Monne (2):
> >   arm/vgic: drop const attribute from gic_iomem_deny_access()
> >   x86/ept: limit calls to memory_type_changed()
> 
> Are there intentions for having these on 4.17?

I wasn't sure.  From XenServer PoV it's certainly a bug fix,
otherwise some workloads related to GPU passthrough are simply too
slow to be usable.

I would certainly be fine with it making it's way into 4.17, let me
add Henry:

Cons:
 - Changes the number of issued memory_type_changed(), so there's a
   risk I misplaced some of the conditions and we end up with wrong
   cache types in the guest p2m due to missing memory_type_changed()
   calls.  That however won't affect Xen itself, just the guest.

Pros:
 - Removes unneeded memory_type_changed(), thus making some operations
   faster.  It's effect it's greatly dependent on using a set of
   hypercalls against a domain, which doesn't seem common in upstream.
   It's possible other products based on Xen apart from XenServer will
   also see an speedup as a result.

Thanks, Roger.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.