[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-4.17] Build: Drop -no-pie from EMBEDDED_EXTRA_CFLAGS
- To: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 4 Oct 2022 14:28:29 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tpGeEeVraeJSWAt2zRJbWgXPtx6MwofautsqUtDuqMg=; b=lIXcYhIVWzpha0HLBrmJb4MCYPYpfIIigf05Z5wTyMywjFTeO8Qv7XkZgayhN1HbDPv0FdKR0dmxZgDPFYz2Oh1uVEInI+uIE3CQCqSJRLMgy8MVkWRnY73c+bw1Y+gkSQ84aVv9PD+7CEy4VkVWa0kXQDR8aX+ZrX8/p5FT5/PMvnGOhoQ+JJCOzUiJnSEAa6Q1aUY2wl7cg3UykF7AU6NII+/FIrk5KFGM8dSJCSpjHDrvBD5ezlLSem/Fc3Z0f4B4V6Ze9XulouMSdw31LyDuT7QbXP0Z7I7EjOBwIiaElEYEMsWx2earRmJAOuSdhGcpM+plhrekcDik9+bEaA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IinflnMNCNUZY0HFtoIsAbIOkGNmkH9VB9a19vFHHo2e8LM3SRjliNRDpoyr7seMsfzsGob+31NubGvFc/B/+PzkYTZEAKC6YFJRvXyN5kE2DuYTzd1aYm3KOSfXxnGO5+B2uF5F/KbOKFG0whhF4ZsR/IMUqWU2PFTmmlH0JEoKdgA0qd1GaHZcnmMJccC5VZ+nPefZxZCZ1viBN7hofYxgTsJO17eT4qlz4UQAS8aW2c8IA8ipOkjXI0QfJwq4FOzKRX6ztbwjdrZrm+0sBtyUKKPq13YrlP0Q2amoiR/ETf9GhnFPBCkZl3nx5n4GFim0Xj+jksB9lex7jxccQA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: George Dunlap <George.Dunlap@xxxxxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Julien Grall <julien@xxxxxxx>, Henry Wang <Henry.Wang@xxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 04 Oct 2022 12:28:47 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 03.10.2022 13:20, Andrew Cooper wrote:
> On 29/09/2022 11:07, Jan Beulich wrote:
>> On 27.09.2022 17:47, Andrew Cooper wrote:
>>> This breaks all Clang builds, as demostrated by Gitlab CI.
>>>
>>> Contrary to the description in ecd6b9759919, -no-pie is not even an option
>>> passed to the linker. GCC's actual behaviour is to inhibit the passing of
>>> -pie to the linker, as well as selecting different cr0 artefacts to be
>>> linked.
>>>
>>> EMBEDDED_EXTRA_CFLAGS is not used for $(CC)-doing-linking, and not liable to
>>> gain such a usecase.
>> Since it was largely unavoidable for me to notice this while putting
>> together the two XTF patches just sent - isn't the current way of using
>> -no-pie there bogus then as well?
>
> Hmm, it is now. In the past, XTF did use $(CC) for linking, but that is
> not the case now. I'll drop it.
I notice you've dropped it without replacement - don't you want -fno-pie in
its place?
Jan
|
