[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH][4.17] EFI: don't convert memory marked for runtime use to ordinary RAM
- To: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 4 Oct 2022 17:58:50 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=o/hKQCZfc6IPdqQX0GfU4K8iCst/ETj/mfZO+u4QQkI=; b=gRUGyBZDDPYbL4QIz7ZTPhjhMv9NentxgAN3TOtSBL1vSFBKQb0tr9QpU+gUdoFoOg0M/Jiazjv/NSET/S9vg9wTIV9ZFAM6oNUxtV/THBa46LmUCtqn/U9s93uUOq7z3+zc7lFJFl4hE4wyv5oTqIXdZFnA57xEjVxQszfedGkrwKjEPhB+Xfsf+YvaunjaITV7SegKrksSFpadp4mRKBIhkCLV35oliOy2+b2V0UjLVxey69WZ8TDhPyi8dE512DgkgOKqP4Whl5UXrbZdJAqICFBPhuNoi8jpHHaB5MJ4Gkrv9gbwO0BfA+o2r0M+4MP7O7hBgP/zJem3I7syvg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZpTt5voV+nALZm0Exe8CT+CzAQFaQf4sxrCuQBoccQD+qK/VKJ87eqLaUPmQ9cnXQZn1nx31gC99TWcRCeX+8Mo7Saobo6dONc8+dIRGJo/sF1lithCdpguNWxi8W515kvhe9JsRztHyv3CITwtz4uEixdsqz6UUEret+7CxoE+RVCmTwWdviBuX4L8EW0KcD30SbdcjkqtU5n4e6BTW0d0Lpr5h2RpeV352Y7Z0z8squlUhyrExKUrqaos0MTDoSpCbIGxP0PdxgBJALqE/FBP7Trsi+2s9X1D+v3yPbeTILZF0L0Xe/hlvLXHxMRFOpyDBXJMXiAYAwA4nsaYh/g==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>, Henry Wang <Henry.Wang@xxxxxxx>
- Delivery-date: Tue, 04 Oct 2022 15:58:59 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 30.09.2022 14:51, Bertrand Marquis wrote:
>> On 30 Sep 2022, at 09:50, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>>
>> efi_init_memory() in both relevant places is treating EFI_MEMORY_RUNTIME
>> higher priority than the type of the range. To avoid accessing memory at
>> runtime which was re-used for other purposes, make
>> efi_arch_process_memory_map() follow suit. While on x86 in theory the
>> same would apply to EfiACPIReclaimMemory, we don't actually "reclaim"
>> E820_ACPI memory there and hence that type's handling can be left alone.
>>
>> Fixes: bf6501a62e80 ("x86-64: EFI boot code")
>> Fixes: facac0af87ef ("x86-64: EFI runtime code")
>> Fixes: 6d70ea10d49f ("Add ARM EFI boot support")
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>
> Reviewed-by: Bertrand Marquis <bertrand.marquis@xxxxxxx> #arm
Thanks. However ...
>> ---
>> Partly RFC for Arm, for two reasons:
>>
>> On Arm I question the conversion of EfiACPIReclaimMemory, in two ways:
>> For one like on x86 such ranges would likely better be retained, as Dom0
>> may (will?) have a need to look at tables placed there. Plus converting
>> such ranges to RAM even if EFI_MEMORY_WB is not set looks suspicious to
>> me as well. I'd be inclined to make the latter adjustment right here
>> (while the other change probably would better be separate, if there
>> aren't actually reasons for the present behavior).
... any views on this WB aspect at least (also Stefano or Julien)? Would be
good to know before I send v2.
Jan
|
