[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH 19/19] Fix misleading indentation gcc warning


  • To: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Mykyta Poturai <Mykyta_Poturai@xxxxxxxx>
  • Date: Fri, 7 Oct 2022 10:32:51 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LofU4NA3DawFyk2dVbhjW4yKNwCVyZvZ66lYuYxwLoI=; b=JMtMioPJe1B03XUJOZNENMofJKf5wCl6jBnIabmeqEfolCiHOAmzUXc/AYhtWBndToQn0QjfVCbOewqczkDS+OcsVlRS+waKPDbKwJ5nbO1MBu0SdyjsyX6OLVFsmk4ogNIipOKooZkUzcMbTIaFseXKevGb19BYuTsNaB0MFbiSZFebDu8YEB/4VzqGBprdBdynYjiFRCFrhnHZmGuQSsDITuXSs+ykCO06mIh16uFirlhZOdRhH53JjxQsHyYWZojO+T3lwxZmPcRtJZo15P/4gdoRT0hiESs0kHmPpLrAJ02LRYkw1x5G20lsc/YKGf1UumLVcnil9VmvH+iu3w==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CWT3s26VSGqyXcms9St4R/XUityLrInIk5MZlN3XZz10iqoT3hVanldJP4gQ0GkLvXUuITPwyQUN/cHDgI9inhzLJmP+t5C4Wfrj7aqs4/ebJBrWfJjn5xtbr8M24BDyHiru4G+Yjub4fUx3NCj9boschDcZHCCjbSSDB5plbk7Ecc1N+dBmPezQHiZ1YklXhNTtkUG/M89idIN05HC7lBBptNHFPHzq9zMx3riv27ctdm7yzzXsyMH0REDY9H3/QQieGnLdwCtSNwl5jjdm0SgjL/E6oWNNcGmQF2oyN8ZB6dV7VZTMp0Q4K1XAhn/W4JEfspd4s8h/uw5qqXNNLQ==
  • Cc: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>
  • Delivery-date: Fri, 07 Oct 2022 10:35:05 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHY2jgnAfaSu/bn4UuiKd5XD6+qwQ==
  • Thread-topic: [PATCH 19/19] Fix misleading indentation gcc warning

From: Oleksandr Andrushchenko <oleksandr_andrushchenko@xxxxxxxx>

percpu.c: In function 'cpu_percpu_callback':
percpu.c:61:7: error: this 'if' clause does not guard... 
[-Werror=misleading-indentation]
       if ( system_state != SYS_STATE_resume )
       ^~
percpu.c:63:9: note: ...this statement, but the latter is misleadingly indented 
as if it were guarded by the 'if'
         break;
         ^~~~~
percpu.c:67:7: error: this 'if' clause does not guard... 
[-Werror=misleading-indentation]
       if ( system_state != SYS_STATE_suspend )
       ^~
percpu.c:69:9: note: ...this statement, but the latter is misleadingly indented 
as if it were guarded by the 'if'
         break;
         ^~~~~

Fixes: c3109b76d967 ("xen: don't free percpu areas during suspend")

Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@xxxxxxxx>
---
 xen/arch/arm/percpu.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/xen/arch/arm/percpu.c b/xen/arch/arm/percpu.c
index 0642705544..9eab1e6d7c 100644
--- a/xen/arch/arm/percpu.c
+++ b/xen/arch/arm/percpu.c
@@ -60,13 +60,13 @@ static int cpu_percpu_callback(
     case CPU_UP_PREPARE:
       if ( system_state != SYS_STATE_resume )
         rc = init_percpu_area(cpu);
-        break;
+      break;
     case CPU_UP_CANCELED:
     case CPU_DEAD:
     case CPU_RESUME_FAILED:
       if ( system_state != SYS_STATE_suspend )
         free_percpu_area(cpu);
-        break;
+      break;
     default:
         break;
     }
-- 
2.37.1



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.