[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 0/9] gnttab: further work from XSA-380 / -382 context


  • To: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Fri, 7 Oct 2022 15:49:50 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=n1geE7tFZULpCd4gG2I2wIrr0GVOAo3LXIf39DALJ1Q=; b=OSqN8/n/boBVwG+T17xHnYSxpVwG3HoGvk1oaADfhVdGVgGk+VNuelPmUCTQ/NDzYz2mTbWDHsw/wsSpCj0B8E4GudA/NyE+Z09tjzrEIf3vTor2xv9h7kr86K7J6BDmstLXuBTeOCjV4s661BjfpiTz1xDUtMwEg996rwAay6Yjznpft7krP3lAoR/gsd6/oiOSFHA1WsGrMZ+vWS6ERfRkzJl4OJbW6A7OIFipd2b4AhzWmeS2j2pfrBTJWcaQ85zAN+v6pzgSP5jHyI362XuGb8elM9CfbCxDZaLfINkWFIop88I/J/T3qBLSisxzw2RecGGvlhzMo5nFG6fzIw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=U/7uQhADUEaCqTGDclxtDpKfQSG9bu/Klxe9LUV8B/m4J09+FqVbm9Ho1iCRWItiVO246Sj+smZab1lOlE8pCUH4lpNeWbIugBwu3COfpbq3AvvxlGCnNr42HSDykbsdKwTMIBHyLGLmRUChAhWuEvUZ+klw1iBX1REGfWEiw3OMLZX4a7+nRNi4wCz4QoOSMN8SHnJHskMshtifZx7+81pCyM7v3zh/MmbcPv5ugQUJ35dJnh4u4zM5F0GOht1HiQjHUtpRGCwk233CI59qqAzgBMnrXP0sJCZG3G14ud2z3RBxnJbZAN6rQk70j2S/TXyxaBjMkBYzHFQKcGwLvA==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
  • Delivery-date: Fri, 07 Oct 2022 13:50:01 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 26.08.2021 12:06, Jan Beulich wrote:
> The first four patches can be attributed to the former, the last four
> patches to the latter. The middle patch had been submitted standalone
> before, has a suitable Reviewed-by tag, but also has an objection by
> Andrew pending, which unfortunately has lead to this patch now being
> stuck. Short of Andrew being willing to settle the disagreement more
> with Julien than with me (although I'm on Julien's side), I have no
> idea what to do here.
> 
> There's probably not much interrelation between the patches, so they
> can perhaps go in about any order.
> 
> 1: defer allocation of maptrack frames table
> 2: drop a redundant expression from gnttab_release_mappings()
> 3: fold recurring is_iomem_page()
> 4: drop GNTMAP_can_fail
> 5: defer allocation of status frame tracking array

Just to make "official" what I've said in the course of the resource
management discussion at the event in Cambridge: I'm withdrawing 1
and 5, in the expectation that eager/lazy allocation of resources
will become a property to be honored uniformly for a guest. With 2,
3, 4, and 6 already having gone in, it would still be nice to
(finally) have feedback on ...

> 6: check handle early in gnttab_get_status_frames()
> 7: no need to translate handle for gnttab_get_status_frames()
> 8: bail from GFN-storing loops early in case of error
> 9: don't silently truncate GFNs in compat setup-table handling

... the remaining three - even if these aren't really 4.17 candidates
anymore at this point.

Thanks, Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.