[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 1/4] Add SPDX to CODING_STYLE





On 09/10/2022 10:33, Julien Grall wrote:
Hi Stefano,

On 08/10/2022 01:15, Stefano Stabellini wrote:
From: Stefano Stabellini <stefano.stabellini@xxxxxxx>

Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxx>
---
  CODING_STYLE | 10 ++++++++++
  1 file changed, 10 insertions(+)

diff --git a/CODING_STYLE b/CODING_STYLE
index 3386ee1d90..5faf274b3a 100644
--- a/CODING_STYLE
+++ b/CODING_STYLE
@@ -14,6 +14,16 @@ explicitly (e.g. tools/libxl/CODING_STYLE) but often implicitly (Linux
  coding style is fairly common). In general you should copy the style
  of the surrounding code. If you are unsure please ask.
+SPDX
+----
+
+New files should start with a single-line SPDX comment to express the
+license, e.g.:
+
+/* SPDX-License-Identifier: GPL-2.0 */
+
+See LICENSES/ for a list of licenses and SPDX tags currently used.

This directory doesn't yet exist. As Jan wrote in v2, this should be populated first (i.e. patch #2 should be before patch #1).

Actually, even patch #4 should be to avoid temporary conflicting information between CODING_STYLE and CONTRIBUTING.

Cheers,

--
Julien Grall



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.