[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] Use EfiACPIReclaimMemory for ESRT
- To: Demi Marie Obenour <demi@xxxxxxxxxxxxxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 11 Oct 2022 11:59:01 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aRFtWcXR6mreWH8ttueUTWqNt+dyzYd70iitrGS0ev8=; b=VACyDG7Cy32rLETsGLfkMNXZaBckyEVpeWlh5ynyLM9TpZO5kyShm+kmHcM9afV9u5mF2gIjrls6R3feCwoeBB41fEaA/AgXYSMuQaoO2rN9foVByaS8z6EkovJRAuIx5VsSWRH5D9CMp4tLJlO+TxkWsMEnxYSU7eFGBCfdCWBnB/Ihg2P5ENktrJ688B7KJvWKXvpB+v9eCYb15xtAjW2XHI+q7uMjabQMMB/m9C79sdSB04VG10iZVTJ84navQpJ+ieOcLfddLa20EIAtbWE5JlvZULAadeZo69FWW6tyVfyqBuFkPj7pzciT4+hBWNuFeVm/4bXkZpqggEDgag==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=i4YhkdpI87yQw3JVFCrmChaACLq/5p6s/CwwfJKF1Kazz6Svw10XQfeJYybyrdpScCflAVsZg/ew4XKVdgKF0+4Z/l0G3x0Q3X4+64BLUzOsGnznbxo1uyQohmFC7ZO+twRD69aH394HHdvNunXyOToYXHhi5t3u9azq7BKSkgbyxmUBzN1LvPcrRg8ZIclKtA1l8DnTMRRdXdGdCNZKHZVNw4UrPu5dMxb8Nroqzoah7ZwTeODMzASIzB0SiW7dwK2aiXnXVg2KL4XjzJNNUBOvDzTXS5qMXivzoVIY0IHjUOGUWJnOV1bSJSxe6FNipfyjtUij8avXl+n7woFJsw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Ard Biesheuval <ardb@xxxxxxxxxx>, Xen developer discussion <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 11 Oct 2022 09:59:14 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 11.10.2022 05:42, Demi Marie Obenour wrote:
> A previous patch tried to get Linux to use the ESRT under Xen if it is
> in memory of type EfiRuntimeServicesData. However, this turns out to be
> a bad idea. Ard Biesheuvel pointed out that EfiRuntimeServices* memory
> winds up fragmenting both the EFI page tables and the direct map,
Can this statement please be made describe Xen, not Linux? Aiui at least
the directmap aspect doesn't apply to Xen.
> and
> that EfiACPIReclaimMemory is a much better choice for this purpose.
I think the "better" wants explaining here, without requiring people to
follow ...
> Link:
> https://lists.xenproject.org/archives/html/xen-devel/2022-09/msg01365.html
... this link. Since the code change looks okay to me, I'd be okay to
replace the description with an adjusted one while committing. However,
if you expect the change to go into 4.17, you will want to resubmit
with Henry on Cc:, so he can consider giving the now necessary release-
ack.
Jan
|
