[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH][4.15] libxl/Arm: correct xc_shadow_control() invocation to fix build
- To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Wed, 12 Oct 2022 13:07:33 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AkGbKIG4JPb9t+41eWW+cdl8K3bOYyJ6hqUvvd78PnY=; b=kA6YCLcC97fHFrHKp7epKqUYQr4OfFP6dlqREPPBCulH61NmhZGNPhXYyCoG74cAwkvlQTs+qphNKqclBo4nDqX36OMsS3VdPHYQF/YtrBMWzS8D09m/S3/GNpVshSVcVfR7hNxFu7mPLWqP6Hlwl3dR8+p61Qs3hYS8wcIWm2I7QjIjBzV9OeNTtY3TcgoQGWwKBlYyQsgRXD8wKkQLCF/ZfmkCNBLkuHKN7hdDpQWznOPX6V8igd+6pRRqFheqIh4JisKLPr8vbpPdeE+/QPaBcvccjHyTlopuzh51tnqMPI6bnKbQWcVvcR9B/CCZl8aZNZ9/SIWFErDAUiC1lg==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AkGbKIG4JPb9t+41eWW+cdl8K3bOYyJ6hqUvvd78PnY=; b=Pyb2hJ9N4yK3fL4An/SO22ZoTyG8BmVUkK+riGXNubwWBeVARYQpmHgHeJhTz+sUDWUG/GYtk2qwP0TbVL/q+zxntRAawPjR8vbzAf125UW55yTzdXv0pMYNFSy5x6d7YWfGLaGY6RaxpUWKRbvChfi+3c0SN+TNXlFxNn9rB8o1yYtLaNu5Pdex2j/B1l+NcbXbpfVJfvhENN6adVFBwd/33OcjduI2tikcxe3GtCX/wjUxeCNvZ0AU57RxL8fYmnwfBbm0lOz7T2hHQSInJ4wq9FvV9T8so7BNgcPbRF6uDWEo0HWChc/LYiM2HcN3JaXcf6id3wxR429Y5SQ80g==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=NJlunwqiYToYGUmwn5fDGH8QBc1utnRGsO7+tPnCCiA5hf+gPK44l753Z4USMZWHxw8m8NtBicmfcmB92FtHXnuy1QXzX4O9DOqqU7frfMUx5oJKPmiFBy9bL3gzYXyzEIAEgZH6I8XUmt4piYcs3omkDyfc73soKD2H0YM4h5kV439aD7lKcXPovvLQ9zwU8zDvJ2HbEK8s2xcuquSq+Q2U9sLSDumdMm8mikmDbvopTo1T5uRYtlsP76mtIUouxj4m8WFcisyCwG+cB34vgC+t0g3uN1Nfg0fv+KInzP+7VkGAZmKuT8O9SWPjkfvaY9UAeKZzeW3G0XDLDwhMPQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=R/fnWCzFdAs9cisjKHCD31Z4dSwDLxHPMPYtgFVTxTkoEAOGJaMfOvaSF6tUfFXmCZcdAS5eKUllFN9UVBzyfY+M9BO1e6/3xqWdlp5QnN21TVQsp76xK5O/1wWeBILIAbChnqpVjTlmtjEfzD/ZsDl3PHuXoYEhl7H+WMhAysq1QwKPph54tU0bBp92tWio2BEyDCkq0cbSFz5Aef4Q1aLpv4Iwi+2KdxzfeBWGXOWKK/Cmoc3VQg+2251+QTqvEmlCH+WhjOiUqQ9l/dOl1En2gD+3aqIgt4lHi9nBs7i69zO/9OlB+iCuDx0A5KLp1HCkJxI/M7RrFmEl/6FREQ==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Julien Grall <julien@xxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>
- Delivery-date: Wed, 12 Oct 2022 13:07:51 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHY3jtPuivbdxpwvESMJg2+jrcZsa4Kukrg
- Thread-topic: [PATCH][4.15] libxl/Arm: correct xc_shadow_control() invocation to fix build
Hi Jan,
I thought to send my patch for fixing this issue tomorrow, but since you are
sending...
> -----Original Message-----
> From: Jan Beulich <jbeulich@xxxxxxxx>
> Subject: [PATCH][4.15] libxl/Arm: correct xc_shadow_control() invocation to
> fix build
>
> The backport didn't adapt to the earlier function prototype taking more
> (unused here) arguments.
>
> Fixes: c5215044578e ("xen/arm, libxl: Implement XEN_DOMCTL_shadow_op
> for Arm")
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> ---
> Also applicable to 4.14 and 4.13.
>
> --- a/tools/libs/light/libxl_arm.c
> +++ b/tools/libs/light/libxl_arm.c
> @@ -136,7 +136,7 @@ int libxl__arch_domain_create(libxl__gc *gc,
>
The definition of shadow_mb should also be changed to unsigned long,
and...
> int r = xc_shadow_control(ctx->xch, domid,
> XEN_DOMCTL_SHADOW_OP_SET_ALLOCATION,
> - &shadow_mb, 0);
> + NULL, 0, &shadow_mb, 0, NULL);
> if (r) {
> LOGED(ERROR, domid,
> "Failed to set %u MiB shadow allocation", shadow_mb);
...here should be %lu.
Kind regards,
Henry
|
