[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH 2/2] tools/ocaml/xc: Address ABI issues with physinfo arch flags
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Thu, 13 Oct 2022 02:34:50 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qKapJyO6y/fadcTC42/DuTDcVTUcOS604Lcc9O5P5O8=; b=c9/6Kj7ETZEIC1YccP9zVDWns6PkFuYwcKeBY/4OPcTbO4pReocoQfTEzqPy2drUMzU1BQgVtMspkGxDCBv8R7el8dUB+oL6CSaBS3DewCLR/UBLGBdl4jGkD35K5s31nsAfXpGgekD4eQt0+oNCBoRTx+uOBvrNwgwdQzoZxLgWasfVKdF+3n144IAOyW1kaSzAJnKagYyNjQ2upQuL7Alw164lMQRwis/YiY+39rFvFV6EEZbDOZ/Kow2j9Mp7Lx0logEMttnsDr4r2T1pMx8iliYCCNIpppW2onEXe2dVb8LUcKjYVqLVnGEeOaVDrBV14JSZSS/3E9dKZPpmzg==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qKapJyO6y/fadcTC42/DuTDcVTUcOS604Lcc9O5P5O8=; b=LSPVYTeKi8dL4uxpXtr6pCuYS1sTkpHIKOUx5i2M0p3zpWSdh1/n61HMHycWiirqkV5+0C7qMyKsQ3MphMIGU2KwVQ2HVPkwwwG6xXaaehqAbZo/xd5FAN4CJJD/W638vBWGZLqH4eB4pcciO+4hY9xIwUNkSuQFbWQmZNntRKbwVOXDjjDKom+2TmjsIoMokPjgbM9BGN3ZPzDk7nxxcFRyC6g9GAoN05OrS7VGFjH3qqh83FnGFPWTsTzu01po1s/l7o25KMBTSGgfy39J/qt9HDs4aFe1UNdIXeVx5WhZQRu4BjijQ5iWGoG+hj0Lzu5kCHeqE0t3mw7sVdvaOg==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=ZarkQoaDxyE2/SmiTZH3JIZZOIY6tEWZATInuvtnlyKwRSd8GSgT5qbh/Lh821iqtYk4tHseUXAB+HLqedKzYrWlS8kR5QtbtJVRBN+oTYVgfx3buTYy4CEDKcG/lMlHS5lcgmzekzMFPuzy23Pfw+1WVWycwyhuV5Du7sjmAbe/XW1C9uK6Djf8bDyoF46A1XBwKo4beYEO7ryKUS95Fr2AYFjRnjOK/z3Qinn4zD2NRuE+pO/LX19I/HTyEogHjVNApov+WPZbHULkomlbkYM8qhNWWNowvWY3C2ka98NrpS3PhCu19iC/3JWZ8214UmRxJteqsQ8cOudaBl14Fw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ABZ2jgTRb9vC68mV167Q2q87NYNPUD39/f0poN1JDsVzvzGoTedZGJKixojOJ6TyuaRyHvVc7g5U/vfUNmhKNzj7SbldHb4NnB4+fAiSmms/I95btviefreM/ugF70E8a2k+dgzBK2Y1vyzKyRo+twPNRNzwJX7sNZS7la5Y5/aOqPTHK0Vf0RcR2uk1jM+5e5BACfmqoDSwEGH88hV2EWH4Z65219s48RcDw8WtbzpQD1984alNJJVZlFZm9uvaNdhgCBFSBUcaMWOwkk4Qnsq6NaTxeii8aX2P5izM0k0lFRIX4t7ZythGbhQSjbgZ8J+LYGkG0Cm/gqblAiSdhA==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Christian Lindig <christian.lindig@xxxxxxxxxx>, David Scott <dave@xxxxxxxxxx>, Edwin Torok <edvin.torok@xxxxxxxxxx>, Rob Hoes <Rob.Hoes@xxxxxxxxxx>
- Delivery-date: Thu, 13 Oct 2022 02:35:08 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHY3mggOd+/b8rDG0avfRBy32H2Yq4Lm9Sg
- Thread-topic: [PATCH 2/2] tools/ocaml/xc: Address ABI issues with physinfo arch flags
Hi Andrew,
> -----Original Message-----
> From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Subject: [PATCH 2/2] tools/ocaml/xc: Address ABI issues with physinfo arch
> flags
>
> The current bindings function, but the preexisting
>
> type physinfo_arch_cap_flag =
> | X86 of x86_physinfo_arch_cap_flag
>
> is a special case in the Ocaml type system with an unusual indirection, and
> will break when a second option, e.g. `| ARM of ...` is added.
>
> Also, the position the list is logically wrong. Currently, the types express
> a list of elements which might be an x86 flag or an arm flag (and can
> intermix), whereas what we actually want is either a list of x86 flags, or a
> list of ARM flags (that cannot intermix).
>
> Rework the Ocaml types to avoid the ABI special case and move the list
> primitive, and adjust the C bindings to match.
>
> Fixes: 2ce11ce249a3 ("x86/HVM: allow per-domain usage of hardware
> virtualized APIC")
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Release-acked-by: Henry Wang <Henry.Wang@xxxxxxx>
Kind regards,
Henry
|
