[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 5/5] x86/mwait-idle: make SPR C1 and C1E be independent
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Thu, 13 Oct 2022 14:05:02 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eI1a4d+t/3ANeUKBCLySlGMA/VbFUI2jojanCzs/xv8=; b=Cbwqa17vREkRaMfqXafufHIeuiz2AuetX4RdeQKqYCZX45zcvynsphzgl0BFKpJgrTaMRVyuxj71B2B7iuyLtsYjVZ0XMkLHrDsq73NI7C1Th0ws2p8gXGYVH17ke8oh5jJJEI/h3unMle66mD4zkLGkNsChEBUPAuqikbWBclxzTmUkWH5OjVjRtCB1k3sUm2KvP9xs1povC2vRn1Zjl0BGgUWUt2fHUGjv75hUMnnHJemC6dIbXJCv0ZaL7p0jYLt/LxUfcDj5XDImHvKy6gB7FJ6SNtob9jiiUMGUtvg2jaUBYuG3vNfCYpEzKtMNwszIZQ5TjY2YgmEzgKbxEQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=F836vKtLiIXOyQ9be0UUiEa2UdfVcKWuA/Uv9L5if5XQEz4T1RfxcNCS4X4n0QK7WvStCwMJ7+j+uRPiokixOTsEGhWiwGMlz9lzyChRRYK1feGg6GL+2F8769bvnRiN8n50loGFEP4nU8rZLX8TbiXTDb03qrpYwPI19feg7OZvUcQIVqzyPhGLT72+t31fckyMWzZaUhPLzyyZ+gF7LycBJGE332cRdKm68sFRRzxHPxs1An/hNjqt+qHujCrlunrMTFJDw/6GvzenXSqz1yrB0C3V4Ov75TvpSosJjfZsm/HlBL40flzFAbgXtwomX+MZNObHT1iDCf2nHRXx9w==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Thu, 13 Oct 2022 12:05:16 +0000
- Ironport-data: A9a23:olESeqgAAt597ugVgYaMDpnVX17brhtdkbtou6ucsGbSi6mo8ft2uZtPesM2Ph2Ov8aJ/3J7+ZAiuzu2VEYjOOrE3MaLAtYh/s/zv5qi/A6NH9G2nGeJcc1Bpjkd4/DhFxS+EX92VwSgaAVWIa6atagD0P57K1fj80te1/M5I6rlXP7R6pjZ30k3dC5dd0nihZtSCa4kUPaAwEIbFU8jkNxIwBD9me6xJs/SOqMDNGUXxOGqGgnk0stLv3GET14V+yrNInY4AGjZeFScDpS6R1dm3JVMiDZmiB0UZepx7cca85e/mAZzGI2/+eDzWgpHhR7utjbxJJ5Z9YlsFsXIBdK8S55AJs2McEDMQTeQdluaVx6UHqdPJ3GBBJtmZAg/ktSC67U67CHtyOOEe3CsYCuLUc1TFbQ+kI78SPO5+4036mSgfhpSmF5j4K6roNehJHQlL5czlh34Gr0ir3/qVvvn/r0wqVBncsIjMmR4yXAH+SixeJ3M5qwl+ETFMDw8A1W08WEzo5qlyYWsjWvDbkWZcmAzGQh2Ymv7AV/6FiJklnfCvzKbvyLA8cZ07gtmYyJ4AZNvpSyfzo+dqTqbkPu6lC7V1cwCL1bQA4tE0VXrfgXBBIlcoukZapaOi0xsV1uFnQOEbgJRIkqNijDLASOhtjFazhBmEG4ZgEFDVPiayw2O69sZWa17nCqYJNXh3PSjchO4BGJ1UCnfdVNV/Y2mFKnD0pukj+Ar36W7foDRP0K2msRc72J1CT0g3cF64/4qgdRkRYj6XdzzgudKK1SqVN5ZeooNvEM5vjoR7zLRzICC1/LM9eL2aeleozN2aB90gHe8QcJAM12lb2CcXS6x6FpuxtfPVebVqtDbPIkg7JtO9rPrbQgoTOREBUrl/WXfpb9AU/Lv9eqGyFRwgxhMwHKjSQWVOozcGXXi9Rf/U2Fc4Oev3hf4FeLSIBfuMl6bHs8ycEAjMa+GaEVncJi3YumBXvgFrdKm3na65hfcR4ESVjNKTVi0GbM7UdPXzq9vyYvgEidnZcNPRmyyYtmf7aSL3GYPdLctTNTEAcvHeg6M528RME7CWwm2u8mRs+Sk3VSGJqdwZkNAsv9bYWz9F53kMwcMr24F/G+8L3dgVRYQZEw3EfEEYPcEGd4ydQD95u/FiSi4qyZjCEp9eDMwKzy3SVB/nxicUUB1s/0ug8ET8FqREzLB3G8a+btCd+S0EO10dKzFJDWUXkJBESlwVw0lkzxCLK9w4WMNlVdnT9Gmmcy5H8ej89DWdPsKbA+If5fKyPD5C6BHCsClGP5G8oG/3dVHJI+/wKFnZCT4FNDPWbg2Jjg90Vblf2hZtU2ENYPQlbw4qObZLS1qR5yMS+sixJmv8dLZQ5YZfs9kvNsgjULt6bIz2pCl4ImmW/lCnaMKcHLs7Xr05JdoSW3BHxJ2jkO38YX9hDM2xm9cs5u9F6FTk6f3QuSiXWjyv+cSyRQZBnYJMItyTscN60Ce8Ph2faN9JSs7ByYaAc49kFkse52C6jnrNDhel5VZn4tMkS0M6GLC9OlpPewuk7jl7WnqoA63YW9KVUN03NpFZD7x3lj/6cfqPpqPQZatEnT/dQyUCG8/ASrp9uWLmiVjARA/ypQfqjxB9FAo7/nPRxsWb54RGowzqY/mmkZjkm49Lw7CG21krEU3YZgHfijpxRvMT4slDLfsmXfS1/dIniebUEjgNyodh/3+mzH+XIjaZpFIE9ypwAYXK76YknxJ4C6wvvNzG/XeHm2YNtST1I5OlU4m/r5HueWYwRLj+2IBKXjNSyTz0ltC60eqgBr63zeZaDKRV07g+pRbjfYsetSjFTzB4NL0wFqRJ4p9uJDgrgNpkW2kzBKpOjOBALBszhPRkhOhLmwIqL3fWk/IpoewdShJx38kxAP6+nGlZrAGXA/hX9DycwOOwtsrN/1EuxnTsO9ADNm7LU2fYXZD7njLIC4YdsRtz03hLHFNebqQBEAtDBWKrbYxoocFYtvA9xyD7ZGAu/tCIOglPv7bB6nB2H/WgJKpSSa/IIfR++chdXovSKLCg56EjO/AqJq0fim1epgBXA77Ah93jkX1LQRch+ZBYtuELj2XC+/XxdKu50yKM4GBW8W3H5GEfujpysBSRSbwovHhA9ep5aIijf1MJR2IDUjjlVMIb73oJGUB/1KsyU9FrzB5arBQnN3hPkvnXcHwyQlfsX0ZJVzbYZjBk5ZfkDz0Pzj5PtERMjJf3YkEAIzc+djRg5JdbWuKnxVSv1E+fk6MheWp8y4ItmgQCv66sDE6icqJ17FPDPaVjyISHXsjm+p0/0pyR6fJMeD9zVAxCmo6UlE2EWOeqbQ89jNSt7l9KCsi9oiV/7PR2rjorMQsI6hX1A31VKVCOKHb1qjvvIat5SwnTox1
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Thu, Aug 18, 2022 at 03:05:19PM +0200, Jan Beulich wrote:
> From: Artem Bityutskiy <artem.bityutskiy@xxxxxxxxxxxxxxx>
>
> This patch partially reverts the changes made by the following commit:
>
> da0e58c038e6 intel_idle: add 'preferred_cstates' module argument
>
> As that commit describes, on early Sapphire Rapids Xeon platforms the C1 and
> C1E states were mutually exclusive, so that users could only have either C1
> and
> C6, or C1E and C6.
>
> However, Intel firmware engineers managed to remove this limitation and make
> C1
> and C1E to be completely independent, just like on previous Xeon platforms.
>
> Therefore, this patch:
> * Removes commentary describing the old, and now non-existing SPR C1E
> limitation.
> * Marks SPR C1E as available by default.
> * Removes the 'preferred_cstates' parameter handling for SPR. Both C1 and
> C1E will be available regardless of 'preferred_cstates' value.
>
> We expect that all SPR systems are shipping with new firmware, which includes
> the C1/C1E improvement.
>
> Signed-off-by: Artem Bityutskiy <artem.bityutskiy@xxxxxxxxxxxxxxx>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
> Origin: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> 1548fac47a11
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Acked-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
I guess we need to be careful of running this on pre-production
hardware then?
Thanks, Roger.
|
