[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] xen/arm: mark handle_linux_pci_domain() __init



Hi,

On 14/10/2022 08:16, Jan Beulich wrote:
On 14.10.2022 04:53, Stewart Hildebrand wrote:
Signed-off-by: Stewart Hildebrand <stewart.hildebrand@xxxxxxx>

I guess a non-empty description and a Fixes: tag would be nice.

+1. I am actually quite interested to understand how this was spotted.

The build system should check that any function/data in domain_build.c are part of the __init section. So I guess the compiler you are using doesn't inline the function?

If so, I am actually surprised you are the first one spotted this... We are building on various distribution without any issues (?). I would be interested to know the compiler version and maybe we could add it in the CI.

Cheers,

--
Julien Grall



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.