[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [XEN PATCH for-4.17 v5 05/17] tools: Remove -Werror everywhere else


  • To: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
  • From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
  • Date: Fri, 14 Oct 2022 11:16:04 +0100
  • Authentication-results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Christian Lindig <christian.lindig@xxxxxxxxxx>, "Daniel P . Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Wei Liu <wl@xxxxxxx>, Elena Ufimtseva <elena.ufimtseva@xxxxxxxxxx>, "Tim (Xen.org)" <tim@xxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, David Scott <dave@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxx>
  • Delivery-date: Fri, 14 Oct 2022 10:16:18 +0000
  • Ironport-data: A9a23:B/H7oa5N7R7PmkTGmVeUVgxRtLvHchMFZxGqfqrLsTDasY5as4F+v mVNXDuDO6uDZGP9e4h0YIy38kJTsMWGmtJiSQVv/3xmHi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvymTras1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPewP9TlK6q4mlB5gViPaojUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c5sE1hqq PgyCApdNBGRqPOVmOOQF6pj05FLwMnDZOvzu1llxDDdS/0nXYrCU+PB4towMDUY354UW6yEP oxANGQpPE+ojx5nYz/7DLo3mvuogX/uNSVVsluPqYI84nTJzRw327/oWDbQUozTFZkJxhnAz o7A1zXAWQMfO8ek8muM0n+BgMX92gngc7tHQdVU8dY12QbOlwT/EiY+V1ShpuKiolWjQN8ZI EsRkgIyrK0a5EGtCN7nUHWQomOAvxMac8pdFas98g7l4qbd/QuxHGUPST9FLts8u6ceSDgn0 FbPgt3oACB0vaOcYXWH/7yQoHW5Pi19BWMafioFUQst6sHuup0ulQnISst/EamzlZv+HjSY6 yCHqm0yiqseieYP1r6n5hbXjjS0vJ/LQwUpoALNUQqN8QdRdIOjIYuy5jDz7/xNMYKYRVmpp 2Uflo6V6+VmMH2WvHXTGqNXRujvvqvbdm2H6bJyI3U/3y+/wlr+eapw2mEkJVVGI+VcKBS0I 0CG7Gu9+6RvFHetaKZ2Zae4BMIr0bXsGLzZaxzEUjZdSsMvLVHapUmCcWbVhjmwyxZ0zcnTL L/BKa6R4WAm5bOLJdZcb8MUyvcVyy833gs/rrirnk38gdJyiJN4IIrp0WdijMhjsctoQy2Pq b6z0vdmLD0GCYXDjtH/q9J7ELzzBSFT6WrKg8JWbPWfBQFtBXssDfTcqZt4JdI4wfQLyr6To yzlMqO99LYYrSSdQThml1g5MO+/NXqBhShT0dMQ0aaAhCF4PNfHAFY3fJorZ7g3nNFeIQpPZ 6BdIa2oW60XIhyeomR1UHUIhNE7HPhdrVnVZHTNjflWV8MIejElDfe+Ile3qXdWXnvr3Sb8y pX5vj7mrVM4b1wKJK7rhDiHljtdYVB1dDpOYnb1
  • Ironport-hdrordr: A9a23:I7/FP6H2RusG4lL0pLqE6seALOsnbusQ8zAXP0AYc31om+ij5q eTdZUgpHvJYVkqNE3I9eruBEDEewK7yXcX2/h1AV7BZniEhILAFugLhuGO/9SjIVydygc079 YYT0EUMr3N5DZB4/rH3A==
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Thu, Oct 13, 2022 at 03:13:32PM +0000, Andrew Cooper wrote:
> On 13/10/2022 14:05, Anthony Perard wrote:
> > diff --git a/tools/debugger/gdbsx/Rules.mk b/tools/debugger/gdbsx/Rules.mk
> > index 920f1c87fb..0610db873b 100644
> > --- a/tools/debugger/gdbsx/Rules.mk
> > +++ b/tools/debugger/gdbsx/Rules.mk
> > @@ -1,6 +1,6 @@
> >  include $(XEN_ROOT)/tools/Rules.mk
> >  
> > -CFLAGS   += -Werror -Wmissing-prototypes 
> > +CFLAGS   += -Wmissing-prototypes 
> >  # (gcc 4.3x and later)   -Wconversion -Wno-sign-conversion
> >  
> >  CFLAGS-$(clang) += -Wno-ignored-attributes
> >
> 
> This hunk introduces trailing whitespace.

No, but it would be a good opportunity to remove it, I agree.

Cheers,

-- 
Anthony PERARD



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.