[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH for-4.17 v5 00/17] Toolstack build system improvement, toward non-recursive makefiles
- To: Anthony Perard <anthony.perard@xxxxxxxxxx>, Henry Wang <Henry.Wang@xxxxxxx>
- From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- Date: Fri, 14 Oct 2022 10:31:48 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PE86i4T4FUCEJzA1ciNQcL/ZBkq9E4Hd28jjXeVn9ZY=; b=b4Vz5nTntq2ipw2tFTynenDCQUrYd8ZlO7P71AGhNDZzfKa88tb11V/Spc6qtORFIZtl2w93yAzwc2DHvPJ7ABZh4B7nNX73onmuYDu8sWzC95+wug0319oZwBRdIPH8iW96yzMNtaSIxigNwXt+eafLg7R91b3McoL1NRIFVRmAwnIW/rXH3bloz3mguNAGQA51lXLKdrO1LGd3f1A70UvaAEiOxtcV4QtQAwkHbUkNPw0ZRPt+Hm7MaDbqJ+ia6maskdHFyqxCvRIM1dbry/BkQLtCUw/TN0DD72sa70mqozegjv+cs/Al9actQV04I7LCsZDWJfWCZHrQM0qwXw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=On+jnMSuSWwtIrh+kLDEvKZKK+H0mI0vMjDS/FqV6ly6ybAogsN1NuH6QUEba3/qaDr8Jdor4JDKpA2JW5USJguio4Mdbg05et9OdSj62INx1s1x0HanCZ8ssolI4K05K9LBySgRluB4A36pfyFm4IpJyNLNg7YZAIfAx/Zg9aEPAlgNN/bIb5tb5PbMfE6zlnQ3GDP3+LyuzKfgcRWJF5idSagkMBP5SXeqD/UfoLcDZo8ho8nfSPjbfNFh7KxZtxYNW+p/fsvNxD7XcrYjj4iuJRkg+qFkrp0F7xW8WX6SB0n5YL2hsGIkTLNhHx2NNq7iR9GhcSXM7un9DzmPkw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Fri, 14 Oct 2022 10:32:12 +0000
- Ironport-data: A9a23:9EcmFKyg2w/FXndpvFd6t+cqxyrEfRIJ4+MujC+fZmUNrF6WrkVVm jNLWTiAa/uMNmejftt/atjk8kgPuZLcy9AxSlFp+yAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHPykYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbyRFtspvlDs15K6o4WtB4gRkDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIw895cBX186 sAhJnMpfx+nqcWT+KuKY7w57igjBJGD0II3nFhFlGucJ9B2BJfJTuPN+MNS2yo2ioZWB/HCa sEFaD1pKhPdfxlIPVRRA5U79AuqriCnL3sE9xTI+OxuvTm7IA9ZidABNPL8fNCQSNoTtUGfv m/cpEzyAw0ANczZwj2Amp6prr+UxH6gCdNDfFG+3s9wpgaw/3NQNAE5fEOnp/+9sV7gGN0Kf iT4/QJr98De7neDbtT7RQz+n3eCsTYVQd8WGOo/gCmdx6yR7wuHC2wsSj9adMdgpMIwXSYt1 FKCg5XuHzMHjVGOYXeU97PRpzXiPyEQdDUGfXVdE1pD5MT/qoYuiB6JVsxkDKO+ktzyH3f33 iyOqy89wb4UiKbnypmGwLwOuBr0zrChc+L/zl6/sr6Nhu+hWLOYWg==
- Ironport-hdrordr: A9a23:Ukf8ka4Lbgav9wgNAAPXwWuBI+orL9Y04lQ7vn2ZFiY5TiXIra qTdaogviMc0AxhI03Jmbi7Scq9qeu1z+853WBjB8bZYOCAghrlEGgC1/qp/9SEIUHDH4FmpM BdmsRFaeEYSGIK9foSgzPIXOrIouP3lpxA7N22pxgCcegpUdAY0+4TMHf4LqQCfngjOXNPLu v42iMonVqdUEVSSv7+KmgOXuDFqdGOvonhewQ6Cxku7xTLpS+06ZbheiLonys2Yndq+/MP4G LFmwv26uGIqPeg0CLR0GfV8tB/hMbh8N1eH8aB4/JlagkEyzzYJ7iJaYfy+Qzdk9vfrGrCV+ O85CvICv4DqU85uFvF5ycFlTOQiQrGoEWStGNwyUGT3fARAghKRfapzLgpDCcwoSAbza5B+b MO0GSDu5VNCxTc2Cz7+tjTThlv0lG5uHw4jIco/jViuKYlGchsRLYkjTVoOYZFGDi/5JEsEe FoAs2Z7PFKcUmCZ3ScumV02tSjUnk6Ax/DGyE5y4eo+ikTmGo8w1oTxcQZkHtF/JUhS4Nc7+ CBNqhzjrlBQsIfcKo4DuYcRsm8DHDLXHv3QSqvCEWiELtCN2PGqpbx7rlw7Oa2eIYQxJ93g5 jFWEMwjx9HR6svM7z64HRmyGG/fIzmZ0Wd9ih33ekIhpTsALz2LCaEVFci18O9vvR3OLyoZ8 qO
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHY3wR19l5fPoXHX0uqLO79kk12za4MneoAgADPvoCAAD+0gIAABO8A
- Thread-topic: [XEN PATCH for-4.17 v5 00/17] Toolstack build system improvement, toward non-recursive makefiles
On 14/10/2022 11:14, Anthony PERARD wrote:
> On Fri, Oct 14, 2022 at 06:26:09AM +0000, Henry Wang wrote:
>>> -----Original Message-----
>>> From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
>>> Subject: Re: [XEN PATCH for-4.17 v5 00/17] Toolstack build system
>>> improvement, toward non-recursive makefiles
>>>
>>> On 13/10/2022 14:04, Anthony PERARD wrote:
>>>> Patch series available in this git branch:
>>>> https://xenbits.xen.org/git-http/people/aperard/xen-unstable.git
>>> br.toolstack-build-system-v5
>>>
>>> I've done a full rebuild of this (with the 2 noted fixes) with Xapi, and
>>> it does resolve the Ocaml library linking issues. Thanks.
>>>
>>> So T-by. If an allowance for 4.17 appears, I can see about getting some
>>> of the more obviously-trivial areas reviewed and committed.
>> Release-acked-by: Henry Wang <Henry.Wang@xxxxxxx>
> Thanks.
>
>> Since this series is quite large and just out of curiosity, do we have a
>> pipeline or CI jobs to test all the modules that affected by the makefile
>> touched by this series? Would be good to have some test results to
>> boost our confidence of committing the series.
> I did push my branch to Gitlab, and that the pipeline:
> https://gitlab.com/xen-project/people/anthonyper/xen/-/pipelines/665987083
> (private to xen-project members)
> Only failures are I think the same one as on staging, test failure on
> arm, but no build issues.
>
> I'm not sure that everything is tested, but most of it is.
The XenServer specfile lists all build artefacts specifically, because
we've had too many bugs where things have silently disappeared.
My testing confirms that nothing has appeared or disappeared as a result
of these changes, and the functional looks pretty good. (except for the
latest shadow assertion found, which was a regression in XSA-410. Fix
is in review elsewhere.)
~Andrew
|
