[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v2] xen/arm: p2m: Populate pages for GICv2 mapping in arch_domain_create()
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Fri, 14 Oct 2022 11:04:46 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1WIx7+9Kmj0jZaJfjK06rhnidXq+sl8u1mnTolCGvrc=; b=DCHPbfVV8j8tbRMC3ZAcd/3dUF1+nVdapH7m+uvmB48T/TFTGY5R/d2Pi5tH4fuyN0Hu/eyzibElKUBdC6vrBvm3z2uaDaMq11YHiOxsSOyDGoeFH8Dt/4sAxuDf++rwyi9yvEY0ahoqi29zy77tGbwC7EZHZ2kvYg7B5w1/yHI2EVk/iO7UpYiQ/rrmoAQ7Rd2R96HzL+/axUkLMTK8mpbALcwUCFfM7rUiFn+ZyA9MGb1JmLPV4n+SNGsDrqLUApCXDak2YCaFVAAyIFBa/lcKqyM6vdydOOOX/8lHuY9rss8lx2KVg5aZlis5oUzfECoCzpqsmsCXCqOvRbYUPQ==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1WIx7+9Kmj0jZaJfjK06rhnidXq+sl8u1mnTolCGvrc=; b=e3S2nkkoirzFPaXy8UPekxVUUYh3bBEcVFVc/Ik0OV7NSUhzUPgBzg+Ox9/6RVU4k20MXfVhJTALqWW9uWELZoSpYLF+8657/tsno1JA3bej7EnnZyTys53pzuPaiYP4nla3P+7Ht2LGfVxGfsr/fGs7xHVVdi0wzYAAyAh45WTnWqQedvRx+cSm96SKUA8uV1Zm8pj/HQ9myK+zGOH88YAQ4vYPzcdFg6s4/EDotMg46N+PlhaaSrHTBhTCM195HY/oxI3RESpNnJuVfESakUyoT2kveTKtMBXiMKp7XY/ZJ0nu6XTBT3AhRoRrEqHX7oRRTFsms6uLqoEaLCigTA==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=URDv07kzyKn++dAAhjm0guzY3IKUWavkt2EWoXVzHkG/DJldoFNRdPKZHDqL0CYvQA/9zsVnr0GDUyDgfjdcHv5P1XH/C6mq4j52fobmtcqNwCtyJ3nSx+STGQr2cWmqOwY19qe8m1ul5Igw6f12fP/ZnT+CvqnIliXuUqyVaQ0ilVBTbAZu5P/WlrnmmfyEOF8sNW2EmJaKUUn7HO9t9+TyNIpjZdm4dO9POR0rx/+laVS+k4oYWkaGhiuj+8OF1Vq38AGb/sQ7DsK0G+0Xrmn1RpueibPqBKIES1Jt479FoxIX+1a84wpev8c2l/LepjidTeBOVVL3tqiNpXlAVQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UGfIh1GmoaNURPzh6anAQQ7Hl0mDuqQF0H5YBqJMwZ9NxzZLPis8inyKNxaGbY/z2hI3RwFqYElKYse8D2nmFV4MN3C4UJiTFpVQNkw3SL8uBiiWZihNQ9fZsAUvtsjfvdjXjyqeXpfQYenFIywE+nlcUh0RANuKCaURXmt7M+mY66UePxLniPRryE5Jy62eCL8OWcuKZzHpMZsU5UtGfj/pTEE11PSqCCzpJ3z5yZ0Lk2NtcvOhzQ4SrHfVkF2bPeVTRiUNn/xzzX6MICHQz4qd/rY0dG24qFOP7qGV9oPfnNtGgiHdZhKNGM/RNjqtaY7vPNvU2iOgqdHCAch8GA==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Wei Chen <Wei.Chen@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>
- Delivery-date: Fri, 14 Oct 2022 11:05:09 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHY36RSrOIThkYtnEq9RrtWc+uYX64NnUwAgAAAd5CAAA4NgIAAAPkwgAAIMgCAAAAtcIAAA6oAgAAAMLA=
- Thread-topic: [PATCH v2] xen/arm: p2m: Populate pages for GICv2 mapping in arch_domain_create()
Hi Jan,
> -----Original Message-----
> From: Jan Beulich <jbeulich@xxxxxxxx>
> Subject: Re: [PATCH v2] xen/arm: p2m: Populate pages for GICv2 mapping in
> arch_domain_create()
>
> > My initial thought is the "else if" part in p2m_set_allocation. It might be
> > wrong. Would the code below seems ok to you?
> >
> > int err;
> >
> > do {
> > err = p2m_teardown_allocation(d)
> > } while ( err == -ERESTART )
>
> Sure, one of several ways of doing it.
Thanks for your confirmation. Just to play safe if you have more simple
Solutions please do raise it. It is a good opportunity for me to learn and
personally I am not a big fan of either do-while or the introduced "err"
which is used only by p2m_teardown_allocation(d), considering the
p2m_final_teardown(d) has a void return type...
Thanks for your patience in advance :)
Kind regards,
Henry
>
> Jan
|
