[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 06/12] xen-hvm: move common functions to hw/xen/xen-hvm-common.c
- To: Vikram Garhwal <vikram.garhwal@xxxxxxx>, qemu-devel@xxxxxxxxxx
- From: Julien Grall <julien@xxxxxxx>
- Date: Sun, 16 Oct 2022 19:07:44 +0100
- Cc: stefano.stabellini@xxxxxxx, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>, Paul Durrant <paul@xxxxxxx>, "Michael S. Tsirkin" <mst@xxxxxxxxxx>, Marcel Apfelbaum <marcel.apfelbaum@xxxxxxxxx>, Paolo Bonzini <pbonzini@xxxxxxxxxx>, Richard Henderson <richard.henderson@xxxxxxxxxx>, Eduardo Habkost <eduardo@xxxxxxxxxxx>, "open list:X86 Xen CPUs" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Sun, 16 Oct 2022 18:08:01 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Hi Vikram,
On 15/10/2022 06:07, Vikram Garhwal wrote:
+void xen_register_ioreq(XenIOState *state, unsigned int max_cpus,
+ MemoryListener xen_memory_listener)
+{
[...]
+
+ xen_bus_init();
+
+ /* Initialize backend core & drivers */
+ if (xen_be_init() != 0) {
+ error_report("xen backend core setup failed");
+ goto err;
+ }
+ xen_be_register_common();
Calling xen_be_init() and xen_be_register_common() from
xen_register_ioreq() sounds wrong to me. There are no dependency between
the two. I think it would be better to create a new function to register
backends.
Cheers,
--
Julien Grall
|
