[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v2] xen/arm: p2m: Populate pages for GICv2 mapping in arch_domain_create()
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Mon, 17 Oct 2022 08:43:25 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=K7t2ZzJlBiNTtLVHmLpMV3QEkEAT7aLIzdqvyTDY8mA=; b=N1i3NJnUBis55iE1nxQlM20WbbJtYthgc/XaRYA4Fr68wuVh+x/kMr3he7lrXxGO7BTwTcsZO3NLg5GXlodKHsHzco5+52/Mu8IVgMI5UY59m+tN54bUTgiZXPkUDIWBS3wPqq6kKL0m0cdW//t5Bqk0dWuRIu7W6K0Vpr+qytlBhRb/nYYBOCWilHA17CIpByWnVCro0c3YqjVU9G1Z6lXyTi7V54BCh9GybERnuq0nDjQWw5mmz2pUVkJiehPmOWC/IUF+aXOg2Y66TjLQOG1ZBSL5TtMAgkRGH8d4jQsHPPHX0LH7XrnvVFK8a0R95LQChTvfK0q7dPiPc5x7eg==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=K7t2ZzJlBiNTtLVHmLpMV3QEkEAT7aLIzdqvyTDY8mA=; b=MArEMaaFBPxX5YE01+Jr1QHHdw96uHVELtSHvMkL8QW8Nx5SRjvH5OF1s+FqQ8OOaglT4VdWPYOZdPJyt6VzOgIXtCmjGpHTrsZMNLXlZG3mjD0t/OgfkFzSn20BIkkU0CFRCMgHgsc9qhGmNaMURkr1b4Ke6YTsce/lo1by8YwQ2yXJHf1z0Xp6YXx6YftisibtfIzyAIScPk8t5BujjZuDnVC6fnTn2DqH6db+9BT0OQ0mBQmW7yBz9T644A+TXm1WNuhrRAG4ZQAXPO1rwjUjTC+HfUlMDe3ShuGI8HsDlWroS5oYCLT0eMOrtqWIn8s9T1hFblZHXcg26YLGCA==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=PP8uce3Zx10pkIM9quo2C6wweLsQhpJPXyxTu5BkVriFCEpiwEVYpDyOm9QHRjXnV24ziu4vBjXRqwCMj18Tk2DHwYMXddIUfNK4RQw1WAWDeP8Woie47Rp1zaS61EPUSBK4sJbmo8OBIZE4eGDUHIObIRaK5Pzo/0cXV8TGKbfP2ZTejmSpeaN0OHYuhU5OuvP/Yoyf/vwgoGzaOcuVrwfiwu4TIGaqG2Msb/zg1m6KmDtpuD7KFRfGDmpGhg4GycxCy+PgLyNByGUL6CYOA1FIlZpAC2HjVKfnh87DKh+7rMctbybmx17J4aEOtzQzlNBa7F6KiE/lELWZC1OH5w==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cmqykeYNBgdPO30Yet95nSFAKQdPNxqraFkxNubeju3x2sUgKPsgqGa3Al/fpDmOgRw3OF4tP5twXdZfW1Bj54eZ29lxaQjeQh+sFkPhM8TJQSxFBMTw/md+59+IZgkL11PC26dOwTFWlo5J1IQwISh6KrjsVDgiegcSU1crFoU2C1AT7HNWdyHynmUktoJ6sQE0ylN/UbJprbpBQ0DyhIlAdCc5jYBCMM9N0gZC9vlVONh/ut7xsJevvCEKgWxombijN0iBZ6QGyD8KaFhV7eZ69Eu3QE+HTK+KZ5+WuupG3wlseaDsx4v9PMTmvPwlNtEgJ7KND4H9PbAS1MdQqA==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Wei Chen <Wei.Chen@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Mon, 17 Oct 2022 08:43:45 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHY36RSrOIThkYtnEq9RrtWc+uYX64NsO2AgAACdYCAAZeJAIAAAyvQgAL68gCAAABLsA==
- Thread-topic: [PATCH v2] xen/arm: p2m: Populate pages for GICv2 mapping in arch_domain_create()
Hi Jan,
> -----Original Message-----
> From: Jan Beulich <jbeulich@xxxxxxxx>
> > I added the doc asked in your previous email. Also, I will use a
> >
> > ASSERT(p2m_teardown(d, false) == 0);
> >
> > in p2m_final_teardown() here.
>
> Hopefully this was meant only as an abstract plan, not the exact code
> you mean to add? ASSERT() expressions generally should not have side
> effects (which includes function calls).
Yeah, when I wrote the v3 code I noticed that ASSERT might be limited
to the CONFIG_DEBUG so in the v3 I switched to BUG_ON which IIUC
can make sure the function call is valid all the time.
Kind regards,
Henry
>
> Jan
|
