[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v8 1/2] IOMMU/VT-d: wire common device reserved memory API
- To: Henry Wang <Henry.Wang@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 17 Oct 2022 10:55:33 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7DHxrCnKMCK7Ld609K3m/CjFfyYBY1XExiR573qMtMs=; b=H6BufnOk0GwTIttlKHGoZaPPcd7y87m6aouXJ+wpG/cYD70ga3IqKiAd82MF4hcv5sZ86w60Ofppu4MmatJC+kRF0ijLA4Okag7uyv92ihCwV3f6WpwqABFjZzZHmGjiECOdVSyedbqlN+mhBaby48J0eAdPvfwEQvh2e0HG04+LYYk0Kr59JNjhliYwqaa7uyn7oVpd8zkaHh7dtVaU7scqeM6TdA0isPiHx0l0pVm3vJE/FKKN2aXXcOam5xWwcweiCa+MtXQxxhEpcYjr93Xg93tJ7ApOl1Q2gT9Fnxg4Wuuxac+Hh9D7UHVX3cDWGzX5qk2ClnsWDOYy5AKphA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VBPM3sSys4y6h7re5Wihw3XmxPz5CuJpBRDs1XKyUKDgFfxLm8foL16Uok5W7uniAOsYkO6veSKCeV1fx/FXJOgt6BExBXT62W+94fpxKiNoJ0e7AgJrynrdx9NjA9Vk0KDTe3qkYiOIdealSK1OXyf8+XtHlsqw8g/Q/lcLp+IDGS87/O+VFaMX0lunW3/v3rEq0AfVzJ1ZRNphGCUsy3lzuMez6qMmciB0jJgdCqn0PlUVioq/4CPdNxWWlvENN3B/08bzBwG9Ljjv4IXFz/0L6BROb0KLv539E8iOQT1Q/rFncrKNfKHotC+eXXlp7flVQ1vB6pITlbl7UVoniQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Kevin Tian <kevin.tian@xxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Mon, 17 Oct 2022 08:55:50 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 17.10.2022 03:20, Henry Wang wrote:
>> -----Original Message-----
>> From: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
>>
>> On Thu, Sep 29, 2022 at 03:33:12PM +0200, Marek Marczykowski-Górecki
>> wrote:
>>> Re-use rmrr= parameter handling code to handle common device reserved
>>> memory.
>>>
>>> Move MAX_USER_RMRR_PAGES limit enforcement to apply only to
>>> user-configured ranges, but not those from internal callers.
>>>
>>> Signed-off-by: Marek Marczykowski-Górecki
>> <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
>>> Reviewed-by: Kevin Tian <kevin.tian@xxxxxxxxx>
>>
>> Henry, can this be included in 4.17? The AMD counterpart went in
>> earlier, but due to late review on Intel part, this one didn't.
>
> Thanks for the information. I agree this is a valid reason, but to be
> safe I would like to hear opinions from the x86 maintainers (added
> in CC).
>
> Andrew/Jan/Roger: May I have your feedback about this? Thanks!
Hmm, not sure what to say here. Yes, it would be nice for things to end
up consistent across vendors. And yes, the change here is largely
mechanical (afaics) and to code most of which shouldn't typically be in
use on systems anyway, and so should not pose an undue risk. But still
it is quite a bit of code churn ...
Jan
|
