[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v6 1/6] xen/x86: Provide helpers for common code to access acpi_numa


  • To: Wei Chen <wei.chen@xxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Tue, 18 Oct 2022 15:26:26 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gclX7OTZ/dgr1mtcKCPuoV+U3KTDJR5J0WaTMbJGv7U=; b=LYJ8XxkuOmhaIUNUjro+ubJ/S18h5N97iRz/05zakfp2rIXrOltx7ASyKYA7CkmRnVXMarg0kFX3uzIjpd2TXulAUyFBFE4hkA9SOPfK2DZ4yv02Ndg7qHwTcclJdR7SCxz6UoKz1KCebenis6QxeF6at1E7bXRBzxQR653KoLvIZJrs6UemexHCiazhHbRW84yVU9vIdXCFELWYcKPVo/Z4x5QCP7Qq6ZoNEi4K7yfPtrLXqmTNyady7RgK+ek/k+lFYDDXAvMn7Fg46ij3Edqhhph8TV+yhTqez3klIOIgpg1SldsQGrpav6eJaHrj/zbdJcdGKOBpnQTNGO/jIw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=a+Sm6LI14o3ca8LQb9e+CC9JdTr2lpeW1Tlbr5y3iLlKhfYZegALWr+mblsIb5hwQL56v0+SPyI1ah6ZRKA5ue1SZrJ86BE4bErTC6l51C674YOgjKGbhEcNemHhI6p7jchX31vVh2Up+Bva5SX0uQOctq/6v/X3u2u6X25SRLfNt9Lwj5lmqKmr+RcW221rLTltjmz1AyE8jxZMh62p9RsKRk9KtEbdYZZRZpCStB/VC6AitX5PP/wqGFIEnfPKxXAwfpjOkn6og9Nv+Bt/b+/Yp+K0FpLDxAYgdyhQhCSlk3PgGp4/eVH1CHPBT/BXpdvNsT8jdV54FdvrWp1P0A==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: nd@xxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Tue, 18 Oct 2022 13:26:42 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 11.10.2022 13:17, Wei Chen wrote:
> acpi_numa is a specific NUMA switch for ACPI NUMA implementation.
> Other NUMA implementation may not need this switch. But this switch is
> not only used by ACPI code, it is also used directly in some general
> NUMA logic code. So far this hasn't caused any problem because Xen only
> has x86 implementing ACPI NUMA, but now Arm is implementing device tree
> based NUMA. Accesssing acpi_numa directly in some functions will be a
> block of reusing NUMA common code. It is also difficult for us to replace
> it with a new generic switch, because it is hard to prove that the new
> switch states can guarantee the original code will work correctly.
> 
> So in this patch, we provide two helpers for common code to update and
> get states of acpi_numa. And other new NUMA implementations just need
> to provide the same helpers for common code. In this case, the generic
> NUMA logic code can be reused by all NUMA implementations.
> 
> Signed-off-by: Wei Chen <wei.chen@xxxxxxx>

Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>





 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.