[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [XEN v1] GICv3: Emulate GICD_IGRPMODR as RAZ / WI


  • To: Ayan Kumar Halder <ayankuma@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Michal Orzel <michal.orzel@xxxxxxx>
  • Date: Wed, 19 Oct 2022 17:49:28 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BeGba4M/2lBAEih9NOwNpf78NbOThvzF8ia69VsVhwA=; b=oX5oqsoegXhRUTIkCqiqFSskDTj/ReY+BOuehHoILd+PDdMRf60sZZbNAV25kg99VWMqbf3xBKmZ1VTdABTssxTV+b2h+o2Uh7bXI/PL8WtMqfGc7jvKfMiWCeYJHkfMgtZkNaI81ZHFFuNIluX9tmo7sHrAE+RJ1un2EKsuibTqNS4SgaxBinKZl99eg/Eu3NdQbOczVyp4Wc7BBUSlsVYq4B9MoxfL9Ws8e5RwZBsSrR81lCvUtdZgMtFxkeSZrmxqO7SxaUyWCkaprCnbv5UdzXE4ONz938qDfMciCbhBBkEtWI/tJeqdk/ti7TY4kBetRXP64Gc8CzHMK1JfBw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P++uulnqIbBhnm/TQqfw6Tlg+HOGrB2PrP0QYJJrhpEGew+ugj45KnDrMTkwfzT8puH9ZPHaKtnFCeKm7JiY9cn/vBmvzgDDZV3vMcG5Nos23atgCwciu6xADgK1Cv90Hfa8wvxM6EQGFABmBicWIOg98zDvGX2sqKU5TLAtvwSdp8cQr2mNuvTijOfcXL870YR4RHH2xjpoy7g3oZgwI1ucONL9FoM/8y7XaFGJvb5E8Cxn/9U98oqxAwxsuOjct6KS3068aVqtUmYdScSj2gKnrg8VDMY9EHzxfQ4yqdoxtOCNpjGX5fzPaEr/agQsMMW9NXUu2uAxeltCOSllJQ==
  • Cc: <sstabellini@xxxxxxxxxx>, <stefanos@xxxxxxxxxx>, <julien@xxxxxxx>, <Volodymyr_Babchuk@xxxxxxxx>, <bertrand.marquis@xxxxxxx>
  • Delivery-date: Wed, 19 Oct 2022 15:49:52 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

Hi Ayan,

On 19/10/2022 16:36, Ayan Kumar Halder wrote:
> 
> 
> Refer GIC v3 specification (Arm IHI 0069H ID020922), IGRPMODR (similar to
> IGROUPR) is relevant only when the guests run in secure/non-secure mode.
> As Xen does not implement security extensions for guests, so the registers
> are emulated as read as zero/write ignore.
> 
> Signed-off-by: Ayan Kumar Halder <ayankuma@xxxxxxx>
> ---
> 
> Observed the issue while running Zephyr on R52.
> Also, found that KVM has similar behaviour.
> 
>  xen/arch/arm/include/asm/gic.h | 2 ++
>  xen/arch/arm/vgic-v3.c         | 4 ++++
>  2 files changed, 6 insertions(+)
> 
> diff --git a/xen/arch/arm/include/asm/gic.h b/xen/arch/arm/include/asm/gic.h
> index 76e3fa5dc4..998dd62651 100644
> --- a/xen/arch/arm/include/asm/gic.h
> +++ b/xen/arch/arm/include/asm/gic.h
> @@ -48,6 +48,8 @@
>  #define GICD_ICFGR1     (0xC04)
>  #define GICD_ICFGR2     (0xC08)
>  #define GICD_ICFGRN     (0xCFC)
> +#define GICD_IGRPMODR   (0xD00)
> +#define GICD_IGRPMODRN  (0xD7C)

These registers are GICv3 specific and as such should be defined
in arch/arm/include/asm/gic_v3_defs.h.

~Michal



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.